fix: eliminate all compiler warnings for clean CI under -D warnings#104
Merged
Conversation
- Remove ~100 unused imports across 48 files (via cargo fix + manual) - Fix ambiguous glob re-export collision (grammar_engine vs substrate CognitiveState) - Make BufferPage pub to fix private-interfaces warning - Rename Greek letter identifiers (μ→mu, σ→sigma) to ASCII - Rename confusable identifier (o→outcome_val in cog_redis.rs) - Fix overlapping match range endpoints in classify_signal - Fix dead variable assignments in unified_engine scan - Simplify corpus chunking to eliminate dead mutable binding - Change undefined cfg(feature = "async") to cfg(feature = "flight") - Add test-only imports for types removed from parent by cargo fix - Prefix unused bin params/fields (_state, #[allow(dead_code)] kv) Result: 0 warnings with RUSTFLAGS="-D warnings", 627 tests passing. https://claude.ai/code/session_01PWXQjdmnMQvZEN5BuBRNMq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result: 0 warnings with RUSTFLAGS="-D warnings", 627 tests passing.
https://claude.ai/code/session_01PWXQjdmnMQvZEN5BuBRNMq