Clippy cleanup: reduce warnings from 191 to 24 across workspace#171
Merged
Conversation
AdaWorldAPI
force-pushed
the
claude/review-rustynum-pr-80-2zNy5
branch
from
ccd4561 to
1d5abf4
Compare
- Migrate deprecated bundle_byte_slices → try_bundle_byte_slices (rustynum_accel, bind_space) - Migrate deprecated rng.gen() → rng.random() (spo.rs) - Replace Default::default() mutation patterns with struct literals (lance.rs, lance_persistence.rs) - Fix .clone() on Copy type [u64; 256] (proof_tactics.rs) - Fix filter_map → map where Some always returned (flight/server.rs) - Fix .clone() on double reference → dereference (cypher_bridge.rs) - Fix is_multiple_of clippy lint (wide_container.rs) - Fix loop-indexing → iter_mut().enumerate() (wide_meta.rs) - Fix manual slice copy → copy_from_slice (wide_meta.rs) - Remove unused imports and variables across spo/, orchestration/, flight/ - Fix redundant field names in struct init (causal_trajectory.rs) Remaining 24 warnings: 21 crewai-rust dead code, 2 n8n-core, 1 spo::spo module naming. https://claude.ai/code/session_0152b2NJYnjCJjvMAmgsTx3p
…dHalo, SignificanceLevel) Tests in gestalt.rs and causal_trajectory.rs used types that weren't imported at module scope, causing compilation failures under --lib tests. https://claude.ai/code/session_0152b2NJYnjCJjvMAmgsTx3p
AdaWorldAPI
force-pushed
the
claude/review-rustynum-pr-80-2zNy5
branch
from
f2bd789 to
52297a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remaining 24 warnings: 21 crewai-rust dead code, 2 n8n-core, 1 spo::spo module naming.
https://claude.ai/code/session_0152b2NJYnjCJjvMAmgsTx3p