fix: kill serde_json from lance_parser — Python is dead#172
Merged
Conversation
Replace HashMap<String, serde_json::Value> with HashMap<String, ParamValue> across the entire lance_parser sandbox. ParamValue has five variants: String, Int, Float, Bool, List. No Null, no Object, no Number ambiguity. serde_json was a Python artifact — JSON parameters came from Python callers. Ladybug-rs callers send typed values through MCP or BindSpace. The bouncer no longer carries a clipboard written in a language the building doesn't speak. Tripwires clean: grep serde_json lance_parser/ → nothing grep mesh imports lance_parser/ → nothing cargo test --lib -- lance_parser → 105 passed, 0 failed https://claude.ai/code/session_016SeGMg1pgf1MqK8YWkedvV
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace HashMap<String, serde_json::Value> with HashMap<String, ParamValue> across the entire lance_parser sandbox. ParamValue has five variants: String, Int, Float, Bool, List. No Null, no Object, no Number ambiguity.
serde_json was a Python artifact — JSON parameters came from Python callers. Ladybug-rs callers send typed values through MCP or BindSpace. The bouncer no longer carries a clipboard written in a language the building doesn't speak.
Tripwires clean:
grep serde_json lance_parser/ → nothing
grep mesh imports lance_parser/ → nothing
cargo test --lib -- lance_parser → 105 passed, 0 failed
https://claude.ai/code/session_016SeGMg1pgf1MqK8YWkedvV