Commit 08b6417
committed
review(#507): 5+3 agent fleet — FIX-A repr(transparent) + const _ guards + fmt + asserts
8-agent review fleet (5 specialists + PP-13/15/16 hardeners) against the
4-task unblock-cascade (PR #507): zero REJECT, but two real defects all four
green test suites missed.
P0 — incomplete cherry-pick (PP-16 root cause). Task 2 cherry-picked
463d71b's mailbox_soa.rs half (+149) but dropped its causal-edge/src/edge.rs
half (+6: #[repr(transparent)] on CausalEdge64). The SAFETY comments cited a
repr the type didn't carry — sound on today's rustc by newtype-layout
coincidence, unsound by the letter, invisible to CI.
P1 — fmt --check overclaim (PP-13). The 4-task entry said "clippy/fmt clean"
but only clippy had been run; cargo fmt --check failed on PR-added lines.
Fixes:
- FIX-A: restore #[repr(transparent)] + doc on CausalEdge64 (edge.rs:148-156);
add const _ size/align guards at edges_raw/meta_raw cast sites; corrected
both SAFETY comments.
- FIX-B: cargo fmt across all 5 touched crates; fmt --check exit 0.
- FIX-C (PP-15): SurrealMailboxView::from_columns debug_assert_eq! ->
assert_eq! (release-build OOB closed); + from_columns_rejects_ragged_projection panic test.
- FIX-D: pub fn base_path() on VersionedGraph; deleted format!("{:?}")
Debug-scrape (embedded-quote truncation hazard).
- FIX-E (PP-13): test_edges_raw_meta_raw_reinterpret_round_trips — the
unsafe cast had ZERO coverage; now bit-exact round-trip + pointer-identity
asserted.
- FIX-F/H (P2 docs): hhtl bijection 0..=16 -> 1..=16; drive_at_latest scope
note + versions().last() upstream-pagination caveat tying ascending-sort
assumption to the lance =7.0.0 pin.
Process lesson -> EPIPHANIES E-CHERRYPICK-SPANS-CRATES-1 (queued).
Board hygiene: AGENT_LOG.md prepended in same commit (this commit), per the
mandatory rule — no retroactive cleanup.
https://claude.ai/code/session_01Xzyc27Nx3f8WC5KzwfWfjx1 parent 8017ca1 commit 08b6417
35 files changed
Lines changed: 2864 additions & 1100 deletions
File tree
- .claude/board
- crates
- causal-edge/src
- cognitive-shader-driver
- examples
- src
- bin
- tests
- lance-graph-contract/src
- lance-graph/src/graph
- surreal_container/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
1 | 24 | | |
2 | 25 | | |
3 | 26 | | |
| |||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
69 | 69 | | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | | - | |
| 91 | + | |
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
| |||
0 commit comments