Skip to content

Commit 0ae45b0

Browse files
authored
Merge pull request #486 from AdaWorldAPI/claude/lance-graph-ontology-review-Pyry3
docs(unified-soa): PR #434 post-merge review addendum + governance status flip
2 parents f2ba8b8 + 478dc5b commit 0ae45b0

7 files changed

Lines changed: 307 additions & 4 deletions

.claude/board/AGENT_LOG.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -689,6 +689,31 @@ Opus review agent: **LAND** — no P0/P1 (exhaustively verified: coldest == evic
689689
**Outcome:** DONE (contract slice; consumer impls deferred). Realizes the planner⟷ractor⟷surreal wiring as an EXTENSION of the canonical `OrchestrationBridge` surface (lab-vs-canonical ruling — no parallel DTO family) + a zero-dep transparent-SoA-view borrow trait (E-SOA-VIEW-IS-A-BORROW). Honors R1 (view returns `&[T]`, never copies) + R4 (witness = `chain_position` pointer). Deferred: planner-emit (D-MBX-A6 Ph2-3, incl. the {native|JIT|SurrealQL|elixir} strategy set), `impl MailboxSoaView/Owner for MailboxSoA<N>` (cognitive-shader-driver), ractor `ConsumerEnvelope::Kanban` arm, surreal_container read-view (BLOCKED on OQ-11.6 fork).
690690

691691
**Review pattern:** `// ///`-decision-markers → `/code-review` (medium, 1 finding → REFUTED via grep + cargo check) → markers stripped → cargo verify. Design via Opus Plan agent map (LATEST_STATE + lab-vs-canonical + unified-soa-convergence-v1 + orchestration/container/surreal_container/supervisor surfaces).
692+
## [Opus 4.7 / 1M ctx, main thread] PR #434 post-merge review + governance flip + addendum (lance-graph)
693+
694+
**Branch:** `claude/lance-graph-ontology-review-Pyry3` (rebased onto `main` `1186dfd3`, 0 ahead → fast-forwarded 27 commits). | **Files (this commit):**
695+
- `.claude/plans/unified-soa-convergence-v1-addendum-2026-05-29-review.md` (new, 156 lines) — post-merge review addendum.
696+
- `.claude/plans/unified-soa-convergence-v1.md` — §9 P0 + §15 PRs: flip "in PR (this one)" → "SHIPPED in PR #434" (2 edits).
697+
- `.claude/board/INTEGRATION_PLANS.md` — flip 2026-05-29 unified-soa entry `**Status:** PROPOSAL``**Status:** SHIPPED (PR #434 merged 2026-05-29, `1186dfd3`)` + add review-addendum cross-ref.
698+
- `.claude/board/STATUS_BOARD.md` — add `> **Plan P0 status:** SHIPPED in PR #434 (merged 2026-05-29).` under the unified-soa section header + review-addendum cross-ref.
699+
- `.claude/board/PR_ARC_INVENTORY.md` — PREPEND new `## #434` section with Added / Locked / Deferred / Docs / Confidence (`2026-05-29`).
700+
- `.claude/board/LATEST_STATE.md` — refresh the "Last updated" header line to lead with PR #434 (was 2026-05-14 / PR #372 — two weeks stale).
701+
- `.claude/board/TECH_DEBT.md` — PREPEND `TD-CLAUDE-MD-DEPS-DRIFT` (P3) flagging `CLAUDE.md` "Key Dependencies" stale pins (arrow `"57"` / datafusion `"51"` / lance `"2"` vs reality arrow 58 / datafusion 53 / lance `=6.0.0`).
702+
703+
**Tests:** none (docs/board only; `cargo` prohibited per session-stability constraint, same as PR #434).
704+
705+
**Review findings recorded in the addendum** (does not edit ruling text; the §1 / §11 rulings are council-bypassed author-stated content per §16):
706+
1. **§3.2 per-row total math** — the `~30 B` figure counts only the **shipped-today** subset (D-MBX-A1); after A2/A3 land at `W=16` (OQ-11.2 default) the per-row bare total grows to ≈101 B. The ~6 KB/thought hot ceiling is dominated by the 3 × `[u64; 256]` identity planes either way, so the §3.2 ceiling math (64k–256k thoughts at 300–600 MB / 1.2–2.4 GB) stands. Clarification recommended for a future v2.
707+
2. **§4.2 stack table gap** — the table covers arrow/datafusion/lance/lancedb/ndarray but omits **surrealdb** even though §4.3 + D-MBX-9 + OQ-11.6 hinge on a SurrealDB fork pin (`kv-lance` backend feature). Addendum proposes one extra row marked BLOCKED — OQ-11.6.
708+
3. **§4.2 verification re-checked** — independently confirmed `arrow = "58"` (4 files), `datafusion = "53"` (3 files), `lance = "=6.0.0"` (5 files: lance-graph:38, lance-graph-benches:10, lance-graph-callcenter:30, lance-graph-ontology:46, holograph:38), `lancedb = "=0.29.0"` (1 file). D-MBX-11 is mechanical.
709+
4. **CLAUDE.md drift** — discovered while validating #4: `CLAUDE.md` "Key Dependencies" still says `arrow = "57"` / `datafusion = "51"` / `lance = "2"` (drift from 2026-04-21 inference-click update). NOT fixed in this PR (wrong altitude — workspace-wide doctrine deserves a focused PR); tracked as `TD-CLAUDE-MD-DEPS-DRIFT`.
710+
711+
**Verifications run this session (read-only):**
712+
- `git rebase origin/main` on `claude/lance-graph-ontology-review-Pyry3` → fast-forward, 27 commits absorbed, pushed (`98bec7b8..1186dfd3`).
713+
- `grep -nE '^(lance|lancedb|arrow|datafusion)' crates/*/Cargo.toml` confirmed §4.2 stack pins.
714+
- `mcp__github__pull_request_read get` confirmed #434 merged 2026-05-29T18:38:43Z, merge SHA `1186dfd3`, 1 004 insertions, 6 files, 3 commits.
715+
716+
**Outcome:** Plan P0 marked SHIPPED with PR ref; addendum captures the three clarification-grade findings; gov boards (`INTEGRATION_PLANS`, `STATUS_BOARD`, `PR_ARC_INVENTORY`, `LATEST_STATE`, `TECH_DEBT`) all caught up to the post-merge state. **§1 / §11 user-stated rulings untouched** (council-bypass discipline). **CLAUDE.md drift flagged not fixed** — tracked as separate TD entry for a focused follow-up PR.
692717

693718
---
694719

.claude/board/INTEGRATION_PLANS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@
102102

103103
## 2026-05-29 — unified-soa-convergence-v1 (THE single LE SoA end-to-end across the workspace: 9 half-baked consumers + SoA version gate + Lance 6.0.1/LanceDB 0.29/DataFusion 53 alignment + 4-phase Rubicon kanban + lance-graph-planner DTO overhaul + Libet −550 ms anchor + Staunen×Wisdom plasticity spreader + SPO-W pointer via AriGraph episodic Markov chain)
104104

105-
**Status:** PROPOSAL / integration plan. Design-spec only, no code. **Plan file:** `.claude/plans/unified-soa-convergence-v1.md`. **Handover:** `.claude/handovers/2026-05-29-1825-soa-convergence-author-to-impl.md`. **Epiphany:** `E-SOA-IS-THE-ONLY` (+ refinements §11.3/4/6 in PR-this-one).
105+
**Status:** SHIPPED (PR #434 merged 2026-05-29, `1186dfd3`). Design-spec only, no code. **Plan file:** `.claude/plans/unified-soa-convergence-v1.md`. **Handover:** `.claude/handovers/2026-05-29-1825-soa-convergence-author-to-impl.md`. **Review addendum:** `.claude/plans/unified-soa-convergence-v1-addendum-2026-05-29-review.md` (post-merge review by `claude/lance-graph-ontology-review-Pyry3`). **Epiphany:** `E-SOA-IS-THE-ONLY` (+ refinements §11.3/4/6).
106106
**Owns:** the meticulous integration sequence for the 5 layered user rulings ratified this session — one SoA never transformed; mailbox = full BindSpace as LE; Libet −550 ms ratchets the Rubicon kanban; SPO-W = pointer via AriGraph episodic Markov chain; counterfactual Staunen×Wisdom = plasticity spreaders. Adds D-MBX-A2/A3/A4/A5/A6, D-MBX-7/8/9/10/11/12 (12 sub-PRs); 8 open questions OQ-11.1–11.8; risk matrix; phased dependency graph (P0–P7).
107107
**Anchored iron rules:** I-VSA-IDENTITIES, I-LEGACY-API-FEATURE-GATED (governs the SoA version gate), I-SUBSTRATE-MARKOV (untouched), I-NOISE-FLOOR-JIRAK.
108108
**Predecessors:** `bindspace-singleton-to-mailbox-soa-v1` (§11 rulings); `causaledge64-mailbox-rename-soa-v1` (canonical 5-crate + 7-PR plan); `cognitive-substrate-convergence-v1/v2/v3` (Σ10 Rubicon shipped #388).

.claude/board/PR_ARC_INVENTORY.md

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,46 @@
8686

8787
**Confidence (2026-05-31):** working — 497 contract + 240 ontology lib tests green; clippy `-D warnings` + rustfmt clean; merged clean after Codex P2 + 2 CodeRabbit findings (all real, all resolved in the babysit loop before merge).
8888

89+
## #434 — docs(unified-soa): meticulous integration plan + handover for ONE-SoA-end-to-end convergence (merged 2026-05-29)
90+
91+
**Status:** MERGED. Branch `claude/splat3d-cpu-simd-renderer-MAOO0``main` at `1186dfd3`. 3 commits, +1004 lines, 6 files, **zero source code** (docs / board only). `cargo` prohibited per session-stability constraint; no build/test ran.
92+
93+
**Added** (immutable)
94+
- `.claude/plans/unified-soa-convergence-v1.md` (685 lines) — the meticulous integration plan: §1 five layered user rulings (`E-SOA-IS-THE-ONLY`), §2 the nine half-baked consumers' current-state → target-state, §3 column-by-column SoA layout + `MailboxSoAHeader` version gate + identity planes + shared-cold resources, §4 stack alignment (arrow 58 / datafusion 53 / lancedb =0.29.0 / lance =6.0.0 → =6.0.1 patch pending) + SurrealDB transparent-view enablement, §5–7 4-phase Rubicon kanban wiring + AriGraph episodic chain witness + Staunen × Wisdom plasticity spreader, §8 `lance-graph-planner` DTO surface overhaul (D-MBX-A6, 5-phase feature-gated cutover), §9 phased migration P0–P7, §10 per-deliverable specs for D-MBX-A2/A3/A4/A5/A6/7/8/9/10/11/12 (each with owner, LOC, risk, tests, gates), §11 eight open questions OQ-11.1…OQ-11.8 with default proposals + ratification gates, §12 risk matrix, §13 success criteria, §14 dependency graph, §15 cross-references, §16 council-bypass note.
95+
- `.claude/handovers/2026-05-29-1825-soa-convergence-author-to-impl.md` (119 lines) — handover per CLAUDE.md format: What-I-did chronology · FINDING · CONJECTURE · Blockers · 8 OQs for the user · recommended next-session entry sequence · code anchors · provenance (rulings verbatim).
96+
- Board hygiene committed in the same merge: `INTEGRATION_PLANS.md` prepend, `STATUS_BOARD.md` new plan section (D-MBX-A1 Shipped + A2/A3/A4/A5/A6/7/8/9/10/11/12 Queued), `EPIPHANIES.md` already carrying `E-SOA-IS-THE-ONLY` (commit `eb5c4a5`).
97+
98+
**Locked** (immutable)
99+
- **ONE SoA, never transformed** is the carrier doctrine (`E-SOA-IS-THE-ONLY` R1): only three operations allowed on it — cognitive-shader thinking, cold-path read/write to LanceDB, AriGraph Markov context. Any mailbox SoA mutation IS the only hot-path activity.
100+
- **Mailbox = full BindSpace reinvented as LE; witness = the per-row arc of `CausalEdge64` emissions** (R2): the arc implicitly documents NARS revision; no separate revision log column.
101+
- **Libet −550 ms** anchors the Σ10 Rubicon commit (R3); 4-phase kanban (Planning → Cognitive work → Evaluation → Commit · Plan · Prune) lives in `surrealkv`-on-lance (SurrealDB is a view, LanceDB stays leading storage).
102+
- **SPO-W witness is a pointer into the AriGraph episodic Markov chain** (R4); the chain IS the index space; no parallel episodic structure.
103+
- **Counterfactual Staunen × Wisdom = plasticity spreaders** (R5): Hebbian, Planning-gated, hot-path-only.
104+
- **SoA version byte at the layout root** (`MailboxSoAHeader`, D-MBX-10); governed by `I-LEGACY-API-FEATURE-GATED`; v(M) reader MUST refuse v(N>M) bytes without explicit handshake; field-isolation matrix tests mandatory on every column op (Sprint-11 5-instance catalogue).
105+
- **Stack pin target** verified 2026-05-29: arrow 58 ✓ / datafusion 53 ✓ / lancedb =0.29.0 ✓ / lance =6.0.0 → =6.0.1 (one mechanical patch bump pending across 5 Cargo.toml files; D-MBX-11).
106+
- **lance-graph-planner DTO surface overhaul** (D-MBX-A6): planner output = `KanbanMove`s; DTOs become SoA-row-lenses; 5-phase feature-gated cutover behind `planner-soa-v2`; v1 deleted at end (OQ-11.7 default).
107+
- **Council bypass for the §11 rulings** is explicit (§16): `epiphany-brainstorm-council` (shipped #433) is bypassed for author-stated user rulings; the plan's *spec content* remains open to council review via PR.
108+
109+
**Deferred** (immutable)
110+
- **Cargo prohibition** still in force (session-stability constraint): all `cargo check`/`test` invocations and the actual `=6.0.1` patch bump (D-MBX-11) defer until the prohibition lifts.
111+
- **OQ-11.1 … OQ-11.8** await user ratification (default proposals recorded in §11):
112+
- OQ-11.1 Staunen × Wisdom spread radius / decay / column-local vs baton-routed.
113+
- OQ-11.2 `witness_arc` width `W`.
114+
- OQ-11.3 distinct "vetoed/ghosted" kanban column vs Prune.
115+
- OQ-11.4 CLAUDE.md "The Click" / `Vsa16kF32` doctrinal update timing.
116+
- OQ-11.5 SoA version field width + per-column version stamps.
117+
- OQ-11.6 surrealdb fork URL + branch + `kv-lance` feature flag (BLOCKED(C) — needs fork-access human).
118+
- OQ-11.7 planner DTO overhaul scope (clean break vs feature-gated coexistence; default = feature-gated).
119+
- OQ-11.8 D-MBX-12 sub-PR sequencing.
120+
- **D-MBX-9** (Rubicon kanban view in `surrealkv`-on-lance) blocked on `surreal_container` BLOCKED(B/C/D); the rest of the plan ships without the SurrealDB view (it's a view, not the store).
121+
122+
**Docs** (immutable)
123+
- `.claude/plans/unified-soa-convergence-v1.md` (the plan itself)
124+
- `.claude/handovers/2026-05-29-1825-soa-convergence-author-to-impl.md` (the handover)
125+
- `.claude/plans/unified-soa-convergence-v1-addendum-2026-05-29-review.md` (post-merge review addendum, this PR)
126+
127+
**Confidence (2026-05-29):** HIGH on the integration spec (the five rulings are author-stated and verbatim-recorded; §10 per-deliverable specs are consistent with `mailbox_soa.rs` and the Cargo pins as of HEAD `1186dfd3`). MED on the per-deliverable LOC estimates (will refine as each D-MBX-* lands). LOW on D-MBX-9 timing (gated on the long-standing `surreal_container` BLOCKED(B/C/D)).
128+
89129
---
90130

91131
## callcenter/audit-fix — fix(callcenter): `with_jsonl_audit` returns `Result<Self, AuditError>` (branch work)

.claude/board/STATUS_BOARD.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,9 @@ hot/cold/feedback loop onto our contract types + SoA floor
617617

618618
## unified-soa-convergence-v1 — ONE LE SoA end-to-end across 9 consumers + version gate + Lance 6.0.1 stack + 4-phase Rubicon kanban
619619

620-
Plan path: `.claude/plans/unified-soa-convergence-v1.md`. Handover `.claude/handovers/2026-05-29-1825-soa-convergence-author-to-impl.md`. Epiphany `E-SOA-IS-THE-ONLY` (+ §11.3/4/6 refinements).
620+
> **Plan P0 status:** SHIPPED in PR #434 (merged 2026-05-29). Deliverable rows below remain Queued; they ship in follow-up PRs per phase sequencing.
621+
622+
Plan path: `.claude/plans/unified-soa-convergence-v1.md`. Handover `.claude/handovers/2026-05-29-1825-soa-convergence-author-to-impl.md`. Review addendum `.claude/plans/unified-soa-convergence-v1-addendum-2026-05-29-review.md`. Epiphany `E-SOA-IS-THE-ONLY` (+ §11.3/4/6 refinements).
621623

622624
| D-id | Title | Crate(s) | ~LOC | Risk | Status | PR / Evidence |
623625
|---|---|---|---|---|---|---|

0 commit comments

Comments
 (0)