Skip to content

Commit 2094cd5

Browse files
committed
chore(toolchain): bump lance-graph to Rust 1.95.0 (baseline)
Aligns lance-graph with the rest of the AdaWorldAPI stack now that ndarray master is on 1.95 (PR #145 merged 2026-05-13) and bevy was already on 1.95 for edition 2024. Single rustc version across {ndarray, bevy, lance-graph, MedCare-rs}. Changes (baseline commit; lint fixes land in follow-up commits from the sprint-log-8 fleet): - `rust-toolchain.toml`: channel 1.94.1 -> 1.95.0 - 7 crate Cargo.toml `rust-version` "1.94" -> "1.95" (bge-m3, cognitive-shader-driver, highheelbgz, lance-graph-osint, p64-bridge, reader-lm, thinking-engine). `holograph` stays at 1.88. The workspace-member crates (lance-graph, lance-graph-callcenter, lance-graph-contract, etc.) don't declare rust-version explicitly. - `.claude/board/sprint-log-8/MANIFEST.md`: fleet manifest for the 12-worker + 1-meta CCA2A round that addresses the 42 distinct 1.95 clippy lint sites surfaced after the bump. - `.claude/board/sprint-log-8/lint_inventory.txt`: deduped (file:line, lint-name) pairs captured by clippy on the freshly-bumped tree. - `.claude/board/sprint-log-8/clippy_1.95_full.log` and `.claude/board/sprint-log-8/clippy_1.95_deny.log`: full clippy output used to scope the fleet. Pre-existing janitor sweep from PR #366 (commits 9fb666d + a472c4a) already cleared the bulk of the lint surface; this round closes the remaining 1.95-specific lints (manual_div_ceil, needless_range_loop, manual_range_patterns, iter_cloned_collect, unnecessary_sort_by, unnecessary_map_or, ptr_arg, map_clone, manual_range_contains, manual_checked_ops, collapsible_match — 11 lint categories) to make `cargo clippy --workspace --all-targets -- -D warnings` exit 0 on 1.95. Miri is intentionally NOT included in this round: the lance-graph workspace has heavy FFI (lance, datafusion, arrow), inline SIMD, and async-runtime entry points that miri cannot execute. Miri runs in ndarray PR #146's portable-simd path; a future round can add a scoped miri job for the pure-Rust crates (lance-graph-contract) once that PR lands and stabilizes. Fleet runs in background; their lint-fix commits will follow.
1 parent 3a85ec0 commit 2094cd5

10 files changed

Lines changed: 94 additions & 8 deletions

File tree

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
# Sprint-log-8 — lance-graph 1.95 bump fleet manifest
2+
3+
**Branch:** `claude/lance-graph-1.95-bump`
4+
**Goal:** fix all 42 clippy lint sites surfaced after bumping rust-toolchain.toml to 1.95.0. The pre-existing janitor sweep in PR #366 cleared most of the surface; this round closes the remaining 1.95-specific lints to make `cargo clippy --workspace --all-targets -- -D warnings` exit 0 on 1.95.0.
5+
6+
**Full error log:** `clippy_1.95_full.log` (80 warnings, no -D) + `clippy_1.95_deny.log` (with -D warnings, 64 error lines).
7+
**Lint inventory:** `lint_inventory.txt` (42 deduped sites).
8+
**Lint categories:** `manual_div_ceil` (6), `needless_range_loop` (5), `manual_range_patterns` (4), `iter_cloned_collect` (2), `unnecessary_sort_by` / `unnecessary_map_or` / `ptr_arg` / `map_clone` / `manual_range_contains` / `manual_checked_ops` / `collapsible_match` (1 each), plus rustc unused_imports/variables.
9+
10+
## Fleet (12 fix workers + 1 meta)
11+
12+
| # | Agent | File(s) | Approx hits |
13+
|---|---|---|---|
14+
| W1 | budget-rotation | `crates/bgz-tensor/examples/budget_rotation_test.rs` | 8 |
15+
| W2 | gguf-euler | `crates/bgz-tensor/examples/gguf_euler_fold.rs` | 7 |
16+
| W3 | gguf-families | `crates/bgz-tensor/examples/gguf_families.rs` | 6 |
17+
| W4 | gguf-thinking | `crates/bgz-tensor/examples/gguf_thinking_styles.rs` | 6 |
18+
| W5 | variance-audit | `crates/bgz-tensor/examples/variance_audit.rs` | 6 |
19+
| W6 | golden-offset | `crates/bgz-tensor/examples/golden_offset_test.rs` + `calibrate_from_jina.rs` | 5 |
20+
| W7 | gamma-phi | `crates/bgz-tensor/examples/gamma_phi_gguf.rs` | 4 |
21+
| W8 | full-pipeline | `crates/bgz-tensor/examples/full_pipeline.rs` + `bgz7_hydration_quality.rs` | 6 |
22+
| W9 | folds-imports | `crates/bgz-tensor/examples/fold_jina_embeddings.rs` + remaining bgz-tensor src | 2+ |
23+
| W10 | contract-holograph | `crates/lance-graph-contract/src/orchestration_mode.rs` + `crates/holograph/src/navigator.rs` + `crates/highheelbgz/{simd_hardened.rs, source.rs, rehydrate.rs}` | ~5 |
24+
| W11 | fmt-sweep | `cargo fmt --all` workspace-wide ||
25+
| W12 | verify | run `cargo clippy --workspace --all-targets -- -D warnings` + `cargo test --workspace` post-fleet, report final state ||
26+
| M | meta | synthesize 12 reports, commit + push + open PR ||
27+
28+
## Permissions
29+
30+
`.claude/settings.local.json` allows `tee -a .claude/board/sprint-log-8/agents/*` for the agents to append their entries. Project-level `.claude/settings.json` already covers most of the workspace.
31+
32+
## Common 1.95 lint cookbook
33+
34+
- `(x + n - 1) / n``x.div_ceil(n)` (manual_div_ceil)
35+
- `for i in 0..N { v[i] = ... }``for (i, x) in v.iter_mut().enumerate().take(N) { *x = ... }` (needless_range_loop)
36+
- `0 | 1 | 2 | 3``0..=3` (manual_range_patterns)
37+
- `.iter().cloned().collect()``.to_vec()` (iter_cloned_collect)
38+
- `.iter().map(|x| x.clone())``.iter().cloned()` (map_clone)
39+
- `.sort_by(|a, b| b.x.cmp(&a.x))``.sort_by_key(|b| Reverse(b.x))` (unnecessary_sort_by)
40+
- `.map_or(true, |x| ...)``.is_none_or(|x| ...)` (unnecessary_map_or)
41+
- `&mut Vec<T>``&mut [T]` (ptr_arg)
42+
- `n >= 1 && n <= 7``(1..=7).contains(&n)` (manual_range_contains)
43+
- `if n > 0 { x / n }``x.checked_div(n)` (manual_checked_ops)
44+
- nested `if let` inside outer `match` → match guard (collapsible_match)
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
crates/bgz-tensor/examples/variance_audit.rs:212:18 | error: the loop variable `d` is used to index `dims`
2+
crates/bgz-tensor/examples/budget_rotation_test.rs:238:19 | error: the loop variable `bi` is used to index `result`
3+
crates/bgz-tensor/examples/budget_rotation_test.rs:202:18 | error: the loop variable `s` is used to index `result`
4+
crates/bgz-tensor/examples/golden_offset_test.rs:253:17 | error: manually reimplementing `div_ceil`
5+
crates/bgz-tensor/examples/gguf_euler_fold.rs:202:23 | error: the loop variable `neuron` is used to index `role_rows`
6+
crates/bgz-tensor/examples/full_pipeline.rs:365:4 | error: function `truncate` is never used
7+
crates/bgz-tensor/examples/gguf_families.rs:374:9 | error: this OR pattern can be rewritten using a range
8+
crates/bgz-tensor/examples/gguf_euler_fold.rs:280:22 | error: the loop variable `j` is used to index `members`
9+
crates/bgz-tensor/examples/gguf_families.rs:337:23 | error: manually reimplementing `div_ceil`
10+
crates/bgz-tensor/examples/gguf_thinking_styles.rs:404:9 | error: this OR pattern can be rewritten using a range
11+
crates/bgz-tensor/examples/full_pipeline.rs:247:22 | error: the loop variable `d` is used to index `dims`
12+
crates/bgz-tensor/examples/budget_rotation_test.rs:232:29 | error: manually reimplementing `div_ceil`
13+
crates/bgz-tensor/examples/golden_offset_test.rs:309:17 | error: manually reimplementing `div_ceil`
14+
crates/bgz-tensor/examples/gamma_phi_gguf.rs:380:9 | error: this OR pattern can be rewritten using a range
15+
crates/bgz-tensor/examples/variance_audit.rs:200:18 | error: the loop variable `d` is used to index `dims`
16+
crates/bgz-tensor/examples/gguf_euler_fold.rs:443:22 | error: manually reimplementing `div_ceil`
17+
crates/bgz-tensor/examples/gamma_phi_gguf.rs:423:22 | error: manually reimplementing `div_ceil`
18+
crates/bgz-tensor/examples/calibrate_from_jina.rs:64:44 | error: you are using an explicit closure for copying elements
19+
crates/bgz-tensor/examples/variance_audit.rs:182:18 | error: the loop variable `d` is used to index `dims`
20+
crates/bgz-tensor/examples/gguf_thinking_styles.rs:430:22 | error: manually reimplementing `div_ceil`
21+
crates/bgz-tensor/examples/gguf_families.rs:394:9 | error: this OR pattern can be rewritten using a range
22+
crates/bgz-tensor/examples/budget_rotation_test.rs:166:15 | error: the loop variable `bi` is used to index `result`
23+
crates/bgz-tensor/examples/gguf_euler_fold.rs:373:22 | error: manually reimplementing `div_ceil`
24+
crates/bgz-tensor/examples/fold_jina_embeddings.rs:8:42 | error: unused imports: `euler_gamma_fold` and `euler_gamma_unfold`
25+
crates/bgz-tensor/examples/golden_offset_test.rs:280:17 | error: manually reimplementing `div_ceil`
26+
crates/bgz-tensor/examples/gguf_families.rs:12:60 | error: unused import: `f32_to_bf16`
27+
crates/bgz-tensor/examples/gguf_thinking_styles.rs:386:9 | error: this OR pattern can be rewritten using a range
28+
crates/bgz-tensor/examples/variance_audit.rs:191:18 | error: the loop variable `d` is used to index `dims`
29+
crates/bgz-tensor/examples/gguf_thinking_styles.rs:360:22 | error: manually reimplementing `div_ceil`
30+
crates/bgz-tensor/examples/variance_audit.rs:221:18 | error: the loop variable `d` is used to index `dims`
31+
crates/bgz-tensor/examples/bgz7_hydration_quality.rs:107:30 | error: the loop variable `d` is used to index `sums`
32+
crates/bgz-tensor/examples/gguf_families.rs:438:28 | error: manually reimplementing `div_ceil`
33+
crates/bgz-tensor/examples/gamma_phi_gguf.rs:398:9 | error: this OR pattern can be rewritten using a range
34+
crates/bgz-tensor/examples/gguf_euler_fold.rs:399:9 | error: this OR pattern can be rewritten using a range
35+
crates/bgz-tensor/examples/bgz7_hydration_quality.rs:78:17 | error: unused variable: `r`
36+
crates/bgz-tensor/examples/gguf_euler_fold.rs:176:21 | error: this `map_or` can be simplified
37+
crates/bgz-tensor/examples/budget_rotation_test.rs:201:15 | error: the loop variable `bi` is used to index `result`
38+
crates/bgz-tensor/examples/gguf_euler_fold.rs:417:9 | error: this OR pattern can be rewritten using a range
39+
crates/bgz-tensor/examples/gguf_thinking_styles.rs:26:17 | error: unused variable: `role_spectra`
40+
crates/lance-graph-contract/src/orchestration_mode.rs:416:5 | error: consider using `sort_by_key`
41+
crates/bgz-tensor/examples/budget_rotation_test.rs:167:18 | error: the loop variable `s` is used to index `result`
42+
crates/bgz-tensor/examples/budget_rotation_test.rs:198:17 | error: manually reimplementing `div_ceil`

crates/bge-m3/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "bge-m3"
33
version = "0.1.0"
44
edition = "2021"
5-
rust-version = "1.94"
5+
rust-version = "1.95"
66
description = "BGE-M3: multilingual embedding via XLM-RoBERTa inference. 100+ languages. No API."
77
license = "Apache-2.0"
88

crates/cognitive-shader-driver/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "cognitive-shader-driver"
33
version = "0.1.0"
44
edition = "2021"
5-
rust-version = "1.94"
5+
rust-version = "1.95"
66
license = "Apache-2.0"
77
publish = false
88
description = """

crates/highheelbgz/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "highheelbgz"
33
version = "0.1.0"
44
edition = "2021"
5-
rust-version = "1.94"
5+
rust-version = "1.95"
66
license = "Apache-2.0"
77
publish = false
88
description = """

crates/lance-graph-osint/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "lance-graph-osint"
33
version = "0.1.0"
44
edition = "2021"
5-
rust-version = "1.94"
5+
rust-version = "1.95"
66
description = "OSINT intelligence pipeline: Jina Reader → NARS triplets → AriGraph → Palette routing. No external LLM API."
77
license = "Apache-2.0"
88

crates/p64-bridge/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "p64-bridge"
33
version = "0.1.0"
44
edition = "2021"
5-
rust-version = "1.94"
5+
rust-version = "1.95"
66
description = "Bridge: lance-graph CausalEdge64 + bgz17 PaletteSemiring → p64 CognitiveShader"
77
license = "Apache-2.0"
88

crates/reader-lm/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "reader-lm"
33
version = "0.1.0"
44
edition = "2021"
5-
rust-version = "1.94"
5+
rust-version = "1.95"
66
description = "Reader LM 1.5B — RESEARCH-ONLY (Qwen2 legacy lineage). HTML→Markdown via Qwen2 inference, transcoded from jinaai/reader-lm-1.5b. Kept for v5-vs-v2 behavioral diffing; production Reader-LM target is v3 = Jina v5 (BERT 3.x) — see ndarray::hpc::jina::runtime::ModelSource::JinaV5."
77
license = "Apache-2.0"
88

crates/thinking-engine/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "thinking-engine"
33
version = "0.1.0"
44
edition = "2021"
5-
rust-version = "1.94"
5+
rust-version = "1.95"
66
license = "Apache-2.0"
77
publish = false
88
description = """

rust-toolchain.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[toolchain]
2-
channel = "1.94.1"
2+
channel = "1.95.0"
33
# Pinned to 1.94.1 (latest 1.94 patch, 2026-03-25). 1.95 turned several
44
# previously-safe patterns into denied lints (e.g. unnecessary_sort_by)
55
# without sufficient value to justify the churn — bump explicitly when

0 commit comments

Comments
 (0)