Commit 38e5031
committed
family-basin Weyl probe: harden gate + add unit tests + fix DK wording (coderabbit #551)
Three CodeRabbit comments, all valid:
1. Gate false-positive (Major): weyl_ok defaulted to true when no within-basin
line existed (is_none_or), and ratio became ∞ when no seam samples existed —
either could label a tier HOP-LOCAL without a valid check. Fixed: weyl_ok
unwraps to false on no within-line; ratio = 0 (not ∞) on no seam; extracted a
single-source tier_supported() that requires has_within && has_straddle.
2. Missing tests (Major): added #[cfg(test)] for containment (incl. zero-field
and empty-members edges), dipole balance, and the gate (incl. the missing-
evidence cases that would previously false-positive). 3/3 pass.
3. EPIPHANIES DK wording (Minor): line 1 framed Davis-Kahan as the evidence
while the body drops the DK bound as evidence. Reworded line 1 to anchor on
the containment ratio (the retained gate) and mark DK explicitly as the
mechanism, not the numeric evidence.
Probe verdict unchanged (HEEL HOP-LOCAL, HIP/LEAF leak); clippy --tests + fmt clean.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CcpLeEC3XK8Eye53GKBVvi1 parent 41e75cf commit 38e5031
2 files changed
Lines changed: 71 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
Lines changed: 70 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
64 | 81 | | |
65 | 82 | | |
66 | 83 | | |
| |||
149 | 166 | | |
150 | 167 | | |
151 | 168 | | |
152 | | - | |
| 169 | + | |
| 170 | + | |
153 | 171 | | |
154 | 172 | | |
155 | 173 | | |
156 | 174 | | |
157 | | - | |
| 175 | + | |
| 176 | + | |
158 | 177 | | |
| 178 | + | |
159 | 179 | | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
165 | 188 | | |
166 | 189 | | |
167 | 190 | | |
| |||
195 | 218 | | |
196 | 219 | | |
197 | 220 | | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
0 commit comments