Commit 3ba36b4
committed
fix: address CodeRabbit findings on PR #426 (16/17; 1 explicitly skipped)
Group A — board + plan governance
- INTEGRATION_PLANS.md: reconcile Stage-2 terminology with plan's TIER-2 scope
- BP-1 plan: D-ODOO-BP-1f row — tree-sitter → Python stdlib ast (matches reality)
- EXT-1 plan: Status line gets commit-range evidence (15b63ce..b54a743)
Group B — Rust source fixes
- grammar/role_keys.rs: debug_assert! → assert! (release-build safety)
- extracted/*.rs: emitter now strips /home/user/ prefix → repo-relative paths;
all 12 TIER-1 addons + l10n_de chart/kennzahlen regenerated
- l8.rs: UOM_UUM typo → UOM_UOM (+ pairing.rs reference update)
- extracted/coverage.rs: lane_of unwrap_or(0) → expect (fail loud on malformed l_doc)
Group C — Python tooling
- __init__.py: __version__: str type annotation
- cli.py: mkdir(parents=True, exist_ok=True) before audit write in pair + ORM paths
- data_extractors/csv_chart.py: explicit SKR03/SKR04 validation (no silent default)
- data_extractors/gobd_company.py: verify_gobd_wiring inspects method body for
country_code == 'DE' trigger (no longer false-positive on naked method existence)
- data_extractors/xml_kennzahl.py: defusedxml drop-in for ET (XXE/billion-laughs
hardening on Odoo-vendored XML). New runtime dep in pyproject.toml.
- tests/test_smoke_uom.py: update fallback_rate call sites (drop total_methods arg)
Group D — nitpicks
- 2 plan files: add 'text' language tag on directory-tree fenced blocks (MD040)
- audit/fallback_log.py: drop unused total_methods from fallback_rate signature
SKIPPED with rationale (1/17):
- l1.rs unit tests for ENTITIES contents: tests would echo static const data,
not defend invariants. The cross-cutting properties (kind/confidence/l_doc)
are already enforced by extracted::coverage::tests' aggregate gate.
Tests: cargo test -p lance-graph-ontology --lib green (203 tests).
Python smoke test: ALL TESTS PASS.
https://claude.ai/code/session_017gZ6sPRXYPj5n7uJ7NBtRv1 parent 1525ef6 commit 3ba36b4
28 files changed
Lines changed: 381 additions & 356 deletions
File tree
- .claude
- board
- plans
- crates
- lance-graph-contract/src/grammar
- lance-graph-ontology/src/odoo_blueprint
- extracted
- tools/odoo-blueprint-extractor
- odoo_blueprint_extractor
- audit
- data_extractors
- emitters
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
129 | | - | |
| 129 | + | |
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
102 | | - | |
| 101 | + | |
| 102 | + | |
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| |||
0 commit comments