Merge pull request #594 from AdaWorldAPI/claude/dolce-odoo-hydrator-silent-suffix-bugs

fix(hydrator/dolce_odoo): close two silent suffix-rule drifts; comments now match real Odoo class names

Author: AdaWorldAPI

.claude/board/EPIPHANIES.md

@@ -1,3 +1,52 @@
+## 2026-06-23 — E-DOLCE-ODOO-SILENT-SUFFIX-DRIFT — two hydrator-side suffix rules silently failed their own comments; cross-validation against `od_ontology::alignment` caught it (odoo-rs PR #15)
+
+**Status:** FINDING (cross-validation result from a sibling repo). Two
+`lance_graph_ontology::hydrators::dolce_odoo` suffix rules carried module-doc
+comments claiming to match canonical Odoo classes, but the rules as written
+DID NOT actually match those classes:
+
+| Suffix rule | Comment claimed to match | What it actually matched | Canonical Odoo class |
+|---|---|---|---|
+| `.group` | `res.groups`, `account.tax.group` | only `account.tax.group` | `res.groups` (PLURAL) was silently missed |
+| `.config` | `*.config.settings` | only `*.config` direct models | `res.config.settings`, `sale.config.settings` were silently missed |
+
+The hydrator's own tests didn't catch either bug — they tested
+`account.move`/`res.partner` (covered by other rules) and never asserted the
+class names the comments claimed.
+
+**How it was caught.** `odoo-rs` PR #14 pulled the alignment table into
+`od_ontology::alignment` and added cross-validation pins; PR #15 enriched the
+classifier by pulling from this hydrator and added test cases for
+`res.groups` and `res.config.settings`, both of which then failed against the
+original rules. The fix added `.groups` (plural) to `QUALITY_SUFFIXES` and
+`.settings` to `ABSTRACT_SUFFIXES` while keeping the singular `.group` /
+`.config` for the cases they always caught. Module-doc comments now record
+the convention explicitly.
+
+**Two-classifier disagreement context.** lance-graph hosts **two** DOLCE
+classifiers for Odoo: this one (`ontology::hydrators::dolce_odoo`) and
+`callcenter::odoo_alignment::dolce_odoo`. They disagree on `.tax` (Quality vs
+Abstract), `.template` resolution (special-cased vs swept), `hr.*` default,
+and the unmatched-default behavior (Endurant vs Unknown). odoo-rs PR #15
+documented the full reconciliation table in `crates/od-ontology/src/alignment.rs`
+§ "Two-classifier disagreement". This finding scopes only to the silent
+suffix-rule drift; the broader two-classifier reconciliation is a Phase-3
+OGAR-side decision (cross-ref `od_ontology::specs/REPATRIATION-FRAME.md`
+Phase 3).
+
+**Action shipped:**
+- `crates/lance-graph-ontology/src/hydrators/dolce_odoo.rs`: added `.groups`
+  to `QUALITY_SUFFIXES`, `.settings` to `ABSTRACT_SUFFIXES`, module-doc
+  notes record the rationale.
+- Four new regression tests pin: `res.groups` → Quality, `*.config.settings`
+  → AbstractEntity, plus the additive guards that the original singular
+  rules still match.
+
+**Source-of-finding:**
+[odoo-rs PR #15](https://github.com/AdaWorldAPI/odoo-rs/pull/15) +
+[odoo-rs PR #16](https://github.com/AdaWorldAPI/odoo-rs/pull/16)
+(repatriation-frame citations).
+
 ## 2026-06-21 — E-EQUIVALENCE-IS-THE-CRUX — template-equivalence is the load-bearing verifier of the whole loop; it MUST fail closed, and it rides on transparent Lance versioning (surrealdb #50)
 
 **Status:** FINDING (cross-session feedback, 2026-06-21). Reframing that

crates/lance-graph-ontology/src/hydrators/dolce_odoo.rs

@@ -64,18 +64,36 @@ const PERDURANT_SUFFIXES: &[&str] = &[
 ];
 
 /// Name suffixes indicating a Quality (attribute / classification / rate).
+///
+/// NOTE on `.groups` (plural): the canonical Odoo class is `res.groups`,
+/// which ends in `.groups` (plural), NOT `.group`. The bare `.group` rule
+/// alone misses `res.groups` despite the comment claiming to match it.
+/// Both forms are listed so plural-form Odoo classes are caught. Surfaced
+/// 2026-06-23 by cross-validation against `od_ontology::alignment` (see
+/// `.claude/board/EPIPHANIES.md § E-DOLCE-ODOO-SILENT-SUFFIX-DRIFT`).
 const QUALITY_SUFFIXES: &[&str] = &[
     ".tag",      // crm.tag, account.account.tag
     ".category", // product.category, res.partner.category
     ".type",     // account.account.type, sale.order.type
-    ".group",    // res.groups, account.tax.group
+    ".groups",   // res.groups (the canonical Odoo class — PLURAL)
+    ".group",    // account.tax.group, *.group (singular variants)
     ".tax",      // account.tax (it's a rate, a quality, not an event)
 ];
 
 /// Name suffixes indicating an AbstractEntity (reference / config / template).
+///
+/// NOTE on `.settings`: the canonical Odoo settings shape is
+/// `*.config.settings` (e.g. `res.config.settings`, `sale.config.settings`),
+/// which ends in `.settings`, NOT `.config`. The bare `.config` rule alone
+/// misses `*.config.settings` despite the comment claiming to match it.
+/// Both forms are listed so settings models are caught regardless of the
+/// trailing segment. Surfaced 2026-06-23 by cross-validation against
+/// `od_ontology::alignment` (see
+/// `.claude/board/EPIPHANIES.md § E-DOLCE-ODOO-SILENT-SUFFIX-DRIFT`).
 const ABSTRACT_SUFFIXES: &[&str] = &[
     ".template", // mail.template, account.chart.template
-    ".config",   // *.config.settings
+    ".settings", // *.config.settings (res.config.settings, sale.config.settings)
+    ".config",   // *.config (catches direct *.config models)
     ".policy",   // any *.policy
     ".rule",     // account.reconcile.model rules
     ".formula",  // hr.payroll.structure.line formulas
@@ -160,4 +178,55 @@ mod tests {
             DolceCategory::Endurant
         );
     }
+
+    // ─── Regression: silent suffix-rule drift caught by cross-validation ───
+    //
+    // The two assertions below would fail BEFORE the 2026-06-23 fix in this
+    // module that added `.groups` (plural) to QUALITY_SUFFIXES and `.settings`
+    // to ABSTRACT_SUFFIXES. The previous module-doc comments claimed to match
+    // `res.groups` (via `.group`) and `*.config.settings` (via `.config`) but
+    // the rules didn't actually catch those class names. See
+    // `.claude/board/EPIPHANIES.md § E-DOLCE-ODOO-SILENT-SUFFIX-DRIFT`.
+
+    #[test]
+    fn classifies_res_groups_as_quality_via_plural_suffix() {
+        // `res.groups` (plural) is the canonical Odoo class — `res.users`'s
+        // role/permission cohort. Must classify as Quality (a classification
+        // dimension), not get swept into the default (Endurant) bucket.
+        assert_eq!(classify_odoo("res.groups"), DolceCategory::Quality);
+        assert_eq!(classify_odoo("odoo:res.groups"), DolceCategory::Quality);
+    }
+
+    #[test]
+    fn classifies_config_settings_models_as_abstract_via_settings_suffix() {
+        // `*.config.settings` is the canonical Odoo settings shape — a
+        // configuration form, an AbstractEntity (rule/policy/template). The
+        // `.settings` suffix catches it; `.config` alone never matched it.
+        assert_eq!(
+            classify_odoo("res.config.settings"),
+            DolceCategory::AbstractEntity
+        );
+        assert_eq!(
+            classify_odoo("sale.config.settings"),
+            DolceCategory::AbstractEntity
+        );
+        assert_eq!(
+            classify_odoo("odoo:res.config.settings"),
+            DolceCategory::AbstractEntity
+        );
+    }
+
+    #[test]
+    fn singular_dot_group_still_matches_for_tax_group_style_classes() {
+        // Adding `.groups` must NOT accidentally drop the original `.group`
+        // singular match for `*.group` / `account.tax.group` / etc.
+        assert_eq!(classify_odoo("account.tax.group"), DolceCategory::Quality);
+    }
+
+    #[test]
+    fn singular_dot_config_still_matches_for_direct_config_classes() {
+        // Adding `.settings` must NOT drop the original `.config` match for
+        // direct `*.config` models.
+        assert_eq!(classify_odoo("crm.config"), DolceCategory::AbstractEntity);
+    }
 }