Skip to content

Commit 49e7501

Browse files
committed
symbiont plan: address CodeRabbit + Codex review on INTEGRATION_PLAN
- C1 (Codex P2): symbiont's direct deps are the integration payload (main.rs only prints); cargo machete must WHITELIST them via [package.metadata.cargo-machete] ignored, never delete — else the build passes while exercising nothing. - C2 (CodeRabbit): symbiont has its own [workspace], so root-level clippy skips it; specify --manifest-path crates/symbiont/Cargo.toml (or run from the dir). - BLOCKED(C) (CodeRabbit): add a `⊘ blocked` symbol to the status legend and use it for the surreal_container entry instead of an undefined marker. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CcpLeEC3XK8Eye53GKBVvi
1 parent ead022c commit 49e7501

1 file changed

Lines changed: 18 additions & 6 deletions

File tree

crates/symbiont/INTEGRATION_PLAN.md

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Integration plan — loose ends → the Spain-grid acceptance gate
22

3-
Status legend: ☐ open · ◐ in progress · ☑ done (this session)
3+
Status legend: ☐ open · ◐ in progress · ☑ done (this session) · ⊘ blocked (waiting on an upstream/dep change)
44

55
---
66

@@ -146,16 +146,28 @@ This folds into §B (the NaN-free win condition).
146146

147147
### C. Tight graph
148148

149-
-**C1 — `cargo machete` clean.** Remove unused deps from the golden-image
150-
graph and from `perturbation-sim`. (Machete reads manifests; cheap.)
151-
-**C2 — `cargo clippy --all-targets -- -D warnings` clean** across the
152-
symbiont graph (at least the first-party crates; upstream warnings triaged).
149+
-**C1 — `cargo machete` clean.** Run with
150+
`--manifest-path crates/symbiont/Cargo.toml` (and on `perturbation-sim`).
151+
**CAUTION — do NOT delete symbiont's direct deps.** `main.rs` only prints a
152+
probe line, so symbiont's manifest entries (lance-graph, perturbation-sim,
153+
ractor, surrealdb-core, ogar-*) ARE the integration payload — they are what
154+
force the golden-image build to pull in the full Ada stack. machete will flag
155+
them as unused; that is expected and intentional. Whitelist them via
156+
`[package.metadata.cargo-machete] ignored = [...]` (or add real references in
157+
`main.rs`) — never remove them, or the build passes while exercising nothing.
158+
machete should only remove genuinely-unused deps elsewhere (e.g. in
159+
`perturbation-sim`).
160+
-**C2 — `cargo clippy --all-targets -- -D warnings` clean.** NOTE:
161+
`symbiont` has its OWN `[workspace]`, so a root-level `cargo clippy` SKIPS it
162+
entirely — run from `crates/symbiont/` or add
163+
`--manifest-path crates/symbiont/Cargo.toml`. First-party crates must be
164+
clean; upstream (git-dep) warnings triaged, not gated.
153165

154166
---
155167

156168
## Other loose ends (post-gate)
157169

158-
- **surreal_container `BLOCKED(C)`.** The `surreal_container` consumer still
170+
- **surreal_container — blocked.** The `surreal_container` consumer still
159171
has the kv-lance fork dep unwired in its `Cargo.toml`. The golden image
160172
proves the dep graph works; porting that wiring into `surreal_container`
161173
clears the block.

0 commit comments

Comments
 (0)