Commit 4aaacb0
committed
fix(bridges): guard deprecated-alias re-exports + ontology self-impls (#589 follow-up)
PR #589 added `#[deprecated]` to the consumer-facing bridge symbols but
left two internal use-sites unguarded, so `cargo clippy -- -D warnings`
errored. Two same-class fixes:
1. `lance-graph-ogar/src/bridges/mod.rs` — split the re-export: the six
`*Port` types + `UnifiedBridge` stay in the clean group; the six
deprecated aliases (`MedcareBridge` / `OpenProjectBridge` /
`RedmineBridge` / `OdooBridge` / `SmbBridge` / `WoaBridge`) move under
`#[allow(deprecated)]`. (The owner flagged this as the P0; the mod.rs
guard never landed because it was dropped in the #589 rebase.)
2. `lance-graph-ontology/src/bridges/{ogit,spear,sharepoint,woa}_bridge.rs`
— each module IS its deprecated struct's implementation, so its own
impl blocks (+ woa's `_compile_check`) reference the deprecated struct
intentionally. Added module-level `#![allow(deprecated)]` to each.
Consumers in other crates still get the warning.
Verified: `cargo check -p lance-graph-ontology` and
`cargo check -p lance-graph-ogar` both Finished with 0 deprecation
warnings at the re-export / self-impl sites. The `#[deprecated]` notes
still fire at genuine external consumer use-sites (the intended beacon).
Out of scope (pre-existing TD-ONTOLOGY-LINT, per #589 review): the
`doc_nested_refdefs` / `oxrdf::Subject` / `odoo_blueprint
doc_lazy_continuation` clippy lints — separate cleanup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EYvNjD8M8LMNYbRy3gq2FP1 parent fdbe09d commit 4aaacb0
5 files changed
Lines changed: 45 additions & 6 deletions
File tree
- crates
- lance-graph-ogar/src/bridges
- lance-graph-ontology/src/bridges
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
71 | 73 | | |
72 | | - | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
73 | 92 | | |
74 | 93 | | |
75 | 94 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
11 | 16 | | |
12 | 17 | | |
13 | 18 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
25 | 30 | | |
26 | 31 | | |
27 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
18 | 23 | | |
19 | 24 | | |
20 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
5 | 10 | | |
6 | 11 | | |
7 | 12 | | |
| |||
0 commit comments