Skip to content

Commit 662cc4d

Browse files
committed
test(cascade_cols): update Healthcare ctx_id assertion to 2 (post-#364)
link_and_entity_type_id_resolution was written before PR #364's Codex P1 fix (`3208743`), when registry-created rows always carried ontology_context_id = 0. That fix made RegistryState::append stamp the seeded id from NamespaceRegistry::seed_defaults() — Healthcare = 2 — so the MulThresholdProfile MEDICAL/CALLCENTER lookup at driver.rs:303-321 actually fires for Healthcare/WorkOrder/Medical rows instead of always selecting DEFAULT. The test assertion `== 0` is stale; the desired behavior is `== 2`. Closes the pre-existing test failure flagged in the conflict-resolution commit message. Listed in PR #369's deferred backlog as the Tier B "per-row BindSpace.context_ids for driver.rs:311" follow-up — this is the test-side; the BindSpace SoA layout change remains sprint-10.
1 parent a68e213 commit 662cc4d

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

crates/lance-graph-ontology/tests/cascade_cols_test.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,5 +86,11 @@ fn link_and_entity_type_id_resolution() {
8686
.enumerate_first_with_entity_type_id(h.schema_ptr.entity_type_id())
8787
.unwrap();
8888
assert_eq!(resolved.public_name, "Patient");
89-
assert_eq!(resolved.ontology_context_id(), 0);
89+
// Healthcare is seeded to ontology_context_id = 2 in
90+
// NamespaceRegistry::seed_defaults() — the Codex P1 fix in PR #364
91+
// makes RegistryState::append stamp the seeded id onto SchemaPtr so
92+
// the MulThresholdProfile MEDICAL/CALLCENTER lookup at
93+
// driver.rs:303-321 actually fires for Healthcare rows. The
94+
// previous `== 0` was written before that fix landed.
95+
assert_eq!(resolved.ontology_context_id(), 2);
9096
}

0 commit comments

Comments
 (0)