Skip to content

Commit 6644ff1

Browse files
committed
docs(board): address #463 review — prepend PR_ARC #463 entry, de-conflict D-HELIX-1 status
CodeRabbit flagged two board-governance issues on #463: - PR_ARC_INVENTORY.md edited the #459 historical section outside the Confidence field. Relocate the correction into a properly prepended #463 entry (rule-5: a separate-PR reversal gets its own entry) and reduce the #459 touch to a Confidence-line forward-pointer. - STATUS_BOARD.md D-HELIX-1 status mixed obsolete (zero-dep / 61 tests / --features ndarray-hpc) with current facts. Clean it to post-#463 reality only (mandatory git dep, no feature, 63 unit + 6 doctests). ndarray dependency source kept as git branch=master per user decision; the Codex P2 (offline) and CodeRabbit (pin-rev) threads are recorded as accepted trade-offs (wontfix) in the new #463 entry. https://claude.ai/code/session_013rjF2Dvo1DnBACpbpYSffE
1 parent 0a56e48 commit 6644ff1

2 files changed

Lines changed: 25 additions & 2 deletions

File tree

.claude/board/PR_ARC_INVENTORY.md

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,29 @@
3535
3636
---
3737

38+
## #463 helix-ndarray-mandatory — ndarray promoted to a mandatory git dependency (codex P2 #460 follow-up)
39+
40+
**Status:** In PR (branch `claude/gallant-rubin-Y9pQd`, head `5758926`). Follow-up to #459/#460 correcting the helix ndarray dependency model; no new types/modules. All 5 CI checks green (format, clippy, test stable, test-with-coverage, linux-build).
41+
42+
**Added:**
43+
- `crates/helix/Cargo.toml`: ndarray changed from an **optional `../../../ndarray` path dep behind `ndarray-hpc`** to a **mandatory, non-optional git dep**`ndarray = { git = "https://github.com/AdaWorldAPI/ndarray.git", branch = "master", default-features = false, features = ["std"] }`.
44+
- `crates/helix/src/simd.rs`: `batch_fisher_z` + `batch_l1_u8` are now the single unconditional impls (the `#[cfg(feature = "ndarray-hpc")]` gate and the scalar-fallback twins are gone). Docs in `lib.rs` / `constants.rs` / `KNOWLEDGE.md` drop the "zero-dep" language.
45+
46+
**Locked:**
47+
- **ndarray is mandatory for helix** (directive "ndarray is mandatory for lance-graph"); helix is no longer "zero-dep". `ndarray::simd` (`simd_ln_f32` / `F32x16` / `U8x64`) does its own AVX-512 / AVX2 / scalar dispatch internally → portable without a hand-written fallback.
48+
- **Source = git `branch="master"` (user decision 2026-06-04).** An optional *path* dep is still read at resolution (codex P2 #460: a clean checkout without the sibling failed before feature selection); a git source resolves remotely. The fork is self-contained (internal subcrates only, no lance-graph back-dep) → no import cycle.
49+
50+
**Deferred (accepted trade-offs — both wontfix by user decision 2026-06-04):**
51+
- **Reproducibility:** `branch="master"` is not pinned to a `rev` (CodeRabbit) — a future master push silently re-resolves helix's lock. Pin to `rev` if/when a frozen helix build is needed.
52+
- **Offline / no-egress:** the git dep needs network egress (Codex P2) even where the `/ndarray` sibling exists locally; accepted because the documented CI has egress (master HEAD resolved to `0129b5c`). The path-dep alternative (offline-buildable, workspace-canonical) was considered and declined to keep helix sibling-independent.
53+
- Carries forward #459 deferrals (TD-HELIX-OVERLAP-1; naive-u8 ≥0.9980 fidelity probe NOT RUN).
54+
55+
**Docs:** board — this entry; STATUS_BOARD D-HELIX-1 status line refreshed to git-mandatory reality; EPIPHANIES E-HELIX-NDARRAY-MANDATORY; LATEST_STATE "hardened" blockquote; #459 Confidence pointer. CodeRabbit's "carrier-method, not free function" note on `simd.rs` **rejected** — SIMD batch kernels over `&[f32]` / `&[u8]` are free/closure batch primitives per the ndarray vertical-SIMD consumer contract, not cognitive-carrier methods (the carrier rule governs `Think` / `trajectory` state).
56+
57+
**Confidence (2026-06-04):** working — CI fully green; git dep resolves in CI. Two bot-review threads resolved **wontfix per user decision** (Codex P2 "git breaks offline" + CodeRabbit "pin to rev"): `branch=master` retained deliberately.
58+
59+
---
60+
3861
## #459 helix-place-residue-codec — golden-spiral Place/Residue codec (zero-dep + optional ndarray-hpc)
3962

4063
**Status:** MERGED 2026-06-03 (merge commit `ef35ff1`), branch `claude/gallant-rubin-Y9pQd`. New standalone crate; autoattended wave (5 read-only research agents + 4 parallel Sonnet leaf workers + central consolidation). 63 unit + 6 doctests green on both feature configs; clippy -D warnings + fmt clean. One CodeRabbit review round resolved pre-merge.
@@ -58,7 +81,7 @@
5881

5982
**Confidence (2026-06-03):** working — both feature configs green, clippy/fmt clean; 2 CodeRabbit findings (public-API NaN guard in `lift`, f32 clamp-epsilon no-op in `batch_fisher_z`) fixed pre-merge with boundary tests.
6083

61-
**Correction (2026-06-03, follow-up PR after #460):** the `../../../ndarray` **path** dep + `ndarray-hpc` feature in the Added block above were wrong twice — (1) codex P2: an optional *path* dep still forces Cargo to read the local sibling manifest at resolution, so the "default build needs none of it" claim was false (a clean checkout failed before feature selection); (2) per the directive **"ndarray is mandatory for lance-graph,"** ndarray is not optional. Both fixed: ndarray is now a **mandatory, non-optional git dependency** (`git = AdaWorldAPI/ndarray @ master`, `ndarray-hpc` feature removed). `simd.rs` always uses `ndarray::simd` (no scalar-fallback variant). The fork is self-contained (internal subcrates only, no lance-graph back-dep) → no import cycle. See E-HELIX-NDARRAY-MANDATORY.
84+
**Confidence (2026-06-04):** the Added-block ndarray design (optional `../../../ndarray` **path** dep + `ndarray-hpc` feature) is **superseded by #463** — ndarray is now a mandatory, non-optional git dep and the feature is removed. The original Added/Locked lines are retained as immutable history; the full correction is recorded in the prepended **#463** entry at the top of this arc (per the rule-5 "reversal = its own PR entry" convention). See E-HELIX-NDARRAY-MANDATORY.
6285

6386
---
6487

.claude/board/STATUS_BOARD.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
## D-HELIX-1 — `crates/helix` golden-spiral Place/Residue codec (zero-dep + optional ndarray-hpc)
1414

15-
**Status:** Shipped (branch `claude/gallant-rubin-Y9pQd`; **61 unit + 6 doctests green** on the default zero-dep build AND under `--features ndarray-hpc`; clippy -D warnings + fmt clean). New standalone crate (empty `[workspace]`, root `exclude`) realising the user's `KNOWLEDGE.md`: `HemispherePoint` (√u equal-area placement) → `CurveRuler` (stride-4-over-17) → `Similarity` (Fisher-Z/arctanh) → `RollingFloor` (256-palette; occupancy-drift + version stamp) → `ResidueEdge` (3-byte endpoint pair) + `DistanceLut` (metric-safe 256×256 L1; `distance_adaptive` vs non-metric `distance_heuristic`) + `prove()` (2-D discrepancy companion to `jc::weyl`). Optional `ndarray-hpc` = batch Fisher-Z via `simd_ln_f32`. ~80% clean-room overlap with CERTIFIED primitives (E-HELIX-OVERLAP / TD-HELIX-OVERLAP-1); consolidation path in `KNOWLEDGE.md`. Process: autoattended — 5 research agents + 4 parallel Sonnet leaf workers + central consolidation. Next (owed): fidelity-vs-ground-truth probe (naive-u8 floor gate ≥0.9980 Pearson, CONJECTURE). **Update (post-#460):** ndarray is now a MANDATORY non-optional **git** dep (codex P2 + directive "ndarray is mandatory for lance-graph"); `simd.rs` always uses `ndarray::simd`; `ndarray-hpc` feature removed. 63 unit + 6 doctests green; clippy/fmt clean. See E-HELIX-NDARRAY-MANDATORY.
15+
**Status:** Shipped (branch `claude/gallant-rubin-Y9pQd`; **63 unit + 6 doctests green**; clippy -D warnings + fmt clean). New standalone crate (empty `[workspace]`, root `exclude`) realising the user's `KNOWLEDGE.md`: `HemispherePoint` (√u equal-area placement) → `CurveRuler` (stride-4-over-17) → `Similarity` (Fisher-Z/arctanh) → `RollingFloor` (256-palette; occupancy-drift + version stamp) → `ResidueEdge` (3-byte endpoint pair) + `DistanceLut` (metric-safe 256×256 L1; `distance_adaptive` vs non-metric `distance_heuristic`) + `prove()` (2-D discrepancy companion to `jc::weyl`). **ndarray is a mandatory, non-optional git dep** (`AdaWorldAPI/ndarray @ master`, `default-features=false, features=["std"]`); `simd.rs` always runs `ndarray::simd` batch Fisher-Z (`simd_ln_f32`) + L1 (`U8x64`) — no `ndarray-hpc` feature, no scalar-fallback twin (#463 + directive "ndarray is mandatory for lance-graph"). ~80% clean-room overlap with CERTIFIED primitives (E-HELIX-OVERLAP / TD-HELIX-OVERLAP-1); consolidation path in `KNOWLEDGE.md`. Process: autoattended — 5 research agents + 4 parallel Sonnet leaf workers + central consolidation. Next (owed): fidelity-vs-ground-truth probe (naive-u8 floor gate ≥0.9980 Pearson, CONJECTURE). See PR_ARC #463 + E-HELIX-NDARRAY-MANDATORY.
1616

1717
## D-A3 — I4x32/I4x64 signed-i4 CAM codec (carrier `pack`/`unpack` + the 256-bit wide carrier)
1818

0 commit comments

Comments
 (0)