Commit 675cb16
committed
fix(delta): drop delta from default features (CI green)
Real CI failure root cause: `deltalake 0.32` removed
`delta_datafusion::DeltaTableProvider::try_new`; the new API is
`TableProviderBuilder::new().with_snapshot(...).with_log_store(...).build().await`
(async, fallible). `crates/lance-graph/src/table_readers.rs:119`
still calls the old API and fails to compile under default features.
Per codex P1's explicit fallback option ("disable/remove the Delta
reader until it can be aligned"), drop `delta` from
`crates/lance-graph/Cargo.toml :: default = [...]`. The `delta`
feature remains opt-in via `--features delta` for any caller that
wants to patch up the broken state themselves; `DeltaTableReader`
itself is already `#[cfg(feature = "delta")]` so non-default builds
don't even compile the broken file. Refactor to TableProviderBuilder
is queued as a follow-up — `TODO(lance-bump-delta)` left at the
feature definition with the new API surface noted.
Local `cargo build --manifest-path crates/lance-graph/Cargo.toml`
(matches CI command) finishes clean in 5m16s.1 parent 4335c7a commit 675cb16
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
66 | 72 | | |
67 | 73 | | |
68 | 74 | | |
| |||
0 commit comments