Skip to content

Commit 837d744

Browse files
committed
onebrc-probe(report): mark lane S as companion-PR-provided, fix reproduce loop
Addresses codex P2 (#638): on this T-only branch lane S is not defined, so the report published results + a parity test for a lane users cannot run here. Adds a 'Lane S provenance' note (S ships in the companion lane-S PR; runnable lanes on this branch are a c r f t8 t) and drops `s` from the reproduce loop with a note to re-add it once the companion PR merges. S rows are kept in the ladder — the report's purpose is the full RAM-vs-trie comparison and S is the fastest RAM-table method. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MLBnPuScZy6w9di2QEjsXM
1 parent 0776626 commit 837d744

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

crates/onebrc-probe/RESULTS_TRIE_VS_RAM.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,13 @@
1818
> (native) per lane. Cardinality is ~400 stations (`gen.rs STATION_COUNT`);
1919
> results are for THIS workload, THIS machine, ONE corpus — see "Scope" at
2020
> the end.
21+
>
22+
> **Lane S provenance.** Lane S (SWAR) is NOT in this PR's diff — it ships in
23+
> the companion PR (`onebrc-probe: lane S`). Its rows below were measured with
24+
> that PR applied; on **this branch alone**, the runnable lanes are
25+
> `a c r f t8 t` and the `lane_s_agrees_with_lane_a` parity test lives in the
26+
> companion PR. S is kept in the ladder because the report's whole point is the
27+
> full RAM-table-vs-trie comparison, and S is the fastest RAM-table method.
2128
2229
## The methods (group-by-aggregate, min/max/sum/count per station)
2330

@@ -148,7 +155,7 @@ count (10M). Not a claim about other CPUs, other cardinalities, or the full
148155
cd crates/onebrc-probe
149156
cargo build --release
150157
target/release/onebrc-probe gen /tmp/brc10m.txt 10000000 42 # if absent
151-
for lane in a c r f t8 t s; do
158+
for lane in a c r f t8 t; do # add `s` once the companion lane-S PR is merged
152159
for i in $(seq 1 11); do target/release/onebrc-probe run /tmp/brc10m.txt $lane 4; done
153160
done # take median + min/max/sd per lane, not best-of-N
154161
# native: RUSTFLAGS="-C target-cpu=native" cargo build --release --target-dir target-native

0 commit comments

Comments
 (0)