Skip to content

Commit 887fed3

Browse files
committed
ci: wire deepnsm into fmt/clippy/test (fmt+test gating, clippy advisory)
deepnsm is a standalone, workspace-excluded codec crate, so the existing CI jobs (which target crates/lance-graph and the contract crate) never reached it: `cargo fmt --all`, the workspace clippy, and the test job all skip it. That is how its formatting silently drifted (28 files, fixed in dd3d9ce) and ~12 clippy lints (TD-DEEPNSM-CLIPPY-195) accrued unseen. Wire it in following the repo's established tiered convention: - style.yml format job: add an explicit `cargo fmt -p deepnsm --check` (gating). The crate was brought rustfmt-clean earlier in this PR. - style.yml clippy job: add deepnsm as a Tier-B advisory step (continue-on-error), mirroring lance-graph core. Promote to gating once TD-DEEPNSM-CLIPPY-195 is cleared by a focused lint sweep. - rust-test.yml test job: run the deepnsm test suite (gating); 0-dep and fast, ~217 lib + integration + doctests. crates/** already triggers these workflows, so deepnsm-only changes now exercise fmt + clippy + test going forward. https://claude.ai/code/session_014A4JuRCqKP2yNENrQ9Ha7H
1 parent dd3d9ce commit 887fed3

2 files changed

Lines changed: 20 additions & 1 deletion

File tree

.github/workflows/rust-test.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,11 @@ jobs:
8787
run: cargo test --manifest-path crates/lance-graph-contract/Cargo.toml --tests
8888
- name: Run contract doctests
8989
run: cargo test --manifest-path crates/lance-graph-contract/Cargo.toml --doc
90+
# deepnsm: standalone 0-dep codec crate, workspace-excluded, so the
91+
# lance-graph test steps above never reached it. ~217 lib + integration +
92+
# doctests, fast (no lance/datafusion/ndarray deps). Gating.
93+
- name: Run deepnsm tests
94+
run: cargo test --manifest-path crates/deepnsm/Cargo.toml
9095

9196
test-with-coverage:
9297
runs-on: ubuntu-24.04

.github/workflows/style.yml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,15 @@ jobs:
7171
- name: Clippy lance-graph (advisory)
7272
continue-on-error: true
7373
run: cargo clippy --manifest-path crates/lance-graph/Cargo.toml --lib --tests -- -D warnings
74+
# Tier B (advisory until incrementally cleaned, non-gating):
75+
# deepnsm is the standalone 0-dep codec crate, workspace-excluded, so it
76+
# was never clippy-checked. It carries ~12 pre-existing default-clippy
77+
# lints (TD-DEEPNSM-CLIPPY-195, clippy 1.95 bump) — mechanical idiom
78+
# lints to be paid down by a focused sweep, same policy as lance-graph
79+
# core. Advisory now; promote to gating once TD-DEEPNSM-CLIPPY-195 clears.
80+
- name: Clippy deepnsm (advisory)
81+
continue-on-error: true
82+
run: cargo clippy --manifest-path crates/deepnsm/Cargo.toml --all-targets -- -D warnings
7483

7584
format:
7685
runs-on: ubuntu-24.04
@@ -94,8 +103,13 @@ jobs:
94103
- uses: actions-rust-lang/setup-rust-toolchain@v1
95104
with:
96105
components: rustfmt
97-
- name: Check formatting
106+
- name: Check formatting (lance-graph)
98107
run: cargo fmt --manifest-path crates/lance-graph/Cargo.toml -- --check
108+
# deepnsm is a standalone, workspace-excluded codec crate, so
109+
# `cargo fmt --all` never reaches it. It was brought to a rustfmt-clean
110+
# baseline in this PR; check it explicitly so it can't silently drift.
111+
- name: Check formatting (deepnsm)
112+
run: cargo fmt --manifest-path crates/deepnsm/Cargo.toml -- --check
99113

100114
# typos / spell-check removed 2026-04-26: too many false positives on
101115
# technical jargon (NARS terms, codec acronyms, German loanwords used in

0 commit comments

Comments
 (0)