Skip to content

Commit 9e412fe

Browse files
committed
fix(gobd_company): replace literal newline in string with \n escape (CodeRabbit P1)
PR #426's `body_source = "<literal newline>".join(body_lines)` was a SyntaxError that escaped the smoke test because the smoke test only exercises uom (the ORM-only path), not l10n_de's data extractor. CodeRabbit flagged this in the final review at `25e8d2b6` as a "duplicate" comment carried forward; it remained unresolved through merge. Fix: `"\n".join(body_lines)` — the intended one-char escape. Now `python -m ast` parses gobd_company.py cleanly. Smoke test still passes (no regression). https://claude.ai/code/session_017gZ6sPRXYPj5n7uJ7NBtRv
1 parent 8b5da0e commit 9e412fe

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

  • tools/odoo-blueprint-extractor/odoo_blueprint_extractor/data_extractors

tools/odoo-blueprint-extractor/odoo_blueprint_extractor/data_extractors/gobd_company.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ def _find_compute_method(source: str, method_name: str) -> Optional[Dict]:
4848
# Extract source lines for body inspection
4949
lines = source.splitlines()
5050
body_lines = lines[node.lineno - 1:end]
51-
body_source = "
52-
".join(body_lines)
51+
body_source = "\n".join(body_lines)
5352
return {
5453
"name": method_name,
5554
"lineno": node.lineno,

0 commit comments

Comments
 (0)