Commit a68e213
committed
chore(clippy): close len_zero + await_holding_lock blockers
Two clippy errors surfacing on the lance-cache feature gate:
1. lance_cache.rs:110 (mine, from the versioning PR step) — `arr.len() > 0`
→ `!arr.is_empty()`.
2. registry.rs:185 (pre-existing) — `MutexGuard` held across an await
point. PR #369's body claimed this was fixed but it landed unfixed.
Clone `last_root_checksum` out of the read guard before the
`set_last_root_checksum().await` call so the guard drops first.
`cargo clippy -p lance-graph-ontology --features lance-cache --tests
--no-deps -- -D warnings` exits 0 after these two.1 parent b92c932 commit a68e213
2 files changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
186 | | - | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
187 | 190 | | |
188 | 191 | | |
189 | 192 | | |
| |||
0 commit comments