Skip to content

Commit cad6610

Browse files
authored
Merge pull request #241 from AdaWorldAPI/claude/teleport-session-setup-wMZfb
ci: remove clippy from GitHub CI (local pre-check only)
2 parents 5625bb4 + 3ea2b87 commit cad6610

3 files changed

Lines changed: 21 additions & 19 deletions

File tree

.github/workflows/build.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@ jobs:
3030
- stable
3131
steps:
3232
- uses: actions/checkout@v4
33+
- name: Checkout AdaWorldAPI/ndarray (sibling dependency)
34+
uses: actions/checkout@v4
35+
with:
36+
repository: AdaWorldAPI/ndarray
37+
path: ../ndarray
3338
- name: Setup rust toolchain
3439
run: |
3540
rustup toolchain install ${{ matrix.toolchain }}

.github/workflows/rust-test.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@ jobs:
3030
- stable
3131
steps:
3232
- uses: actions/checkout@v4
33+
- name: Checkout AdaWorldAPI/ndarray (sibling dependency)
34+
uses: actions/checkout@v4
35+
with:
36+
repository: AdaWorldAPI/ndarray
37+
path: ../ndarray
3338
- name: Setup rust toolchain
3439
run: |
3540
rustup toolchain install ${{ matrix.toolchain }}
@@ -56,6 +61,11 @@ jobs:
5661
timeout-minutes: 30
5762
steps:
5863
- uses: actions/checkout@v4
64+
- name: Checkout AdaWorldAPI/ndarray (sibling dependency)
65+
uses: actions/checkout@v4
66+
with:
67+
repository: AdaWorldAPI/ndarray
68+
path: ../ndarray
5969
- name: Setup rust toolchain
6070
run: |
6171
rustup toolchain install stable

.github/workflows/style.yml

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -30,25 +30,12 @@ jobs:
3030
- name: Check formatting
3131
run: cargo fmt --manifest-path crates/lance-graph/Cargo.toml -- --check
3232

33-
clippy:
34-
runs-on: ubuntu-24.04
35-
timeout-minutes: 15
36-
steps:
37-
- uses: actions/checkout@v4
38-
- uses: Swatinem/rust-cache@v2
39-
with:
40-
shared-key: "lance-graph-deps"
41-
workspaces: |
42-
crates/lance-graph
43-
crates/lance-graph-python
44-
- name: Install dependencies
45-
run: |
46-
sudo apt update
47-
sudo apt install -y protobuf-compiler
48-
- name: Clippy lance-graph
49-
run: cargo clippy --manifest-path crates/lance-graph/Cargo.toml --all-targets -- -D warnings
50-
- name: Clippy lance-graph-python
51-
run: cargo clippy --manifest-path crates/lance-graph-python/Cargo.toml --all-targets -- -D warnings
33+
# clippy: runs LOCALLY as our internal pre-check, not on GitHub CI.
34+
# GitHub CI focuses on compile + test + format + typos.
35+
# Clippy discipline documented in CODING_PRACTICES.md:
36+
#
37+
# cargo clippy --features lab -- -D warnings
38+
# cargo clippy --features serve -- -D warnings
5239

5340
typos:
5441
name: Spell Check

0 commit comments

Comments
 (0)