Skip to content

Commit d760655

Browse files
committed
ci: remove clippy from GitHub CI — it's our local pre-check, not CI
Clippy is an internal pre-check run locally per CODING_PRACTICES.md. GitHub CI focuses on compile + test + format + typos. Having clippy in the GitHub workflow made PRs look like a CI battlefield when the runner's toolchain components didn't match. Removed the clippy job from .github/workflows/style.yml. The local discipline (documented in CODING_PRACTICES.md "Mandatory cargo clippy + feature-matrix discipline") remains: cargo clippy --features lab -- -D warnings cargo clippy --features serve -- -D warnings https://claude.ai/code/session_01SbYsmmbPf9YQuYbHZN52Zh
1 parent 5625bb4 commit d760655

1 file changed

Lines changed: 6 additions & 19 deletions

File tree

.github/workflows/style.yml

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -30,25 +30,12 @@ jobs:
3030
- name: Check formatting
3131
run: cargo fmt --manifest-path crates/lance-graph/Cargo.toml -- --check
3232

33-
clippy:
34-
runs-on: ubuntu-24.04
35-
timeout-minutes: 15
36-
steps:
37-
- uses: actions/checkout@v4
38-
- uses: Swatinem/rust-cache@v2
39-
with:
40-
shared-key: "lance-graph-deps"
41-
workspaces: |
42-
crates/lance-graph
43-
crates/lance-graph-python
44-
- name: Install dependencies
45-
run: |
46-
sudo apt update
47-
sudo apt install -y protobuf-compiler
48-
- name: Clippy lance-graph
49-
run: cargo clippy --manifest-path crates/lance-graph/Cargo.toml --all-targets -- -D warnings
50-
- name: Clippy lance-graph-python
51-
run: cargo clippy --manifest-path crates/lance-graph-python/Cargo.toml --all-targets -- -D warnings
33+
# clippy: runs LOCALLY as our internal pre-check, not on GitHub CI.
34+
# GitHub CI focuses on compile + test + format + typos.
35+
# Clippy discipline documented in CODING_PRACTICES.md:
36+
#
37+
# cargo clippy --features lab -- -D warnings
38+
# cargo clippy --features serve -- -D warnings
5239

5340
typos:
5441
name: Spell Check

0 commit comments

Comments
 (0)