Commit d854974
committed
Two follow-up doc fixes after PR #452 and #453 merged. Reviewers
flagged real bugs the doc-only PRs landed with; these corrections
bring main in line with the post-review state.
== CLUSTER_ASYMMETRY.md ==
Drop the vort/vart adaptive-radix-trie citation; cite shipped
NiblePath + Lance versions() instead. A workspace scan across all
Cargo.toml files confirms vart is NOT a dependency in this
repository; le-domino's own seam-map documents it as 'doc-prose
only'. Citing a non-existent crate in a public architecture doc
misleads adopters into looking for a crate that they cannot find.
The role the bullet described (HHTL-prefix dedup) is actually:
- lance-graph-contract::hhtl::NiblePath (shipped) for the identity
primitive (16-fan-out nibble path packed into a u64)
- Lance versions() (shipped) for the time-axis (cross-session index
of which identity positions changed when)
Adopters can derive an adaptive radix-trie index over NiblePath
addresses themselves; that data structure is consumer code, not a
lance-graph dep. The corrected bullet cites the two shipped surfaces
and flags the radix-shaped consumer pattern as proposed.
== APPEND_ONLY_RAFT_DOVETAIL.md ==
Apply the same critique class codex raised on PR #453's companion doc:
- Scope caveat: peer-Raft + Lance-local is an EXTERNAL architecture
pattern (bardioc B1 substrate-b), NOT a built-in lance-graph
feature. Adopters provide the Raft layer themselves (openraft /
surreal-cluster / external TiKV). Lance-graph contributes the
storage-append/consensus-append dovetail property that MAKES the
pattern cheap; not the pattern itself. Added a scope banner
immediately after the TL;DR.
- Compaction honesty: Lance has compaction TOO via
DatasetOptimizer.compact_files for fragment layout. The doc
previously said 'Lance has no compaction' which is wrong for
append-heavy deployments. Rewrote section 1 to distinguish LSM
tombstone-reclaim+run-merge compaction from Lance file-layout
compaction. Both exist; only LSM coordinates with replication.
- Consensus-tax-lands-once section also updated to acknowledge that
Lance file compaction runs INDEPENDENTLY of consensus (the storage
commit tax and the consensus tax are the same write; the LAYOUT
OPTIMIZATION cycle is a separate concern that does not couple).
Both files were merged earlier (PR #452, #453); these corrections
land in main as a follow-up so adopters reading the docs today see
the honest scope + correct citations. No code changes; doc-only.
1 parent 16f879b commit d854974
2 files changed
Lines changed: 81 additions & 31 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
15 | 33 | | |
16 | 34 | | |
17 | 35 | | |
| |||
35 | 53 | | |
36 | 54 | | |
37 | 55 | | |
38 | | - | |
| 56 | + | |
39 | 57 | | |
40 | 58 | | |
41 | 59 | | |
42 | | - | |
| 60 | + | |
43 | 61 | | |
44 | | - | |
45 | | - | |
46 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
47 | 66 | | |
48 | 67 | | |
49 | 68 | | |
| |||
56 | 75 | | |
57 | 76 | | |
58 | 77 | | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
63 | 96 | | |
64 | 97 | | |
65 | | - | |
66 | | - | |
67 | | - | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
68 | 103 | | |
69 | 104 | | |
70 | 105 | | |
| |||
109 | 144 | | |
110 | 145 | | |
111 | 146 | | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
125 | 166 | | |
126 | 167 | | |
127 | 168 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
104 | 113 | | |
105 | 114 | | |
106 | 115 | | |
| |||
0 commit comments