Commit dbfc08a
committed
fix: codec_sweep.sh stub honesty check must FAIL THE SCRIPT, not just log
Codex P2 review catch — the "Stub honesty check" block was echoing
results[0].stub but always exiting 0, which undermined the anti-#219
safeguard the script claims to enforce. In Phase 0/2 runs, a non-stub
or malformed response could look like a successful sweep in automation.
Fix: after extracting the flag, case on it:
- true → OK, echo success (Phase 0 stub honored)
- false → FAIL exit 3, diagnostic message naming two possible causes
(server running non-scaffold code OR wrong endpoint hit)
- * → FAIL exit 3, points at the malformed response section
The fix embodies the session's own principle ("the object does the
work" / "stub flag is machine-checkable anti-#219"): a script that
claims to check a flag but doesn't exit on failure is exactly the
pattern we warn against in CODING_PRACTICES.md. The script now
actually enforces what it documents.
Cross-ref: PR #239 D3.2; EPIPHANIES.md 2026-04-20 "D0.2 stub flag is
anti-#219 defense at the type level"; Codex P2 review 2026-04-21.
https://claude.ai/code/session_01SbYsmmbPf9YQuYbHZN52Zh1 parent b64baad commit dbfc08a
1 file changed
Lines changed: 29 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
60 | 68 | | |
61 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
0 commit comments