You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
merge: resolve main into PR #369 branch (lance_cache.rs conflict)
Single conflict at crates/lance-graph-ontology/src/lance_cache.rs in
set_last_root_checksum() — main retained the legacy
futures::stream::iter(...).into_inner_unwrap_iter(...) shape, while
this PR replaced it with the cleaner vec![Ok(batch)].into_iter()
pattern as part of the W3 lance_cache Arrow schema bump's collateral
cleanup (matching the same site in flush()).
Resolution: keep PR head's vec![Ok(batch)].into_iter() at both call
sites (flush() and set_last_root_checksum()) — these are functionally
equivalent and the cleanup is intentional per the PR description.
No other conflicts.
2026-05-13 sprint-log-7 META (Opus 4.7): cross-implementation review across 7 worker outputs — 3A/3B/1B-minus, 32 KB at .claude/board/sprint-log-7/meta-review.md; single must-fix CC-7-1 (UnifiedAuditSink vs AuditSink trait split blocks W6 from bridge); 3-PR split recommended (A scaffold+W2+W3+W4, B hydration W1+W7, C gate+sinks W5+W6 with trait-family fix).
- Removed `euler_gamma_fold, euler_gamma_unfold` from the `use bgz_tensor::euler_fold::{...}` import. These two symbols were imported but never used in the file.
1087
+
1088
+
**bgz-tensor src/ scan:** lint_inventory.txt has zero entries for `bgz-tensor/src/**`. No additional fixes needed.
1089
+
1090
+
**Verification:** ndarray/blake3 pre-existing compile failure prevents clippy from running in this environment. Fix is syntactically correct. W12 is the definitive gate.
**Pattern:**`for d in 0..17 { dims[d] = expr(i,d); }` -> `for (d, out) in dims.iter_mut().enumerate() { *out = expr(i,d); }` across all 6 role simulation blocks (Q/K/V/Gate/Up/Down).
1100
+
**Verification:** clippy blocked by pre-existing ndarray/blake3 compile error (confirmed pre-existing via git stash test). rustfmt check exits 0.
Fixed all 5 lint sites (6 sites in MANIFEST counts the two div_ceil as separate; one unused_variable + two manual_div_ceil + two manual_range_patterns):
2.`navigator.rs:55``unused_import: VectorSlice`: moved to `#[cfg(feature="datafusion-storage")]` at top level + explicit `use crate::bitpack::VectorSlice` in `#[cfg(test)] mod tests`
1202
+
3.`simd_hardened.rs:9``unused_import: GOLDEN_RATIO`: removed (use site already has hardcoded literal)
1203
+
4.`source.rs:11``unused_import: BASE_DIM`: removed from top-level import; added `use crate::BASE_DIM` inside `#[cfg(test)] mod tests`
All three crates exit 0 under `rustup run 1.95.0 cargo clippy -p <crate> --all-targets -- -D warnings` (holograph lib+tests clean; hamming_bench criterion dep error pre-existing).
**Goal:** fix all 42 clippy lint sites surfaced after bumping rust-toolchain.toml to 1.95.0. The pre-existing janitor sweep in PR #366 cleared most of the surface; this round closes the remaining 1.95-specific lints to make `cargo clippy --workspace --all-targets -- -D warnings` exit 0 on 1.95.0.
| W12 | verify | run `cargo clippy --workspace --all-targets -- -D warnings` + `cargo test --workspace` post-fleet, report final state | — |
26
+
| M | meta | synthesize 12 reports, commit + push + open PR | — |
27
+
28
+
## Permissions
29
+
30
+
`.claude/settings.local.json` allows `tee -a .claude/board/sprint-log-8/agents/*` for the agents to append their entries. Project-level `.claude/settings.json` already covers most of the workspace.
31
+
32
+
## Common 1.95 lint cookbook
33
+
34
+
-`(x + n - 1) / n` → `x.div_ceil(n)` (manual_div_ceil)
35
+
-`for i in 0..N { v[i] = ... }` → `for (i, x) in v.iter_mut().enumerate().take(N) { *x = ... }` (needless_range_loop)
-`VectorSlice` in navigator.rs is used in `#[cfg(feature = "datafusion-storage")]` production code AND in non-gated tests. Fixed by feature-gated top-level import + explicit import in test module.
Reformatted ~230 files across the workspace (bgz17, bgz-tensor examples, causal-edge, holograph, highheelbgz, lance-graph-callcenter, lance-graph-ontology, lance-graph-contract, lance-graph-supervisor, thinking-engine examples/src, tools/dto-class-check, and a few Cargo.tomls).
Result: zero lint sites in any of these crates. All 42 inventory entries belong to `crates/bgz-tensor/examples/` (W1-W9) or `crates/lance-graph-contract/src/orchestration_mode.rs` (W10). No catchall fixes needed.
25
+
26
+
## Files Modified
27
+
28
+
Only formatting changes; no logic edits. ~230 files normalized by rustfmt 1.95.0.
0 commit comments