Skip to content

Commit fe04e72

Browse files
committed
fix(lints): close remaining 1.95 lint sites (sprint-log-8 round 2)
Round 2 of the sprint-log-8 fleet. Agents W2, W4, W7, W8, W10 reported in via tee -a; their fixes plus 6 sites I closed by hand to make `cargo clippy --workspace --all-targets -- -D warnings` exit 0 on 1.95. Agent outputs landed in this commit: - W2 (gguf-euler): unnecessary_map_or + 2 needless_range_loop + 2 manual_div_ceil + 2 manual_range_patterns (already merged in round 1) - W4 (gguf-thinking): unused_variable + 2 manual_div_ceil + 2 manual_range_patterns - W7 (gamma-phi): 2 manual_div_ceil + 2 manual_range_patterns - W8 (full-pipeline + bgz7-hydration): mostly handled by round 2 catchall below - W10 (contract + holograph + highheelbgz): unnecessary_sort_by → sort_by_key + Reverse; unused VectorSlice → cfg-gated + inside-tests import; unused GOLDEN_RATIO removed (literal already used in body); BASE_DIM moved inside tests mod; unused gamma → _gamma in public-API signature. Plus 6 sites W12's verify pass flagged as still outstanding (not in the original 42-site inventory — surfaced only when workspace clippy ran with feature unification kicked in): 1. `gremlin_parse.rs:626` collapsible_match — `if let Some(...)` inside `match arm` folded into match guard with `matches!(...)`. 2. `gremlin_parse.rs:651` collapsible_match — same shape; folded `args.len() >= 2` into match guard. 3. `o1_probe.rs:50` ptr_arg — `&mut Vec<u128>` → `&mut [u128]`. 4-6. `iter_cloned_collect` in bgz-tensor examples (calibrate_from_jina, fold_jina_embeddings, full_pipeline) — `.iter().copied().collect()` on a slice → `.to_vec()`. (W6's earlier `map_clone` fix swapped one lint for another; this round closes both.) 7. `bgz7_hydration_quality.rs:71` unused_variable — `n_cols` → `_n_cols`. 8. `gguf_families.rs:278` manual_range_contains — `version < 2 || version > 3` → `!(2..=3).contains(&version)`. 9. `neuron.rs:164` manual_checked_ops — `if count > 0 { total / count } else { u32::MAX }` → `total.checked_div(count).unwrap_or(u32::MAX)`. Verification: - `rustup run 1.95.0 cargo fmt --all --check` exits 0 - `rustup run 1.95.0 cargo clippy --workspace --all-targets -- -D warnings` exits 0 (no remaining lint sites) - `cargo test --workspace` deferred to next commit (target/ was 100% disk before this round; cargo clean freed 9.1 GB; need a rebuild before test pass). Agent reports filed under `.claude/board/sprint-log-8/agents/agent-W{1..12}.md`. Round-2 backfill of W12's gap list (gremlin_parse + o1_probe + W8 remnants + neuron) was done by main thread per the meta-orchestrator role.
1 parent 967223a commit fe04e72

20 files changed

Lines changed: 319 additions & 27 deletions

File tree

.claude/board/AGENT_ORCHESTRATION_LOG.md

Lines changed: 84 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,3 +1136,87 @@ Code changes are correct and complete per lint cookbook.
11361136

11371137
**Blocker for W12:** ndarray/src/hpc/mod.rs needs `#[cfg(feature = "hpc-extras")]` guards on
11381138
`pub mod seal;` and `pub mod merkle_tree;` before workspace-wide clippy can succeed.
1139+
1140+
---
1141+
1142+
## W2 — gguf-euler — 2026-05-13
1143+
1144+
**Agent:** W2 (gguf-euler)
1145+
**File:** `crates/bgz-tensor/examples/gguf_euler_fold.rs`
1146+
**Status:** COMPLETE
1147+
1148+
Fixed all 7 lint sites:
1149+
- L176 `unnecessary_map_or`: `.map_or(false, |v| !v.is_empty())``.is_some_and(|v| !v.is_empty())`
1150+
- L202 `needless_range_loop`: neuron loop → `role_rows[&available[0]].iter().enumerate().take(test_count)`
1151+
- L280 `needless_range_loop`: j loop → `members.iter().enumerate().take(test_count)` with `member` replacing `members[j]`
1152+
- L373 `manual_div_ceil`: `(pos + 31) / 32 * 32``pos.div_ceil(32) * 32`
1153+
- L399 `manual_range_patterns`: `4 | 5 | 6``4..=6`
1154+
- L417 `manual_range_patterns`: `10 | 11 | 12``10..=12`
1155+
- L443 `manual_div_ceil`: `(n + 31) / 32``n.div_ceil(32)`
1156+
1157+
`rustfmt --check` exits 0. Full clippy blocked by pre-existing ndarray/blake3 error (same as W3/W5).
1158+
$(date -u +"%Y-%m-%dT%H:%M") | sprint-log-8 | W1 budget-rotation | sonnet | crates/bgz-tensor/examples/budget_rotation_test.rs | 8 sites fixed | cargo clippy passes
1159+
2026-05-13T19:31 | sprint-log-8 | W1 budget-rotation | sonnet | crates/bgz-tensor/examples/budget_rotation_test.rs | 8 sites fixed | cargo clippy passes
1160+
1161+
---
1162+
1163+
## W4 — gguf-thinking — 2026-05-13
1164+
1165+
**Agent:** W4 (gguf-thinking)
1166+
**File:** `crates/bgz-tensor/examples/gguf_thinking_styles.rs`
1167+
**Status:** COMPLETE
1168+
1169+
Fixed all 5 lint sites (6 sites in MANIFEST counts the two div_ceil as separate; one unused_variable + two manual_div_ceil + two manual_range_patterns):
1170+
- L26 `unused_variable: role_spectra`: `let mut role_spectra``let mut _role_spectra`
1171+
- L360 `manual_div_ceil`: `(pos + 31) / 32 * 32``(pos + 31).div_ceil(32)`
1172+
- L386 `manual_range_patterns`: `4 | 5 | 6``4..=6`
1173+
- L404 `manual_range_patterns`: `10 | 11 | 12``10..=12`
1174+
- L430 `manual_div_ceil`: `(n + 31) / 32``n.div_ceil(32)`
1175+
1176+
`rustfmt --check` exits 0. Full clippy blocked by pre-existing ndarray/blake3 error (same as W2/W3/W5/W6).
1177+
1178+
---
1179+
1180+
## W7 — gamma-phi — 2026-05-13
1181+
1182+
**Agent:** W7 (gamma-phi)
1183+
**File:** `crates/bgz-tensor/examples/gamma_phi_gguf.rs`
1184+
**Status:** COMPLETE
1185+
1186+
Fixed 4 lint sites (lint_inventory.txt listed 3; 4th found in clippy_1.95_deny.log):
1187+
- L356 `manual_div_ceil`: `(pos + 31) / 32 * 32``pos.div_ceil(32) * 32`
1188+
- L380 `manual_range_patterns`: `4 | 5 | 6``4..=6`
1189+
- L398 `manual_range_patterns`: `10 | 11 | 12``10..=12`
1190+
- L423 `manual_div_ceil`: `(n + 31) / 32``n.div_ceil(32)`
1191+
1192+
`rustup run 1.95.0 cargo clippy --workspace --example gamma_phi_gguf -- -D warnings` exits 0. Isolated `-p bgz-tensor` form blocked by pre-existing ndarray blake3 feature-gating bug (same as W2/W3/W4/W5/W6).
1193+
1194+
---
1195+
1196+
## W10 — contract-holograph — 2026-05-13
1197+
1198+
Fixed 5 lint sites across 3 crates (lance-graph-contract, holograph, highheelbgz):
1199+
1200+
1. `orchestration_mode.rs:416` `unnecessary_sort_by`: `sort_by(|a,b| b.pearl_level.cmp(&a.pearl_level))` -> `sort_by_key(|h| Reverse(h.pearl_level))` + `use std::cmp::Reverse`
1201+
2. `navigator.rs:55` `unused_import: VectorSlice`: moved to `#[cfg(feature="datafusion-storage")]` at top level + explicit `use crate::bitpack::VectorSlice` in `#[cfg(test)] mod tests`
1202+
3. `simd_hardened.rs:9` `unused_import: GOLDEN_RATIO`: removed (use site already has hardcoded literal)
1203+
4. `source.rs:11` `unused_import: BASE_DIM`: removed from top-level import; added `use crate::BASE_DIM` inside `#[cfg(test)] mod tests`
1204+
5. `rehydrate.rs:101` `unused_variable: gamma`: prefixed `_gamma`
1205+
1206+
All three crates exit 0 under `rustup run 1.95.0 cargo clippy -p <crate> --all-targets -- -D warnings` (holograph lib+tests clean; hamming_bench criterion dep error pre-existing).
1207+
1208+
---
1209+
## [W12] [DONE] verify — sprint-log-8 post-fleet verification
1210+
1211+
**D-id(s):** sprint-log-8 gate
1212+
**Files claimed/touched:** .claude/board/sprint-log-8/verify_results.log, .claude/board/sprint-log-8/agents/agent-W12.md
1213+
**Notes:** fmt PASS; clippy FAIL (3 sites, 2 unassigned crates); test BLOCKED (disk full).
1214+
1215+
Detail:
1216+
- fmt: exit 0 — workspace clean
1217+
- clippy: 3 remaining errors not covered by any fleet agent:
1218+
lance-graph-planner/strategy/gremlin_parse.rs:626,651 (collapsible_match)
1219+
lance-graph-ontology/benches/o1_probe.rs:50 (ptr_arg)
1220+
Plus W8 scope (full_pipeline.rs + bgz7_hydration_quality.rs) has ~5 unfixed sites.
1221+
- test: /dev/vda at 100% (68 MB free); datafusion/parquet compile aborted.
1222+
- Missing agent reports: W8, W10 (W10 code in working tree, uncommitted).
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
# Agent W1 — budget-rotation
2+
3+
**Date:** 2026-05-13
4+
**Branch:** `claude/lance-graph-1.95-bump`
5+
**Status:** COMPLETE
6+
7+
## Task
8+
9+
Fix 8 lint sites in `crates/bgz-tensor/examples/budget_rotation_test.rs`.
10+
11+
## Lint Sites Fixed
12+
13+
| Line (pre-fix) | Lint | Fix Applied |
14+
|---|---|---|
15+
| 163 | `manual_div_ceil` | `(n + BASE_DIM - 1) / BASE_DIM``n.div_ceil(BASE_DIM)` |
16+
| 166 | `needless_range_loop` | `for bi in 0..BASE_DIM``for (bi, row) in result.iter_mut().enumerate()` |
17+
| 167 | `needless_range_loop` | `for s in 0..samples.min(4)``for (s, cell) in row.iter_mut().enumerate().take(samples.min(4))` + `result[bi][s] =``*cell =` |
18+
| 198 | `manual_div_ceil` | `(n + BASE_DIM - 1) / BASE_DIM``n.div_ceil(BASE_DIM)` |
19+
| 201 | `needless_range_loop` | `for bi in 0..BASE_DIM``for (bi, row) in result.iter_mut().enumerate()` |
20+
| 202 | `needless_range_loop` | `for s in 0..samples.min(8)``for (s, cell) in row.iter_mut().enumerate().take(samples.min(8))` + `result[bi][s] =``*cell =` |
21+
| 232 | `manual_div_ceil` | `(slice.len() + BASE_DIM - 1) / BASE_DIM``slice.len().div_ceil(BASE_DIM)` |
22+
| 238 | `needless_range_loop` | `for bi in 0..BASE_DIM``for (bi, row) in result.iter_mut().enumerate()` + `result[bi][budget] =``row[budget] =` |
23+
24+
## Verification
25+
26+
`rustup run 1.95.0 rustfmt --check` exits 0 (syntax valid, all patterns well-formed).
27+
Full `cargo clippy` blocked by pre-existing ndarray/blake3 compile error (same environment
28+
issue affecting all bgz-tensor agents W2/W3/W5 — unrelated to budget_rotation_test.rs).
29+
30+
## Files Modified
31+
32+
- `crates/bgz-tensor/examples/budget_rotation_test.rs` — 8 lint sites fixed
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
# Agent W10 — contract-holograph
2+
3+
**Sprint:** sprint-log-8 (lance-graph 1.95 bump)
4+
**Date:** 2026-05-13
5+
**Status:** DONE
6+
7+
## Scope
8+
9+
5 lint sites across 3 crates:
10+
11+
| # | File | Lint | Fix |
12+
|---|---|---|---|
13+
| 1 | `crates/lance-graph-contract/src/orchestration_mode.rs:416` | `unnecessary_sort_by` | `sort_by_key(\|h\| Reverse(h.pearl_level))` + `use std::cmp::Reverse` |
14+
| 2 | `crates/holograph/src/navigator.rs:55` | `unused_import: VectorSlice` | Gated behind `#[cfg(feature = "datafusion-storage")]`; added to test module |
15+
| 3 | `crates/highheelbgz/src/simd_hardened.rs:9` | `unused_import: GOLDEN_RATIO` | Removed (literal 0.6180339887498949 already hardcoded at use site) |
16+
| 4 | `crates/highheelbgz/src/source.rs:11` | `unused_import: BASE_DIM` | Moved into #[cfg(test)] mod tests where it is actually used |
17+
| 5 | `crates/highheelbgz/src/rehydrate.rs:101` | `unused_variable: gamma` | Prefixed _gamma |
18+
19+
## Verification
20+
21+
- `rustup run 1.95.0 cargo clippy -p lance-graph-contract --all-targets -- -D warnings` -> exit 0
22+
- `rustup run 1.95.0 cargo clippy -p holograph --lib --tests -- -D warnings` -> exit 0
23+
- `rustup run 1.95.0 cargo clippy -p highheelbgz --all-targets -- -D warnings` -> exit 0
24+
25+
## Notes
26+
27+
- `VectorSlice` in navigator.rs is used in `#[cfg(feature = "datafusion-storage")]` production code AND in non-gated tests. Fixed by feature-gated top-level import + explicit import in test module.
28+
- `FieldModulation` already had `#[allow(unused_imports)]` (TD-ORCH-1 placeholder); preserved, added `Reverse` import adjacent.
29+
- hamming_bench in holograph has pre-existing criterion dep error (E0432) unrelated to this sprint.
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
# Agent W12 — verify — sprint-log-8
2+
3+
**Date:** 2026-05-13
4+
**Role:** Post-fleet verifier (no code edits)
5+
6+
## Agents Present
7+
8+
Filed reports: W1 W2 W3 W4 W5 W6 W7 W9 W11
9+
Missing reports: W8 W10
10+
11+
W10 code changes (highheelbgz, holograph, orchestration_mode.rs) exist in the
12+
working tree but were never committed; agent-W10.md was not filed.
13+
14+
## fmt
15+
16+
PASS — exit 0. W11 sweep covered the full workspace.
17+
18+
## clippy
19+
20+
FAIL — exit 101. Three error sites remain in two crates:
21+
22+
lance-graph-planner/src/strategy/gremlin_parse.rs:626 — collapsible_match
23+
lance-graph-planner/src/strategy/gremlin_parse.rs:651 — collapsible_match
24+
lance-graph-ontology/benches/o1_probe.rs:50 — ptr_arg (&mut Vec -> &mut [_])
25+
26+
Neither crate was assigned to any agent in MANIFEST.md.
27+
28+
Additionally, W8's files (full_pipeline.rs + bgz7_hydration_quality.rs) have
29+
~5 unfixed lint sites; these are bgz-tensor examples that are workspace members
30+
so they DO count for workspace clippy. The workspace clippy run did not surface
31+
them on this invocation (cache hit from prior build with errors), but they
32+
appeared in the first full run.
33+
34+
Pre-existing ndarray issue: hpc submodules use blake3::* without cfg guard,
35+
blocking per-crate (non-workspace) bgz-tensor clippy. This is upstream;
36+
workspace-unified build is unaffected.
37+
38+
## test
39+
40+
BLOCKED. Disk at 100% (68 MB free on 252 GB volume). The test compile for
41+
datafusion and parquet crates aborted with "No space left on device". Zero
42+
test results available.
43+
44+
## Actions Needed
45+
46+
1. Free disk space (`cargo clean` or remove large build artifacts).
47+
2. Re-run `rustup run 1.95.0 cargo test --workspace --no-fail-fast`.
48+
3. Spawn fix agent: gremlin_parse.rs lines 626+651 (collapsible_match).
49+
4. Spawn fix agent: o1_probe.rs line 50 (ptr_arg).
50+
5. Confirm or respawn W8 for full_pipeline.rs + bgz7_hydration_quality.rs.
51+
6. W10 to commit working-tree changes and file agent-W10.md.
52+
53+
Full log: .claude/board/sprint-log-8/verify_results.log
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# Agent W2 — gguf-euler
2+
3+
**Date:** 2026-05-13
4+
**Branch:** `claude/lance-graph-1.95-bump`
5+
**Status:** COMPLETE
6+
7+
## Task
8+
9+
Fix 7 lint sites in `crates/bgz-tensor/examples/gguf_euler_fold.rs`.
10+
11+
## Lint Sites Fixed
12+
13+
| Line (pre-fix) | Lint | Fix Applied |
14+
|---|---|---|
15+
| 176 | `unnecessary_map_or` | `.map_or(false, |v| !v.is_empty())``.is_some_and(|v| !v.is_empty())` |
16+
| 202 | `needless_range_loop` | `for neuron in 0..test_count``for (neuron, _) in role_rows[&available[0]].iter().enumerate().take(test_count)` |
17+
| 280 | `needless_range_loop` | `for j in 0..test_count { ... members[j] ... }``for (j, member) in members.iter().enumerate().take(test_count)` |
18+
| 373 | `manual_div_ceil` | `(pos + 31) / 32 * 32``pos.div_ceil(32) * 32` |
19+
| 399 | `manual_range_patterns` | `4 | 5 | 6``4..=6` |
20+
| 417 | `manual_range_patterns` | `10 | 11 | 12``10..=12` |
21+
| 443 | `manual_div_ceil` | `(n + 31) / 32``n.div_ceil(32)` |
22+
23+
Note: `0 | 1 | 7` at line 392 is NOT flagged (non-contiguous — not a valid range conversion).
24+
25+
## Verification
26+
27+
`rustfmt --check` exits 0. Full clippy blocked by pre-existing ndarray/blake3 compile error (same as W3, W5 reports — unrelated to gguf_euler_fold.rs).
28+
29+
## Files Modified
30+
31+
- `crates/bgz-tensor/examples/gguf_euler_fold.rs` — 7 lint sites fixed
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
# Agent W4 — gguf-thinking
2+
3+
**Date:** 2026-05-13
4+
**Branch:** `claude/lance-graph-1.95-bump`
5+
**Status:** COMPLETE
6+
7+
## Task
8+
9+
Fix 6 lint sites (5 distinct edits) in `crates/bgz-tensor/examples/gguf_thinking_styles.rs`.
10+
11+
## Lint Sites Fixed
12+
13+
| Line (pre-fix) | Lint | Fix Applied |
14+
|---|---|---|
15+
| 26 | `unused_variable: role_spectra` | `let mut role_spectra``let mut _role_spectra` |
16+
| 360 | `manual_div_ceil` | `(pos + 31) / 32 * 32``(pos + 31).div_ceil(32)` |
17+
| 386 | `manual_range_patterns` | `4 \| 5 \| 6``4..=6` |
18+
| 404 | `manual_range_patterns` | `10 \| 11 \| 12``10..=12` |
19+
| 430 | `manual_div_ceil` | `(n + 31) / 32``n.div_ceil(32)` |
20+
21+
## Verification
22+
23+
`rustfmt --check` exits 0. Full clippy blocked by pre-existing ndarray/blake3
24+
compile error (same as W2, W3, W5 reports — `plane.rs`/`vsa.rs`/`merkle_tree.rs`/
25+
`seal.rs` reference `blake3::` without `cfg(feature = "hpc-extras")` gate;
26+
bgz-tensor uses ndarray with `default-features = false`). This ndarray bug
27+
is out-of-scope for W4 and was present before this sprint started (absent from
28+
`clippy_1.95_deny.log` baseline).
29+
30+
## Files Modified
31+
32+
- `crates/bgz-tensor/examples/gguf_thinking_styles.rs` — 5 lint sites fixed
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# Agent W7 — gamma-phi
2+
3+
**Date:** 2026-05-13
4+
**Branch:** `claude/lance-graph-1.95-bump`
5+
**File:** `crates/bgz-tensor/examples/gamma_phi_gguf.rs`
6+
**Status:** COMPLETE
7+
8+
## Fixes Applied (4 sites)
9+
10+
| Line | Lint | Before | After |
11+
|------|------|--------|-------|
12+
| 356 | `manual_div_ceil` | `(pos + 31) / 32 * 32` | `pos.div_ceil(32) * 32` |
13+
| 380 | `manual_range_patterns` | `4 \| 5 \| 6 =>` | `4..=6 =>` |
14+
| 398 | `manual_range_patterns` | `10 \| 11 \| 12 =>` | `10..=12 =>` |
15+
| 423 | `manual_div_ceil` | `(n + 31) / 32` | `n.div_ceil(32)` |
16+
17+
Note: lint_inventory.txt listed 3 sites (380, 398, 423); the 4th at line 356 was found in clippy_1.95_deny.log.
18+
19+
## Verification
20+
21+
`rustup run 1.95.0 cargo clippy --workspace --example gamma_phi_gguf -- -D warnings` exits 0.
22+
23+
The isolated `-p bgz-tensor` form fails due to a pre-existing ndarray issue: `plane.rs`, `seal.rs`, `merkle_tree.rs`, `vsa.rs` use `blake3` without `#[cfg(feature = "hpc-extras")]` guards, so they fail when ndarray is compiled with only `features = ["std"]`. This issue is not in scope for W7 and does not affect the workspace-level build (where lance-graph activates `hpc-extras` transitively).

crates/bgz-tensor/examples/bgz7_hydration_quality.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ fn main() {
6868
u32::from_le_bytes([data[pos], data[pos + 1], data[pos + 2], data[pos + 3]])
6969
as usize;
7070
pos += 4;
71-
let n_cols =
71+
let _n_cols =
7272
u32::from_le_bytes([data[pos], data[pos + 1], data[pos + 2], data[pos + 3]])
7373
as usize;
7474
pos += 4;

crates/bgz-tensor/examples/calibrate_from_jina.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ fn main() {
6161
] {
6262
match std::fs::read_to_string(path) {
6363
Ok(json) => {
64-
let text_refs: Vec<&str> = texts.iter().copied().collect();
64+
let text_refs: Vec<&str> = texts.to_vec();
6565
match bgz_tensor::jina::parse_jina_response(&json, &text_refs) {
6666
Ok(embs) => {
6767
println!("Loaded {} embeddings from {}", embs.len(), path);

crates/bgz-tensor/examples/fold_jina_embeddings.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ fn main() {
6565
};
6666
match std::fs::read_to_string(path) {
6767
Ok(json) => {
68-
let refs: Vec<&str> = text_slice.iter().copied().collect();
68+
let refs: Vec<&str> = text_slice.to_vec();
6969
match bgz_tensor::jina::parse_jina_response(&json, &refs) {
7070
Ok(embs) => {
7171
for e in embs {

0 commit comments

Comments
 (0)