Commit fe58dfc
committed
chore(contract): address #480 CodeRabbit review + add CI status badges
Follow-up on merged PR #480 (D-IDENTITY-1 Phase A).
Substantive:
- hhtl: focused from_packed edge-case test — depth>MAX_DEPTH and high-bits-set
rejection, (0,0)->EMPTY sentinel, the MAX_DEPTH boundary that exercises the
used_bits<64 guard (avoids >>64 UB), and packed o from_packed identity.
- plan: the stale "one open DECISION" line conflicted with the RESOLVED block
above it -> now a RESOLVED status line (decision landed in NodeGuid).
- plan: add the no-content-drift-for-existing invariant — an existing entity's
identity is a derived function of its ontology-mapped class, so it cannot
drift; the sole drift surface is an ontology cache not mapped from its
authoritative source, which is exactly what the shape_hash witness guards.
- AGENT_LOG: add the commit SHA to the D-IDENTITY-1 entry (traceability).
Cosmetic (markdownlint, the two new plan docs):
- MD040: language tag on the MAP1/MAP5 fenced diagrams.
- MD058: blank lines around the Layer 0-6 inventory tables.
- Skipped MD028 in LATEST_STATE: the blank line between board entries is the
file's append-only style; "fixing" one entry diverges it from all priors.
Tooling:
- README: native GitHub Actions status badges (Rust Tests / Style Check /
Build). Chose native badge URLs over the marketplace ci-badges action —
zero-config, no workflow step or write-back token, no maintenance surface.
600 contract lib tests (+1); clippy -D warnings --all-targets clean; fmt clean.
https://claude.ai/code/session_014A4JuRCqKP2yNENrQ9Ha7H1 parent 62bca5e commit fe58dfc
5 files changed
Lines changed: 63 additions & 5 deletions
File tree
- .claude
- board
- plans
- crates/lance-graph-contract/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
1 | 5 | | |
2 | 6 | | |
3 | | - | |
| 7 | + | |
4 | 8 | | |
5 | 9 | | |
6 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
| 90 | + | |
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
| |||
Lines changed: 20 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| |||
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
| 63 | + | |
62 | 64 | | |
63 | 65 | | |
64 | 66 | | |
| |||
67 | 69 | | |
68 | 70 | | |
69 | 71 | | |
| 72 | + | |
70 | 73 | | |
71 | 74 | | |
72 | 75 | | |
| |||
75 | 78 | | |
76 | 79 | | |
77 | 80 | | |
| 81 | + | |
78 | 82 | | |
79 | 83 | | |
80 | 84 | | |
81 | 85 | | |
82 | 86 | | |
83 | 87 | | |
| 88 | + | |
84 | 89 | | |
85 | 90 | | |
86 | 91 | | |
| |||
91 | 96 | | |
92 | 97 | | |
93 | 98 | | |
| 99 | + | |
94 | 100 | | |
95 | 101 | | |
96 | 102 | | |
| |||
100 | 106 | | |
101 | 107 | | |
102 | 108 | | |
| 109 | + | |
103 | 110 | | |
104 | 111 | | |
105 | 112 | | |
| |||
190 | 197 | | |
191 | 198 | | |
192 | 199 | | |
193 | | - | |
194 | | - | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
195 | 203 | | |
196 | 204 | | |
197 | 205 | | |
198 | 206 | | |
199 | 207 | | |
200 | 208 | | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
201 | 219 | | |
202 | 220 | | |
203 | 221 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
322 | 322 | | |
323 | 323 | | |
324 | 324 | | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
325 | 359 | | |
326 | 360 | | |
327 | 361 | | |
| |||
0 commit comments