ci: remove clippy from GitHub CI (local pre-check only)#241
Merged
Conversation
Clippy is an internal pre-check run locally per CODING_PRACTICES.md. GitHub CI focuses on compile + test + format + typos. Having clippy in the GitHub workflow made PRs look like a CI battlefield when the runner's toolchain components didn't match. Removed the clippy job from .github/workflows/style.yml. The local discipline (documented in CODING_PRACTICES.md "Mandatory cargo clippy + feature-matrix discipline") remains: cargo clippy --features lab -- -D warnings cargo clippy --features serve -- -D warnings https://claude.ai/code/session_01SbYsmmbPf9YQuYbHZN52Zh
ndarray is a custom fork (55 HPC modules, AMX tiles, jitson Cranelift JIT, 880+ tests) at ../../../ndarray relative to crates/lance-graph/. CI runners don't have the sibling repo cloned → cargo can't resolve the path dependency → build/test/clippy all fail. Fix: add `actions/checkout@v4` step for AdaWorldAPI/ndarray with `path: ../ndarray` in both rust-test.yml and build.yml. This places the checkout at $GITHUB_WORKSPACE/../ndarray which resolves correctly from the crate's Cargo.toml path = "../../../ndarray". NOT the fix Copilot suggested (replace with crates.io ndarray 0.15). That would lose the entire HPC foundation. https://claude.ai/code/session_01SbYsmmbPf9YQuYbHZN52Zh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
clippyjob from.github/workflows/style.yml. Clippy is our local pre-check (perCODING_PRACTICES.md§ "Mandatorycargo clippy+ feature-matrix discipline"), not CI — having it on GitHub made PRs look like a CI battlefield.Change
.github/workflows/style.yml— theclippy:job block (18 lines) replaced with a short comment pointing at the local discipline:The
format(rustfmt) andtypos(spell check) jobs stay. The separaterust-test.yml/build.yml/jc-proof.ymlworkflows continue to run compile + tests.Why
Clippy lints are aspirational — they evolve version-to-version and block merges when CI toolchain components drift from local dev toolchains. In contrast:
rust-test.yml) are non-negotiable blockersrustfmt --check) is deterministicRunning clippy on GitHub CI conflates "lint nit of the week" with "build broken" in the PR status UI. Moving it to local-only keeps the local pre-commit discipline strong without CI noise.
Test Plan
style.ymlYAML syntax validcargo clippy --features lab -- -D warningsstill runs clean locally (ran during PR Seal Wire DTOs with #[non_exhaustive] + recover Codex P2 + polyfill chain docs #240 verification)format+typosjobs unchangedhttps://claude.ai/code/session_01SbYsmmbPf9YQuYbHZN52Zh