epiphany(board): E-CONTRACT-NO-SERIALIZE — contracts compile types, membranes serialize#415
Merged
Merged
Conversation
…embranes serialize Records the architectural vow (user-stated via the medcare-rs consumer session): a contract / BBB-tier crate is a compile-time handshake (shared types + traits), not an outer serialization boundary. JSON emission belongs at the membrane, never on the contract surface. Names the concrete smell: `JsonlAuditSink` + `UnifiedBridge::with_jsonl_audit` in lance-graph-callcenter (a contract-tier crate) emitting JSONL. The `AuditSink` trait + `UnifiedAuditEvent` type are contract-appropriate; the concrete JSON sink should relocate to a membrane/sink crate. Build-time serde codegen (manifest.yaml -> generated types in build.rs) is fine. APPEND-ONLY board hygiene: prepended dated entry, no edits to prior entries. https://claude.ai/code/session_018FqA8TfgRBHy8zF92kx4TW
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new architectural epiphany entry was appended to the decision board documenting the principle that contract crates define compile-time type/trait handshakes, not serialization boundaries. JSON emission belongs at the membrane layer. The entry identifies a specific code smell in ChangesArchitectural Epiphany Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced May 27, 2026
AdaWorldAPI
added a commit
that referenced
this pull request
May 27, 2026
…serialize-refine epiphany(board): E-CONTRACT-NO-SERIALIZE-2 — correct #415, the audit event stays inside
AdaWorldAPI
added a commit
that referenced
this pull request
May 28, 2026
…serialize epiphany(board): E-CONTRACT-NO-SERIALIZE — contracts compile types, membranes serialize
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 28, 2026
…event stays inside #415 landed E-CONTRACT-NO-SERIALIZE with "serialize at the membrane" — the user sharpened it ("why should the audit event go outside?"): audit is not membrane traffic at all. It is a witness (merkle -> SPO + Lance tombstone), examined in place by the query engine; the merkle chain IS the tamper-evidence. No JSON by default; the sink is inner, not membrane; off-box copies are an infra concern, not the sink's standing behavior. Board is append-only: prepends a correction entry, leaves the prior entry intact. §1 (contracts compile types, never serialize) stands. https://claude.ai/code/session_018FqA8TfgRBHy8zF92kx4TW
AdaWorldAPI
added a commit
that referenced
this pull request
May 28, 2026
…serialize-refine epiphany(board): E-CONTRACT-NO-SERIALIZE-2 — correct #415, the audit event stays inside
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepends an APPEND-ONLY board entry E-CONTRACT-NO-SERIALIZE recording the architectural vow surfaced via the medcare-rs consumer session:
Names the concrete smell it targets:
JsonlAuditSink+UnifiedBridge::with_jsonl_auditliving inlance-graph-callcenter(a contract-tier crate) emitting JSONL. TheAuditSinktrait +UnifiedAuditEventtype stay; the proposed direction is to relocate the concrete JSON sink into a membrane/sink crate. Build-time serde codegen (build.rsparsingmanifest.yaml→ generated types, #412) is explicitly not a violation — that IS "compile types."Board-hygiene: prepended a dated entry, no edits to prior entries. No code change — this is a recorded finding/vow for the next session that touches the audit-sink surface. Cross-references medcare-rs
CLAUDE.mdcommitment #7.Test plan
https://claude.ai/code/session_018FqA8TfgRBHy8zF92kx4TW
Generated by Claude Code
Summary by CodeRabbit