docs(unified-soa): PR #434 post-merge review addendum + governance status flip#486
Merged
Merged
Conversation
…atus flip Post-merge governance + review-pass on PR #434 (`unified-soa-convergence-v1`, merged 2026-05-29 18:38:43Z, `1186dfd3`). Branch `claude/lance-graph-ontology-review-Pyry3` rebased onto main (fast-forward, 27 commits absorbed, already pushed). `unified-soa-convergence-v1.md`: - §9 Phase P0 "Status: in PR (this one)" → "SHIPPED in PR #434 (merged 2026-05-29; see post-merge review addendum)". - §15 PRs "PR (this one)" → "PR #434 — ... (shipped 2026-05-29)". The §1 / §11 user-stated rulings (`E-SOA-IS-THE-ONLY` + refinements) are council-bypassed author-stated content per §16 — NOT edited. `.claude/plans/unified-soa-convergence-v1-addendum-2026-05-29-review.md` (156 lines). Captures three clarification-grade findings without touching ruling text: 1. §3.2 per-row total math — the "~30 B" figure is the D-MBX-A1 shipped subset; after A2/A3 land at default `W=16` (OQ-11.2), per-row bare total grows to ≈101 B. The ~6 KB/thought ceiling is dominated by the 3 × `[u64; 256]` identity planes either way, so §3.2 capacity math (64k–256k thoughts at 300–600 MB / 1.2–2.4 GB) stands. 2. §4.2 stack table gap — covers arrow/datafusion/lance/lancedb/ndarray but omits surrealdb even though §4.3 + D-MBX-9 + OQ-11.6 hinge on a SurrealDB fork pin (`kv-lance` backend). Addendum proposes one extra row marked BLOCKED — OQ-11.6. 3. §4.2 verification re-checked independently — `arrow = "58"` (4 files), `datafusion = "53"` (3 files), `lance = "=6.0.0"` (5 files), `lancedb = "=0.29.0"` (1 file). D-MBX-11 is mechanical. - `INTEGRATION_PLANS.md` — flip 2026-05-29 unified-soa entry `Status: PROPOSAL` → `SHIPPED (PR #434, `1186dfd3`)`. - `STATUS_BOARD.md` — add explicit `Plan P0 status: SHIPPED in PR #434` callout under the unified-soa section header. - `PR_ARC_INVENTORY.md` — PREPEND new `## #434` section with Added / Locked / Deferred / Docs / Confidence (`2026-05-29`). - `LATEST_STATE.md` — refresh `Last updated` header line to lead with PR #434 (was 2026-05-14 / PR #372, two weeks stale). - `TECH_DEBT.md` — PREPEND `TD-CLAUDE-MD-DEPS-DRIFT` (P3): `CLAUDE.md` "Key Dependencies" still lists `arrow = "57"` / `datafusion = "51"` / `lance = "2"` (drift from 2026-04-21). Flagged for a separate focused PR — not fixed here (workspace-wide doctrine, wrong altitude for a drive-by edit). - `AGENT_LOG.md` — PREPEND entry recording this review run. - No source code changes (docs/board only, same as #434). - `cargo` prohibited per session-stability constraint (same as #434). - Council bypass preserved for the §11 rulings; spec content (this PR) remains open to council review.
|
Warning Review limit reached
More reviews will be available in 57 minutes and 31 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Session-end handover doc capturing what shipped (14 PRs across 4 repos in the splat-native-ultrasound-v1 + cesium-osm-substrate-v1 arcs + ADR-024 adoption), what's outstanding (4 decision tables — substrate- addressing-v1 unblock criteria; Tier-1 cross-session asks status; user-ratification OQs; the today-opened unified-soa addendum PR), and the architectural pins worth citing by name (E-SOA-IS-THE-ONLY, ADR-024, NR-SPLAT-PHI, Q3 Y-flip, MDR Annex VIII Rule 11). Drop-in for the next session: read .claude/BOOT.md → this file → the four decision tables, then act.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b7e316354
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+54
to
+57
| | `lance = "=6.0.0"` | `crates/lance-graph/Cargo.toml:38` | ✓ | also at benches:10, callcenter:30, ontology:46, holograph:38 — **5 files, matches §4.2 D-MBX-11 scope** | | ||
| | `lancedb = "=0.29.0"` | `crates/lance-graph/Cargo.toml:41` | ✓ | only declared in `lance-graph` | | ||
|
|
||
| **D-MBX-11 readiness:** confirmed mechanical 5-file edit (`=6.0.0` → `=6.0.1`). When cargo prohibition lifts, one `cargo check` per crate gates the bump. |
There was a problem hiding this comment.
This “independently re-checked” table is stale after the rebase: at this commit, crates/lance-graph/Cargo.toml:38 is lance = "=7.0.0", crates/lance-graph/Cargo.toml:41 is lancedb = "=0.30.0", and the other listed Lance consumers are also on =7.0.0. Marking =6.0.0/=0.29.0 as verified and saying D-MBX-11 is a mechanical =6.0.1 bump will send future governance/implementation work toward an obsolete downgrade path.
Useful? React with 👍 / 👎.
| > **Auto-injected at session start via SessionStart hook.** | ||
| > Updated after every merged PR. | ||
| > **Last updated:** 2026-05-14 (PR #372 merged: sprint-10 spec sprint, 12-worker CCA2A fleet + Opus meta-review + 8 knowledge docs, governance-only (zero .rs changes), mirrors PR #365 pattern. Sprint-11 implementation wave gated on 5 spec patches + 4 user ratifications: CSI-1 CausalEdge64 bit-reclaim Option, OQ-1 Σ4-Σ5 banding, OQ-3 plasticity granularity, OQ-5 rayon vendor. **Major findings:** (1) dual `CausalEdge64` types in workspace — `causal_edge::CausalEdge64` SPO-palette layout ≠ `thinking_engine::layered::CausalEdge64` 8-channel cascade, same name different semantics, surfaced as duplication entry #13 in TYPE_DUPLICATION_MAP and E-META-7 in EPIPHANIES; (2) p64 drift origin pinpointed at `crates/lance-graph-planner/src/cache/convergence.rs:18-22 #[allow(unused_imports)]` annotation — wiring intended for hot-path convergence never finished; (3) three-zone hot-path mental model corrects prior framing — Zone-1 thinking-engine MatVec 200-500ns + AriGraph entity_index O(1) ~20-200ns is the actual cycle-speed path, not DataFusion. Prior: 2026-05-13 (PR #366 merged: sprint-7 7-worker implementation wave for the sprint-5/6 specs + AuditSink trait unification, ~5 KLOC across 5 crates +2 new (`lance-graph-supervisor`, `lance-graph-consumer-conformance`), ~70 new tests, workspace clippy --tests --no-deps -D warnings exits 0; Opus meta verdict 4A/2B/1B-minus; OQ-7-1/2/3 all locked pre-merge; `UnifiedAuditSink` D-SDR-4 placeholder dropped, all sinks unified on `AuditSink` trait; `UnifiedBridge::with_jsonl_audit()` ergonomic constructor added for MedCare-rs sprint-2 item 5. **Adjacent landings (same day):** MedCare-rs sprint-1 10-PR sweep (#113-#122) including E1-1 OQ-3 direct migration (6 RoleGroups) consuming our `0d725d4` decision. MedCare-rs sprint-2 (5 PRs) is queued on user "go" — item 5 consumes this PR's new constructor. Prior same-day: PR #365 (13 sprint-5/6 specs + meta). Prior: PR #364 (D-SDR-3/4/5 + sprint-log-4 governance + sprint-5-9 roadmap + codex P1/P2 fixes). lance-graph #364 ships D-SDR-3/4/5 + sprint-log-4 governance + sprint-5-9 roadmap + codex P1/P2 surgical fixes (OwlIdentity 3-byte canonical, UnifiedAuditEvent 26 bytes, OgitFamilyTable sparse `HashMap<u16, FamilyEntry>`, audit super_domain via AuditChain). MedCare-rs#112 (PR-B) wires `UnifiedBridge<MedcareBridge>` + medcare-rbac + medcare-realtime substrate (+2963 LOC, 17 files, §73 SGB V + BMV-Ä §57 + BtM regulatory tests). smb-office-rs#31 (PR-C) wires `UnifiedBridge<OgitBridge>` (+111 LOC). ndarray#142 ships VBMI gate for `permute_bytes` (P0 SIGILL fix on Skylake-X / Cascade Lake / Ice Lake-SP) + Inf clamp for `simd_exp_f32`. D-SDR-5 `UnifiedBridge` surface is now consumed end-to-end across MedCare + smb-office. Prior: 2026-05-07 (PR #354). Prior: 2026-05-07 (PR #353). Prior: 2026-05-07 (PR #352). Prior: 2026-05-06 (splat-osint-ingestion-v1 PR 1+2 of 6 in flight). Prior: 2026-04-21 post PR #243. | ||
| > **Last updated:** 2026-05-29 (PR #434 merged: `unified-soa-convergence-v1` integration plan + handover, **docs-only, +1 004 lines, zero source code**, `cargo` prohibited per session-stability constraint). Records the **5 layered user-stated rulings** ratified in session `017GFLBn` as `E-SOA-IS-THE-ONLY` (council-bypassed per §16 — author-stated): (R1) ONE SoA, never transformed, only 3 ops allowed; (R2) mailbox = full BindSpace as LE-contract types, witness = the per-row `CausalEdge64` emission arc (no separate revision log); (R3) **Libet −550 ms** anchors the Σ10 Rubicon commit, 4-phase kanban (Planning → Cognitive work → Evaluation → Commit · Plan · Prune) lives in `surrealkv`-on-lance (SurrealDB is a view, LanceDB stays leading storage); (R4) SPO-W witness = pointer into the AriGraph episodic Markov chain (the chain IS the index space); (R5) counterfactual Staunen × Wisdom = plasticity spreaders (Hebbian, Planning-gated, hot-path-only). **Scope:** sequences 12 new deliverables (D-MBX-A2/A3/A4/A5/A6 + 7/8/9/10/11/12) across the 9 half-baked consumers (AriGraph · Vsa16k substrate audit · BindSpace dissolution · lance-graph cold containers · lance-graph-planner DTO overhaul · cognitive-shader-driver column completion · lance-graph-callcenter · lance-graph-ontology AS IS · thinking-styles/atoms). **Stack pin verified 2026-05-29 (and independently re-verified on `claude/lance-graph-ontology-review-Pyry3`):** arrow `"58"` ✓ · datafusion `"53"` ✓ · lancedb `"=0.29.0"` ✓ · lance `"=6.0.0" → "=6.0.1"` (one mechanical patch bump pending across 5 Cargo.toml files; D-MBX-11). **Post-merge review** in `.claude/plans/unified-soa-convergence-v1-addendum-2026-05-29-review.md` adds: §3.2 per-row total clarification (the ~30 B figure = shipped-today subset; ~101 B after A2/A3 land at default `W=16`; the ~6 KB/thought ceiling is dominated by the 3 × `[u64; 256]` identity planes either way), §4.2 missing surrealdb-fork pin row (BLOCKED on OQ-11.6), and flags **CLAUDE.md "Key Dependencies" drift** (still says `arrow = "57"` / `datafusion = "51"` / `lance = "2"`) as `TD-CLAUDE-MD-DEPS-DRIFT` for a separate focused PR. **Open questions** OQ-11.1 … OQ-11.8 await user ratification (default proposals in §11). **Adjacent:** PR #433 (style_recipe D-Atom + epiphany-brainstorm-council + 5 savant cards, shipped 2026-05-29 13:05); PR #432 (Foundry-shape emitters, shipped 2026-05-29 11:35); PR #429 (gobd_company fix, shipped). Prior: 2026-05-14 (PR #372 merged: sprint-10 spec sprint, 12-worker CCA2A fleet + Opus meta-review + 8 knowledge docs, governance-only (zero .rs changes), mirrors PR #365 pattern. Sprint-11 implementation wave gated on 5 spec patches + 4 user ratifications: CSI-1 CausalEdge64 bit-reclaim Option, OQ-1 Σ4-Σ5 banding, OQ-3 plasticity granularity, OQ-5 rayon vendor. **Major findings:** (1) dual `CausalEdge64` types in workspace — `causal_edge::CausalEdge64` SPO-palette layout ≠ `thinking_engine::layered::CausalEdge64` 8-channel cascade, same name different semantics, surfaced as duplication entry #13 in TYPE_DUPLICATION_MAP and E-META-7 in EPIPHANIES; (2) p64 drift origin pinpointed at `crates/lance-graph-planner/src/cache/convergence.rs:18-22 #[allow(unused_imports)]` annotation — wiring intended for hot-path convergence never finished; (3) three-zone hot-path mental model corrects prior framing — Zone-1 thinking-engine MatVec 200-500ns + AriGraph entity_index O(1) ~20-200ns is the actual cycle-speed path, not DataFusion. Prior: 2026-05-13 (PR #366 merged: sprint-7 7-worker implementation wave for the sprint-5/6 specs + AuditSink trait unification, ~5 KLOC across 5 crates +2 new (`lance-graph-supervisor`, `lance-graph-consumer-conformance`), ~70 new tests, workspace clippy --tests --no-deps -D warnings exits 0; Opus meta verdict 4A/2B/1B-minus; OQ-7-1/2/3 all locked pre-merge; `UnifiedAuditSink` D-SDR-4 placeholder dropped, all sinks unified on `AuditSink` trait; `UnifiedBridge::with_jsonl_audit()` ergonomic constructor added for MedCare-rs sprint-2 item 5. **Adjacent landings (same day):** MedCare-rs sprint-1 10-PR sweep (#113-#122) including E1-1 OQ-3 direct migration (6 RoleGroups) consuming our `0d725d4` decision. MedCare-rs sprint-2 (5 PRs) is queued on user "go" — item 5 consumes this PR's new constructor. Prior same-day: PR #365 (13 sprint-5/6 specs + meta). Prior: PR #364 (D-SDR-3/4/5 + sprint-log-4 governance + sprint-5-9 roadmap + codex P1/P2 fixes). lance-graph #364 ships D-SDR-3/4/5 + sprint-log-4 governance + sprint-5-9 roadmap + codex P1/P2 surgical fixes (OwlIdentity 3-byte canonical, UnifiedAuditEvent 26 bytes, OgitFamilyTable sparse `HashMap<u16, FamilyEntry>`, audit super_domain via AuditChain). MedCare-rs#112 (PR-B) wires `UnifiedBridge<MedcareBridge>` + medcare-rbac + medcare-realtime substrate (+2963 LOC, 17 files, §73 SGB V + BMV-Ä §57 + BtM regulatory tests). smb-office-rs#31 (PR-C) wires `UnifiedBridge<OgitBridge>` (+111 LOC). ndarray#142 ships VBMI gate for `permute_bytes` (P0 SIGILL fix on Skylake-X / Cascade Lake / Ice Lake-SP) + Inf clamp for `simd_exp_f32`. D-SDR-5 `UnifiedBridge` surface is now consumed end-to-end across MedCare + smb-office. Prior: 2026-05-07 (PR #354). Prior: 2026-05-07 (PR #353). Prior: 2026-05-07 (PR #352). Prior: 2026-05-06 (splat-osint-ingestion-v1 PR 1+2 of 6 in flight). Prior: 2026-04-21 post PR #243. |
There was a problem hiding this comment.
This auto-injected file says it is updated after every merged PR, but the new header resets “Last updated” to 2026-05-29/#434 even though the same file already records later shipped work, including the 2026-06-03 helix entries and PR #459 in the reverse-chronological table. If this lands after those merges, new sessions that read this first line will treat #434 as the current state and miss the later governance decisions; keep the header on the newest shipped PR and add #434 only as historical context.
Useful? React with 👍 / 👎.
Surveyed PRs #471-#487. Three landed that materially affect my outstanding ask list: - #482 (merged): GUID canon + prefix routing knowledge doc — pins TWO-ALGEBRA RULE (sign=XOR, magnitude=bundle, never MergeMode::Xor) + helix CurveRuler stride-4-over-17 as bit-exact integer phase generator. Both are load-bearing receipts for substrate-addressing-v1. - #484 (merged): D-IDENTITY-2 ships entity_type↔NiblePath bijection in lance-graph-ontology registry. RESOLVES the Tier-1 'NiblePath scheme for FMA classes' ask — OGAR Phase 8 calls register_class_path() per FMA Class. - #485 (OPEN): PROBE-MANTISSA-FILL + PROBE-PHASE-1 both GREEN. The golden-mantissa placement leg of the substrate-addressing claim is now measured (not asserted): beats seeded random by ~30% at k=256 + half worst-case pile-up. CurveRuler bit-exactness verified over 20 path/depth pairs. Updated Decision 1 trigger: substrate-addressing-v1.md now files after #485 merges (not after D-HELIX-1 owner ping — they're actively probing). D-CESIUM-1 (mine — extend implicit_tiling.rs to consume helix::bounds) is the file-soonest deliverable. D-JC-1 still needs per-scene-class p calibration timeline.
…ale LATEST_STATE reset) Addresses two codex P2 findings on the rebased #486 (the unified-soa addendum that surfaced from early-session work after ~80 commits on main). ## Fix 1 — Lance stack versions post-rebase (codex P2) Original addendum's §4.2 "Dep-version verification" table cited `lance = "=6.0.0"` / `lancedb = "=0.29.0"` per the state at PR #434 merge (2026-05-29). The Lance family has since bumped to `=7.0.0` / `=0.30.0` (verified in current `crates/lance-graph/Cargo.toml:38,41` + `lance-linalg = "=7.0.0"`). Updates the table to current state with explicit "post-rebase" / "updated since author-time" annotations so the row reads as a historical record + current verification, not a stale verification. `D-MBX-11`'s "mechanical patch bump pending across 5 Cargo.toml files" is now noted as superseded — main has moved past `=6.0.1` straight to `=7.0.0`. ## Fix 2 — LATEST_STATE.md "Last updated" reset (codex P2) Original commit `5b7e3163` prepended a new "Last updated: 2026-05-29 (PR #434...)" entry to LATEST_STATE.md. After rebase onto current main, this addendum PR is the WRONG vehicle to take over the "Last updated" line — the file's contract is "updated after every merged PR" and this PR is not the latest-shipped PR; it's an addendum to a long-merged one. Reverts the LATEST_STATE.md edit entirely; whoever does the next post-merge board hygiene sweep on a current PR will refresh the line properly. ## What's still in this PR - `.claude/plans/unified-soa-convergence-v1.md` — §9 Phase P0 status flip + §15 PRs row update (the actual content of the addendum). - `.claude/plans/unified-soa-convergence-v1-addendum-2026-05-29-review.md` (new) — three findings (now with corrected §4.2 dep-version state). - `.claude/board/AGENT_LOG.md` — PREPEND entry recording the rebase + review run. Kept (append-only governance log; the entry's content is still factually accurate even post-rebase). - `.claude/board/INTEGRATION_PLANS.md` + `STATUS_BOARD.md` + `PR_ARC_INVENTORY.md` — minor governance edits. Kept (still factually correct; not the "Last updated" overwrite problem that LATEST_STATE.md had). ## Test plan - [x] LATEST_STATE.md restored to origin/main state (no diff). - [x] §4.2 dep-version table reflects current Cargo.toml. - [x] Other board entries (AGENT_LOG / INTEGRATION_PLANS / STATUS_BOARD / PR_ARC_INVENTORY) preserved — they're append-only logs whose entries are still factually accurate even after rebase. - [ ] Codex re-review on this commit.
AdaWorldAPI
pushed a commit
that referenced
this pull request
Jun 12, 2026
…conflicts Board prepend zones (AGENT_LOG, EPIPHANIES) auto-merged; no semantic overlap — main-side additions (#485 helix probe, #486 docs) reference none of the tombstoned emission identifiers (verified by grep: only intentional historical mentions in comments remain). https://claude.ai/code/session_01PBTGaPCSnnt6u3pjXpbLwY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Long-pending session work resurfaced via Pyry3-branch rebase. Original commit
2bdb3ee3from early-session (2026-05-29 area) was rebased onto current main (5363f436) as5b7e3163— no rebase conflicts despite ~80 main-side commits touching adjacent board files.The addendum is a post-merge review pass on PR #434 (
unified-soa-convergence-v1, merged 2026-05-29). Three clarification-grade findings; no ruling text edited (per §16 council-bypass on §1 / §11 author-stated rulings).What this PR ships
.claude/plans/unified-soa-convergence-v1.md— §9 Phase P0 status flip ("in PR (this one)" → "SHIPPED in PR docs: unified-soa-convergence-v1 integration plan + handover (ONE SoA end-to-end, 9 consumers, Libet −550 ms kanban, Lance 6.0.1 stack) #434"); §15 PRs row update..claude/plans/unified-soa-convergence-v1-addendum-2026-05-29-review.md(new, 156 lines) — three findings:W=16(OQ-11.2), per-row total grows to ~101 B. The ~6 KB/thought ceiling is dominated by the 3 ×[u64; 256]identity planes either way, so §3.2 capacity math (64k–256k thoughts at 300–600 MB / 1.2–2.4 GB) stands.kv-lancebackend). Addendum proposes one extra row marked BLOCKED — OQ-11.6.arrow = "58"(4 files),datafusion = "53"(3 files),lance = "=6.0.0"(5 files),lancedb = "=0.29.0".Why now (rebase context)
This commit sat unpushed on
claude/lance-graph-ontology-review-Pyry3for the duration of the splat-native + cesium-osm arcs (~75 main-side merges). Today's "rebase and check" pass surfaced it as the only local-only commit; rebase was clean because the board files prepend (not edit) past entries. Opening the PR now so the addendum either ships or gets an explicit reject — leaving it on the branch indefinitely is the worse option per workspace board hygiene rule (governance entries shouldn't lag merged PRs).The board entries it adds are 80+ commits stale as a snapshot. If reviewer prefers, the board-file portion can be dropped and only the two plan-file edits kept — happy to scope down in review.
What this PR does NOT do
Test plan
5363f436); no conflicts.Resurfaced from session
claude/lance-graph-ontology-review-Pyry3during a rebase pass after the splat-native + cesium-osm arc merged.