forked from lance-format/lance-graph
-
Notifications
You must be signed in to change notification settings - Fork 0
ndarray-SIMD consumer integration: turbovec ANN bridge + bgz17 AVX-512 + blasgraph Hamming dedup #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ndarray-SIMD consumer integration: turbovec ANN bridge + bgz17 AVX-512 + blasgraph Hamming dedup #493
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a2c2d09
feat(lance-graph-turbovec): TurboQuant ANN index bridged onto the spine
claude cfb530b
fix(bgz17): real AVX-512 arm for batch_palette_distance (was silently…
claude 0eaaa86
refactor(blasgraph): route Hamming/popcount through ndarray::hpc::bit…
claude e770a7c
Merge remote-tracking branch 'origin/main' into claude/wonderful-hawk…
claude 31d7757
fix(blasgraph): silence dead_code for scalar Hamming fallback under n…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On AVX-512 hosts this newly enabled path runs for candidate batches of at least 16. Because each lane performs a 32-bit gather from a
u16row and then masks off the high half, a lookup for the final entry of the final row (for examplequery == k - 1andcandidate == k - 1) reads two bytes pastdm_data; the previous scalar fallback did not. This can fault at a page boundary or invoke UB despite only using the low 16 bits, so the boundary entry needs scalar handling/padding or a true 16-bit-safe load path.Useful? React with 👍 / 👎.