fix(plans)+test: #500 review — OCR rides Full not Compressed; OCR-RT gate exact#502
Conversation
…gate is exact Two review threads on the merged #500: - codex P2: "post-POC OCR rides Compressed" was wrong — Compressed lacks Energy+Plasticity, so the schema-gated transcode would silently drop confidence (→Energy) and repair-provenance (→Plasticity). Corrected: OCR rides Full (the only preset with the codec residues AND the hot lifecycle columns). The OCR-SCHEMA contract test now asserts Compressed lacks Energy/Plasticity (regression guard). - CodeRabbit Major: OCR-RT reversibility gate tightened 99% → 100% exact (a lossy residue→rank map is NOT "reversible"; tolerance moved to a separate quality probe). https://claude.ai/code/session_01D2WSmezQBNC3bUdHuGfGmo
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR corrects the OCR integration plan to specify ChangesOCR Preset Correction and Probe Tightening
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d65dcb758c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Full`) and writing only the tenants it populates. Post-POC, OCR rides **`Full`** — | ||
| the only existing preset carrying the codec residues (HelixResidue + TurbovecResidue) | ||
| AND the hot columns the §4 writeback needs (Energy for confidence, Plasticity for the | ||
| repair stamp). `Compressed` lacks Energy/Plasticity and `Cognitive` lacks the | ||
| residues, so neither fits OCR (codex P2 on #500). A leaner OCR row would need an |
There was a problem hiding this comment.
Align stale Compressed references with Full requirement
This correction now says post-POC OCR must ride Full because Compressed lacks Energy/Plasticity, but the same plan still tells implementers in §2 and the D-OCR-51 deliverable to use Full POC / Compressed. If the D-OCR-51 work follows those checklist lines, it can reintroduce the exact data-loss path this change is guarding against by selecting Compressed and dropping confidence/repair provenance, so the remaining summaries should be updated to Full or an operator-minted preset.
Useful? React with 👍 / 👎.
Addresses the two open review threads on the merged #500.
Compressed" — butCompressedlacksEnergy+Plasticity, so the schema-gatedLayoutBlock::to_node_rowwould silently drop confidence (→Energy) and repair-provenance (→Plasticity). Corrected: OCR ridesFull(the only existing preset with the codec residues AND the hot lifecycle columns). The OCR-SCHEMA contract test now assertsCompressedlacksEnergy/Plasticity(regression guard) so this can't silently regress.≥ 99 %— a lossyresidue→rankmap is not "reversible", so the gate is tightened to 100 % exact; any single miss fails it, and tolerance is moved to a separate quality probe.ocr-canonical-soa-integration-v1.md+ocr-probes-v1.md+ the contract test updated. contract lib green; fmt clean.https://claude.ai/code/session_01D2WSmezQBNC3bUdHuGfGmo
Generated by Claude Code
Summary by CodeRabbit
Release Notes
Documentation
Tests