Skip to content

fix(bgz-tensor): resolve 5 CI-invisible test failures (3 stale tests + 1 slice-bounds bug) #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdaWorldAPI merged 1 commit into from
Jun 16, 2026
Merged

fix(bgz-tensor): resolve 5 CI-invisible test failures (3 stale tests + 1 slice-bounds bug) #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/bgz-tensor/src/gamma_calibration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ mod tests {

#[test]
fn calibration_profile_size() {
assert_eq!(CalibrationProfile::byte_size(), 40); // 28 + 12
assert_eq!(CalibrationProfile::byte_size(), 48); // RoleGamma 36 + CosineGamma 12
}

#[test]
Expand Down
4 changes: 2 additions & 2 deletions crates/bgz-tensor/src/hhtl_cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,8 +630,8 @@ mod tests {
cache.serialize(path).expect("serialize");

let size = std::fs::metadata(path).map(|m| m.len()).unwrap_or(0);
// 4 magic + 2 k + 256×34 entries + 256×256×2 distances + 256×256×1 routes + 256×4 radii
let expected = 4 + 2 + 256 * 34 + 256 * 256 * 2 + 256 * 256 + 256 * 4;
// 4 magic + 2 k + 256×34 entries + 256×256×2 distances + 256×256×1 routes + 256×4 radii + 16 gamma_meta
let expected = 4 + 2 + 256 * 34 + 256 * 256 * 2 + 256 * 256 + 256 * 4 + 16;
assert_eq!(
size, expected as u64,
"expected {expected} bytes, got {size}"
Expand Down
2 changes: 1 addition & 1 deletion crates/bgz-tensor/src/hhtl_d.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ mod tests {

#[test]
fn hhtl_d_entry_roundtrip() {
let entry = HhtlDEntry::new(HeelBasin::Gate, 7, 42, true, 0x3C00); // BF16 1.0
let entry = HhtlDEntry::new(HeelBasin::Gate, 7, 42, true, 0x3F80); // BF16 1.0 (0x3F80, not the F16 0x3C00)
let bytes = entry.to_le_bytes();
let decoded = HhtlDEntry::from_le_bytes(&bytes);

Expand Down
7 changes: 5 additions & 2 deletions crates/bgz-tensor/src/matryoshka.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ pub fn encode_row(row: &[f32], basis: &SvdBasis, profile: &BandProfile) -> Matry

for band in &profile.bands {
let max_val = band.precision.max_val();
let band_coeffs = &coeffs[band.start..band.end.min(coeffs.len())];
let band_coeffs = &coeffs[band.start.min(coeffs.len())..band.end.min(coeffs.len())];

// Find scale for this band
let band_max = band_coeffs
Expand Down Expand Up @@ -552,7 +552,10 @@ pub fn decode_row(encoded: &MatryoshkaRow, basis: &SvdBasis, profile: &BandProfi
offset += 2;
let inv_scale = band_max / max_val as f32;

let n = band.n_components();
// Cap to the coeff buffer: the basis rank can be lower than the
// profile's nominal max (e.g. fewer sample rows than requested
// components), so a band may extend past the available coeffs.
let n = band.n_components().min(coeffs.len().saturating_sub(band.start));

match band.precision {
BandPrecision::I16 => {
Expand Down
Loading