E-OGAR-IS-FOUNDRY: Foundry/Gotham = OGAR class schema inheritance + 5+3 council corrections + the key→row baton

[AdaWorldAPI]

The capstone

Being Palantir Foundry / Gotham reduces to "write the OGAR class schema + inheritance." Every other layer is generic machinery already in the workspace, parameterized only by classid:

Foundry/Gotham layer	OGAR primitive
Ontology (types + links)	OGAR class schema + inheritance (classid → ClassView, effective_actions)
Objects + links	GUID node + EdgeBlock edge (E-GUID-IS-THE-GRAPH)
AR object behavior	DO vs THINK = Active Record (ActionDef vs MethodSig)
Pipelines / transforms	compute_dag topological recompute
Apps / low-code	Jinja/templates over OGAR classes (class_id → OGIT ontology seam, soa_view.rs:57)
Query / traversal	Cypher ⇄ SurrealQL, one shared IR

Captured as E-OGAR-IS-FOUNDRY. The superpower is the reduction: declare a schema, the platform behaviors fall out over the shared AST.

5+3 council (8/8 reported) — applied to cypher-kanban-ast-unification-v1

Core thesis SOUND (convergence-architect: StepDomain::Kanban exists; all 4 polyglot parsers already return one PlanInput/QueryFeatures IR — 3 of 4 sides are genuinely one IR). Corrections applied this PR:

• CATCH-CRITICAL (baton-auditor): MailboxSoaView had no key→row resolver — the Backend::MailboxSoa router literally couldn't be written. Added row_for_local_key(local_key) -> Option<usize> as a deferred-binding default-None method (matches the qualia/episodic_witness deferral pattern); an owner that stores keys overrides it. +1 test, clippy clean.
• from_guid_prefix is on NiblePath (hhtl.rs:262), not NodeGuid — corrected in epiphany + plan.
• "odoo existence proof" downgraded FINDING→CONJECTURE (truth-architect + archaeologist): it's a tagged const ActionDef + classify_odoo, not a running traversal; ogar-adapter-surrealql is not a crate (it's surreal_container::SurrealStore, a BLOCKED(C) stub).
• Headline demoted (dilution-sentinel): "four sides of one AST" → "one IR, four relationships".
• Resequenced (integration-lead): first shippable = Inc 0 + F1/F2 on the Native path; Inc 1 (Cypher→SurrealQL) is dependency-on lite-unified's OQ-LU-2, not a duplicate.
• Three boundaries pinned (ripple-architect): edge-rep is classid-resolved not query-guessed; domain-board schema ≠ KanbanColumn; board mutation routes through the DO-arm guard chain (RBAC→state-guard→MUL), not raw edge-rewrite.

Files

• crates/lance-graph-contract/src/soa_view.rs — MailboxSoaView::row_for_local_key (the named dropped baton) + test.
• .claude/board/EPIPHANIES.md — E-OGAR-IS-FOUNDRY + council corrections on E-CYPHER-IS-THE-KANBAN-AST.
• .claude/plans/cypher-kanban-ast-unification-v1.md — plan + the 5+3 verdict/revisions.

Scope honest: the reduction is the architecture; the wiring (Backend::MailboxSoa, Cypher→SurrealQL behind lite-unified, q2 consumer) is the plan's increments. This PR lands the one council-endorsed buildable prerequisite + the doctrine.

🤖 Generated with Claude Code

---

Generated by Claude Code

Summary by CodeRabbit

• Documentation

  • Updated architecture and integration planning documentation with refined design approach and scope clarifications.

• Tests

  • Added test coverage for new infrastructure component supporting graph operations.

[coderabbitai]

Warning

Review limit reached

@AdaWorldAPI, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 46 minutes and 45 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d0ac020-485d-4f59-b443-f233ccf7150c

📥 Commits

Reviewing files that changed from the base of the PR and between dd731bd and ebe9aa7.

📒 Files selected for processing (1)

• .claude/plans/cypher-kanban-ast-unification-v1.md

📝 Walkthrough

Walkthrough

Adds three architecture epiphany entries and a new cypher-kanban-ast-unification-v1 plan document describing how the kanban board AST maps to Cypher over the GUID-keyed substrate. Delivers the plan's council-mandated first increment: a row_for_local_key(local_key: u64) -> Option<usize> default-None method on the MailboxSoaView trait, with a unit test for the default behavior.

Changes

Cypher-Kanban AST Unification: plan and first increment

Layer / File(s)	Summary
Architecture epiphanies and unification plan .claude/board/EPIPHANIES.md, .claude/board/INTEGRATION_PLANS.md, .claude/plans/cypher-kanban-ast-unification-v1.md	Adds three epiphanies (E-OGAR-IS-FOUNDRY, E-CYPHER-IS-THE-KANBAN-AST, E-GUID-IS-THE-GRAPH) and the full cypher-kanban-ast-unification-v1 plan, defining the GUID↔graph mapping, Inc 0–3 deliverables, falsification gates F1–F5, scope guards, and council verdict revisions including the row_for_local_key contract as the net first increment.
MailboxSoaView::row_for_local_key contract and test crates/lance-graph-contract/src/soa_view.rs	Adds row_for_local_key(local_key: u64) -> Option<usize> with a documented default-None body to the MailboxSoaView trait, plus a unit test asserting the FakeSoa returns None for arbitrary keys where no key index is materialized.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• AdaWorldAPI/lance-graph#437: Introduced or defined the MailboxSoaView trait in the same file (crates/lance-graph-contract/src/soa_view.rs) that this PR extends with row_for_local_key.

Poem

🐇 A key without a row once left me in the dark,
But row_for_local_key now sparks a None remark.
The GUID is the graph, the Cypher is the AST—
Four epiphanies bloomed like clover, wild and free.
With gates and guards the council kept it tight,
One Option<usize> stub to start us right! 🌿

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main architectural contribution: E-OGAR-IS-FOUNDRY epiphany plus the critical key→row resolver addition, capturing both the conceptual advance and the concrete code change.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.claude/plans/cypher-kanban-ast-unification-v1.md:
- Around line 42-43: The statement about odoo ontology traversal at lines 42-43
is currently presented as a definitive existence proof ("already runs", "the
existence proof"), but the verdict section below correctly identifies this as
conjecture pending the executor arm. Soften the language in this claim to remove
the implication of proven fact, using more tentative phrasing such as "suggests"
or "appears to demonstrate" instead of definitive assertions like "already runs"
and "existence proof". This will align the introduction with the actual status
documented in the verdict section.
- Around line 47-68: The Inc 0 and Inc 2 sections in the plan contain references
to `NodeGuid::{from_guid_prefix, local_key}` and
`KanbanColumn::can_transition_to}` that are outdated. Review the verdict section
below in the document to identify the corrected contract for these components,
then update Inc 0 and Inc 2 to replace the outdated names and approach with the
correct ones specified in the verdict, ensuring the entire plan document uses
one consistent contract throughout.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f6f3e6eb-dbd8-4111-b2ce-d1719bdab433

📥 Commits

Reviewing files that changed from the base of the PR and between 4c0af7a and dd731bd.

📒 Files selected for processing (4)

• .claude/board/EPIPHANIES.md
• .claude/board/INTEGRATION_PLANS.md
• .claude/plans/cypher-kanban-ast-unification-v1.md
• crates/lance-graph-contract/src/soa_view.rs