fix(contract+lock): extend ogar_codebook mirror with PRODUCT + ACCOUNTING_ACCOUNT (OGAR #111) and bump pin#597
Conversation
…TING_ACCOUNT (OGAR #111) and bump pin D2 — follow-up to the merged sibling D1 (lance-graph #595, `81d08c42`) which mirrored OGAR #110's auth domain. OGAR #111 just merged on the same day, adding two more entries to `ogar_vocab::class_ids::ALL`: - `product 0x0207` (← `product.template` / `product.product` converge) - `accounting_account 0x0208` (← `account.account` / `account.account.template` converge) Without this sync, `lance_graph_ogar::parity::COUNT_FUSE` panics again the moment a consumer (q2's Railway docker build is the canary) bumps its own OGAR pin to current main: mirror=43, ALL=45. Two coordinated fixes: 1. lance-graph-contract: extend ogar_codebook::CODEBOOK with the 2 new commerce-arm entries. Same convergence pattern as `commercial_document` (which both `account.move` and `sale.order` resolve to). No new ConceptDomain variant — both stay in Commerce (0x02XX). 2. Workspace Cargo.lock: bump pinned OGAR crates (ogar-vocab / ogar-class-view / ogar-ontology / ogar-adapter-surrealql) from `08a9c979` → `ac4b4162` (current OGAR main, post-#111 merge). 4 references in this lock. Safe SHA swap verified: Cargo.toml deps for all four OGAR crates are byte-identical between the two commits (`git diff 08a9c979..ac4b4162 -- crates/{ogar-vocab,ogar-class-view,ogar-ontology, ogar-adapter-surrealql}/Cargo.toml` returns EMPTY). Tests: - lance-graph-contract: 9 doctests pass (compile-time COUNT_FUSE passes) - lance-graph-ogar lib: 53/53 pass including parity::tests::mirror_is_a_faithful_copy_of_ogar_codebook - cargo build -p lance-graph-ogar: clean Closes the cycle named in E-OGAR-AUTH-MIRROR-DRIFT (lance-graph #596 / sibling-merged as #595/81d08c42): mirror updates must land in the SAME commit as any OGAR-side ALL-list extension. This PR demonstrates the discipline working — OGAR #111 merged this morning, the mirror catches up this afternoon (instead of three days later when q2's lock bumps). Source-of-finding: - AdaWorldAPI/OGAR#111 (introduced PRODUCT + ACCOUNTING_ACCOUNT) - AdaWorldAPI/odoo-rs#14 (the upstream finding: 11 missing OdooPort aliases) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
More reviews will be available in 43 minutes and 52 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
D2 — follow-up to the sibling-merged D1
Sibling PR
81d08c42(D1, merged earlier today) mirrored OGAR #110's authdomain. OGAR #111 just merged on the same day, adding two more entries
to
ogar_vocab::class_ids::ALL:product 0x0207—product.template/product.productconverge hereaccounting_account 0x0208—account.account/account.account.templateconverge here
(Same convergence pattern as
account.move ↔ sale.order → commercial_document.)Without this sync,
lance_graph_ogar::parity::COUNT_FUSEconst-eval-panicsthe moment a consumer bumps its OGAR pin to current main: mirror=43, ALL=45.
Same shape as the q2 #42 trigger that exposed D1's drift.
Background — D #596 closed in favor of this
When PR #596 (my original D, attempted to fix the OGAR #110 mirror) tried
to rebase onto main, it conflicted with the now-merged sibling D1
(
81d08c42). #596 is closed; this PR (D2) is the new follow-up, scopedto the next drift (OGAR #111) using the discipline named in
E-OGAR-AUTH-MIRROR-DRIFT.Two coordinated fixes
lance-graph-contract: extend
ogar_codebook::CODEBOOKwith the 2 newcommerce-arm entries. No new
ConceptDomainvariant — both stay Commerce(0x02XX). 6 lines added.
Workspace
Cargo.lock: bump pinned OGAR crates (ogar-vocab,ogar-class-view,ogar-ontology,ogar-adapter-surrealql) from08a9c979→ac4b4162(current OGAR main, post-docs: add γ+φ encoding + ModelPipeline DTO + Jina eval to handover Complete next-session pipeline: 1. Temperature fix (nucleus + thinking styles) 2. γ+φ golden ratio HDR re-encoding (per-role, Gate γ=1.50) 3. StandardizedModelPipeline DTO (6 models) 4. Jina cross-model eval (truth anchor) 5. Maverick 128E streaming (800 GB → ~1.2 GB) https://claude.ai/code/session_01ChLvBfpJS8dQhHxRD4pYNp #111 merge). 4 refs.Safe SHA swap verified —
Cargo.tomldeps byte-identical between the twocommits:
Tests
cargo test -p lance-graph-contract: 9 doctests pass (compile-time fuse passes)cargo test --libincrates/lance-graph-ogar: 53/53 pass, includingparity::tests::mirror_is_a_faithful_copy_of_ogar_codebookcargo build -p lance-graph-ogar: cleanDiscipline working as designed
This PR demonstrates the
E-OGAR-AUTH-MIRROR-DRIFTepiphany (in EPIPHANIES.mdsince sibling D1) holding: OGAR #111 merged this morning, the mirror catches
up this afternoon (instead of three days later when q2's lock bumps). Same
PR shape as D1; same minimal scope.
Source-of-finding
PRODUCT+ACCOUNTING_ACCOUNT; closes C of A+B+C)81d08c42) — already mirrored OGAR feat: MoE architecture — 4096 experts, top-128 sparse, 4-group hierarchy 4096 experts → router selects top-128 → each runs 16 internal layers → 4 hierarchical groups where expert outputs compose → collapse → token Architecture maps Qwopus's actual MoE structure: Router: 4096×4096 input distance table (which experts respond?) Expert internals: 256×256 per-layer tables (how does each expert think?) Sparse activation: only top-128 of 4096 fire (97% sparsity) Hierarchical meeting: experts compose at 4 intermediate points Performance: 42s for 3 prompts in release (128×16 MatVec per token) → production needs SIMD batching or GPU Output quality still blocked by attractor collapse ("!" dominates). Needs: thinking style temperature + persona routing + ONNX gate correction. https://claude.ai/code/session_01ChLvBfpJS8dQhHxRD4pYNp #110's auth