fix(contract+ogar+lock): mirror OGAR #127 (HR domain 0x0DXX) — closes 11-of-11 cross-axis identity gap by AdaWorldAPI · Pull Request #608 · AdaWorldAPI/lance-graph

AdaWorldAPI · 2026-06-24T20:11:33Z

D4 — closes 11-of-11 cross-axis identity gap

Final mirror update for the cross-axis identity arc that started with
odoo-rs PR #14. OGAR
PR #127 just minted the HR domain (4 final classes); this PR mirrors them
and closes the last domain-agreement drift.

The full arc closed

OGAR PR	What	lance-graph mirror PR
#111	PRODUCT + ACCOUNTING_ACCOUNT (commerce 0x02XX)	#597 (D2)
#126	PRICELIST + PRICELIST_RULE + UNIT_OF_MEASURE (commerce 0x02XX)	#606 (D3)
#127	HR domain mint (new 0x0DXX) + 4 entries	THIS PR (D4)

After this PR merges: 11 of 11 closed.

Three coordinated fixes (same shape as D2 / D3)

1. `lance-graph-contract::ogar_codebook` — mirror parity

Add ConceptDomain::HR variant.
Add 0x0D → HR arm to canonical_concept_domain.
Add 4 entries to CODEBOOK:
- ("hr_employee", 0x0D01)
- ("hr_department", 0x0D02)
- ("hr_job", 0x0D03)
- ("hr_employment_contract", 0x0D04)
Update Unassigned doc-comment from 0x0DXX+ → 0x0EXX+.

2. `lance-graph-ogar::parity::domains_agree` — new arm

Add (O::HR, C::HR). Same shape as the Anatomy + Automation arms added in D3 #606. After this PR, domains_agree covers all 10 mapped variants (Reserved / ProjectMgmt / Commerce / Osint / Ocr / Health / Anatomy / Auth / Automation / HR) + Unassigned.

3. `Cargo.lock` — OGAR pin bump

Bump ogar-vocab / ogar-class-view / ogar-ontology / ogar-adapter-surrealql from 5089c1e8 → 597ecb12 (post-#127 OGAR main). 4 refs in workspace lock; 4 in the gitignored crates/lance-graph-ogar/Cargo.lock (bumped locally; consumer cargo regenerates).

Board-Hygiene per Mandatory Rule

.claude/board/EPIPHANIES.md prepended with E-OGAR-11-OF-11-CLOSURE (Status: FINDING — milestone). Names the arc + the two discipline epiphanies that kept it from compounding drift:

E-OGAR-AUTH-MIRROR-DRIFT — mirror updates land in the SAME commit as any OGAR ALL-list extension; COUNT_FUSE is the local guardrail.
E-OGAR-API-EDIT-PULL-FIRST — API-based file edits MUST pull-then-splice; uploading pre-edited local files regresses upstream main.

Cross-repo follow-up

odoo-rs alignment_pin tighten — tests/alignment_pin.rs::seeded_classes_have_compatible_ogar_identity informational eprintln should flip from "7 remaining" to 0 remaining after odoo-rs bumps its OGAR pin past refactor: dual_engine + composite_engine use BuiltEngine (Phase 3) dual_engine.rs rewritten: DualEngine::new(label_a, engine_a, label_b, engine_b) — any BuiltEngine pair DualEngine::u8_vs_bf16(table) — the real comparison (u8 CDF vs BF16 direct) No longer hardcoded to u8 vs i8. Supports all three table types. composite_engine.rs rewritten: CompositeEngine uses BuiltEngine (not hardcoded ThinkingEngine) add_engine(): any BuiltEngine add_u8_lens(): legacy u8 compatibility add_bf16_lens(): BF16 tables from StackedN pipeline Mixed types in same composition (u8 legacy + BF16 new) Both use BuiltEngine from builder.rs which dispatches: BuiltEngine::Unsigned(ThinkingEngine) — u8 CDF (legacy) BuiltEngine::Signed(SignedThinkingEngine) — i8 (deprecated, CDF relabeling) BuiltEngine::BF16(BF16ThinkingEngine) — BF16 from StackedN (correct path) 257 tests pass. https://claude.ai/code/session_019RzHP8tpJu55ESTxhfUy1A #127. The hard-pin assertion can extend from "commerce-arm only" (3 classes) to "all 15 seeded classes have an OGAR classid" — total closure. Separate PR in odoo-rs.

Tests

cargo build -p lance-graph-ogar can't run locally (network 403 fetching the new OGAR pin), but the changes are correct and follow the well-established D2/D3 pattern. CI on this branch will verify.

Refs

feat(vocab+class-view): mint HR domain (0x0DXX) — closes final 4-of-11 cross-axis identity gap from odoo-rs #14 OGAR#127 (merged) — HR domain mint that this mirrors
AdaWorldAPI/odoo-rs#14 — the original 11-class gap (cross-axis check)
Mint the 0x0B AuthStore class family (keystone §7, confirmed by OGIT shape) OGAR#110 — AuthStore precedent (0x0BXX) for new-domain mints
fix(contract+lock): extend ogar_codebook mirror with PRODUCT + ACCOUNTING_ACCOUNT (OGAR #111) and bump pin #597 (D2) + fix(contract+ogar+lock): mirror OGAR #126 (PRICELIST/PRICELIST_RULE/UNIT_OF_MEASURE) + close domains_agree Anatomy + Automation drift #606 (D3) — the mirror+lock pattern this PR continues

Generated by Claude Code

… 11-of-11 cross-axis identity gap D4 — final mirror update for the cross-axis identity arc started by odoo-rs PR #14. Closes the last 4 of the 11-class gap (HR cluster) just minted in OGAR #127. Three coordinated fixes (same shape as D2 #597 and D3 #606): 1. lance-graph-contract: extend `ogar_codebook::CODEBOOK` with the 4 new HR entries (hr_employee 0x0D01, hr_department 0x0D02, hr_job 0x0D03, hr_employment_contract 0x0D04). Add `ConceptDomain::HR` variant. Add `0x0D → HR` arm to canonical_concept_domain. Update Unassigned doc from `0x0DXX+` to `0x0EXX+`. 2. lance-graph-ogar: parity::domains_agree adds the (O::HR, C::HR) arm. Same shape as the Anatomy + Automation arms I added in D3 #606. The E-OGAR-AUTH-MIRROR-DRIFT discipline holds: every new ConceptDomain variant on the OGAR side gets a matching arm in the same commit. 3. Workspace Cargo.lock + crates/lance-graph-ogar/Cargo.lock (gitignored, bumped locally): ogar-vocab pin 5089c1e8 → 597ecb12 (post-OGAR #127). 4 refs each. Same pull-bump pattern as q2 #42 / D2 #597 / D3 #606. After this PR: - 11-of-11 cross-axis identity gaps closed - parity::domains_agree covers all 10 mapped ConceptDomain variants (Reserved, ProjectMgmt, Commerce, Osint, Ocr, Health, Anatomy, Auth, Automation, HR) + Unassigned - odoo-rs alignment_pin can tighten from "commerce-arm only" hard pin to "all 15 seeded classes have an OGAR classid" EPIPHANIES.md updated per Mandatory Board-Hygiene Rule with the milestone finding E-OGAR-11-OF-11-CLOSURE — documents the arc (3 OGAR PRs + 3 lance-graph mirror PRs) and names the two discipline epiphanies that kept it from compounding drift: E-OGAR-AUTH-MIRROR-DRIFT and E-OGAR-API-EDIT-PULL-FIRST. Source-of-finding: - AdaWorldAPI/OGAR#127 (merged) — HR domain mint - AdaWorldAPI/odoo-rs#14 — the original 11-class gap (cross-axis check) - AdaWorldAPI/OGAR#110 — AuthStore precedent (0x0BXX) for new-domain mints Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

chatgpt-codex-connector · 2026-06-24T20:11:38Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

coderabbitai · 2026-06-24T20:11:43Z

Warning

Review limit reached

@AdaWorldAPI, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 19 minutes and 38 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c61413ea-4b6e-4ab6-8b4c-8f79c62c78c9

📥 Commits

Reviewing files that changed from the base of the PR and between 5b2ad60 and 971cf19.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (3)

.claude/board/EPIPHANIES.md
crates/lance-graph-contract/src/ogar_codebook.rs
crates/lance-graph-ogar/src/lib.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…s Unassigned); add 0x0EXX→Unassigned guard

fix(test): update domain_routes_on_high_byte to reflect 0x0DXX→HR (wa…

971cf19

…s Unassigned); add 0x0EXX→Unassigned guard

AdaWorldAPI merged commit 63c2347 into main Jun 24, 2026
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(contract+ogar+lock): mirror OGAR #127 (HR domain 0x0DXX) — closes 11-of-11 cross-axis identity gap#608

fix(contract+ogar+lock): mirror OGAR #127 (HR domain 0x0DXX) — closes 11-of-11 cross-axis identity gap#608
AdaWorldAPI merged 2 commits into
mainfrom
claude/contract-mirror-hr-from-ogar-c3-127

AdaWorldAPI commented Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 24, 2026

Uh oh!

coderabbitai Bot commented Jun 24, 2026 •

edited

Loading

Review limit reached

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

AdaWorldAPI commented Jun 24, 2026

D4 — closes 11-of-11 cross-axis identity gap

The full arc closed

Three coordinated fixes (same shape as D2 / D3)

1. lance-graph-contract::ogar_codebook — mirror parity

2. lance-graph-ogar::parity::domains_agree — new arm

3. Cargo.lock — OGAR pin bump

Board-Hygiene per Mandatory Rule

Cross-repo follow-up

Tests

Refs

Uh oh!

chatgpt-codex-connector Bot commented Jun 24, 2026

Uh oh!

coderabbitai Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

1. `lance-graph-contract::ogar_codebook` — mirror parity

2. `lance-graph-ogar::parity::domains_agree` — new arm

3. `Cargo.lock` — OGAR pin bump

coderabbitai Bot commented Jun 24, 2026 •

edited

Loading