forked from lance-format/lance-graph
-
Notifications
You must be signed in to change notification settings - Fork 0
NO-PIN OGAR path deps + plug-and-play contract arming + roundtrip green light #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5503812
NO-PIN policy: OGAR as sibling path deps + plug-and-play contract arming
claude f9e528d
lance-graph-ogar: authoritative-table roundtrip green light (ID-level…
claude 9608151
Fix CI workspace load: contract back to zero-dep; OGAR sibling in CI
claude 6f9158f
Generic hot-plug: contract socket + OgarAuthority bridge
claude 7cc6279
CI: run the lance-graph-ogar fuse tests (armed tier) in rust-test
claude d72c46f
Drop the accidental cargo-fmt sweep of 69 unrelated files
claude dd46ad2
Board discipline: hot-plug consumer-migration doc + E-HOTPLUG-MIGRATI…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path dependency makes the default workspace require a sibling OGAR checkout even when the new
ogarfeature is not enabled.lance-graph-contractis a workspace member, and Cargo still resolves optional path dependency manifests during workspace resolution; in a normal checkout without/workspace/OGAR,cargo metadata --manifest-path crates/lance-graph-contract/Cargo.toml --no-depsaborts withfailed to read /workspace/OGAR/crates/ogar-vocab/Cargo.toml. That breaks the documented zero-dep/default CI-gated contract build unless every environment now provisions OGAR, so the optional dependency needs to remain resolvable without that sibling or be moved out of the default workspace path.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed and fixed in 9608151 (before this thread landed — same failure hit CI directly): the optional path dep +
ogarfeature are removed entirely; the contract is strictly zero-dep again, with the workspace-load lesson documented in the manifest comment. The armed tier (fuses + live-vocab access) lives in the workspace-EXCLUDEDlance-graph-ogarcrate, whose path deps cannot affect workspace resolution.Generated by Claude Code