Commit b30c5b6
committed
ci(format): enforce stable rustfmt + drop continue-on-error band-aid
PR #133 (commits 7ca1cf3 + ed59b3b) stripped all 13 nightly-only
directives from `rustfmt.toml` and normalized the codebase to stable
rustfmt 1.94.1. The CI fmt job, however, was never updated to leverage
this — it still used:
uses: dtolnay/rust-toolchain@nightly
continue-on-error: true
…which left fmt failures showing as "passing" on PR checks (an
atom-bomb red flag for code-style invariants). The original
`continue-on-error: true` rationale ("5,679 drift sites with nightly
rustfmt") was dependent on the nightly-only directives that PR #133
already removed. The band-aid was stale.
This commit completes what PR #133 implied:
- Switch fmt job from `dtolnay/rust-toolchain@nightly` to
`dtolnay/rust-toolchain@1.95.0` (the rust-toolchain.toml pin).
- Remove `continue-on-error: true` — fmt failures now block merge,
as they should.
- Rename the job from `format/nightly` → `format/stable` to reflect
the actual toolchain.
- Replace the stale 24-line comment block with a 12-line explanation
citing PR #133 as the source of stable-clean state.
Plus the 3 drift sites between stable 1.94.1 and stable 1.95.0
(import ordering changes in `src/hpc/clam.rs`, `src/hpc/mod.rs`,
`src/hpc/udf_kernels.rs`) — `cargo fmt --all` on 1.95.0 normalizes
them. Bundled with the 1.95 bump since this PR is the trigger.
Verified: `cargo fmt --all --check` clean on 1.95.0 post-commit.
Companion to PR #133 / "where did that PR go" — completes the missed
step.1 parent 9501793 commit b30c5b6
4 files changed
Lines changed: 18 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
73 | 75 | | |
74 | 76 | | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
86 | 81 | | |
87 | 82 | | |
88 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1281 | 1281 | | |
1282 | 1282 | | |
1283 | 1283 | | |
1284 | | - | |
| 1284 | + | |
1285 | 1285 | | |
1286 | 1286 | | |
1287 | 1287 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
250 | | - | |
| 250 | + | |
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
0 commit comments