cockpit/fma: nested "outer wall" rendering — the address IS the wall#49
Conversation
The /fma view drew floating nodes; that throws away the [container:identity] nesting. Add one rounded "outer wall" box per container (Organ→Tissue; cells are leaves), drawn behind the nodes via the beforeDrawing canvas hook, colored by class, nested so the Heart's box is the outermost wall (its epicardium). Each box bounds its tier-prefix descendants: a node is inside container c's wall iff its 8:8 tier instances match c's down to c's depth — c's address is a prefix of n's. So the walls fall straight out of the address, no geometry heuristic. Verified against the baked asset: descendant counts per container match the partonomy exactly (Heart 89, chamber 22, wall 7, tissue 3). tsc clean; browser render not exercised here. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TzqvDqbFRzyx17EkLKBoZF
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
More reviews will be available in 36 minutes and 17 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
Follow-up to #48 (which landed the FMA
/fmaview + 8:8[container:identity]addressing). This is the one orphaned commit left on the branch after #48 merged.What
Adds nested "outer wall" rendering to the
/fmacockpit view: one rounded box per container (Organ → Tissue; cells are leaves), drawn behind the nodes via vis-network'sbeforeDrawingcanvas hook, colored by class, nested so the Heart's box is the outermost wall (its epicardium). A node-link scatter hides the[container:identity]nesting; the walls make it visible.The walls fall out of the address
A node is inside container c's wall iff its 8:8 tier instances match c's down to c's depth — i.e. c's address is a prefix of the node's. So each box is just the bbox of c's tier-prefix descendants; no geometry heuristic, the partonomy is the key.
Verification
tscclean.Possible follow-up: a true 2D treemap (compartments tiling the frame, no depth bands) instead of the current band-layout + boxes — a larger layout swap, deferred unless wanted.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TzqvDqbFRzyx17EkLKBoZF
Generated by Claude Code