Skip to content

Commit 91d4273

Browse files
committed
chore(tooling): make .rustfmt.toml stable-honest; record CI/fmt findings
The .rustfmt.toml enabled nightly-only options (wrap_comments, imports_granularity, group_imports, comment_width) while the build toolchain is pinned stable 1.95 and the fmt job that would apply them (pinned rust-toolchain.nightly via ci.yml) is not running — GitHub Actions is not enabled on this fork (PR #29 head has zero check runs). So those options were enforced by nothing yet made stable `cargo fmt` warn and reformat divergently. Comment them out so stable `cargo fmt` (the 1.95 pin, matching org policy of 99% stable / nightly only for Miri) is the single authoritative formatter. Re-enable as a block if a nightly-fmt CI job is ever turned on and the tree is normalized under it in one dedicated pass. Findings (no CI on the fork; rustfmt split-brain) recorded in .claude/board/EPIPHANIES.md. https://claude.ai/code/session_01R9AWgFa65uPnLyS2my2d2R
1 parent 5997eea commit 91d4273

2 files changed

Lines changed: 41 additions & 10 deletions

File tree

.claude/board/EPIPHANIES.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,3 +114,28 @@ previously reclaimed that space immediately).
114114
115115
**Cross-ref:** codex P1 on PR #29 (discussion_r3328296248); fix in this
116116
commit; regression `test_timeline_write_delete_commit_is_single_atomic_version`.
117+
118+
## 2026-05-30 — No CI runs on this fork; .rustfmt.toml is split-brain (stable build, nightly-only fmt opts)
119+
**Status:** FINDING
120+
**Scope:** repo CI/tooling — `.github/workflows/ci.yml`, `.rustfmt.toml`, `rust-toolchain*`
121+
122+
PR #29 head (5997eea) has ZERO check runs; the only commit status is the
123+
CodeRabbit review bot (pending). `ci.yml` triggers on every `pull_request`
124+
(no branch filter), so the absence is environmental: GitHub Actions is not
125+
enabled/approved on the AdaWorldAPI fork. Net: the only merge gate is the
126+
review bots + the human owner — there is no test/clippy/fmt enforcement.
127+
Separately, `.rustfmt.toml` enables nightly-only options (wrap_comments,
128+
imports_granularity=Module, group_imports=StdExternalCrate, comment_width)
129+
while the build toolchain is pinned stable 1.95 (`rust-toolchain.toml`); the
130+
fmt-only nightly (`rust-toolchain.nightly` = nightly-2025-08-07) is never run
131+
here. Running fmt under either stable or that nightly reformats the WHOLE
132+
crate (~1900 lines, 22+ files) => HEAD is not fmt-clean under its own config.
133+
Consequence: "future-proof" config that no gate enforces is pure drift. Per
134+
the org's 99%-stable policy (nightly only for Miri in ndarray), the resolution
135+
is to make the config stable-honest (comment out the unstable opts) and lean
136+
on stable tools (cargo-machete et al.). A one-time stable `cargo fmt`
137+
normalization is a separate, deliberate follow-up (not triggered here, to
138+
avoid mixing mass reformat churn into feature commits).
139+
140+
**Cross-ref:** PR #29 check status (0 runs); ci.yml on-block; this commit's
141+
`.rustfmt.toml` change; GRIDLAKE_BUILD.md.

.rustfmt.toml

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,21 @@ use_field_init_shorthand = true
77
use_small_heuristics = "Off"
88

99
# -----------------------------------
10-
# Unstable options we would like to use in future
10+
# Unstable options (nightly-only rustfmt) — DISABLED.
11+
#
12+
# Org policy is 99% stable Rust (nightly is reserved for Miri in
13+
# `ndarray`). The job that would apply these — the pinned
14+
# `rust-toolchain.nightly` fmt in ci.yml — is not running (GitHub Actions
15+
# is not enabled on this fork), so these options were enforced by NOTHING
16+
# while still making stable `cargo fmt` warn and reformat divergently.
17+
# Commented out so stable `cargo fmt` (toolchain 1.95, per
18+
# rust-toolchain.toml) is the single authoritative formatter. Re-enable as
19+
# a block IF/WHEN a nightly-fmt CI job is turned on AND the tree is
20+
# normalized under it in one dedicated pass.
21+
# See .claude/board/EPIPHANIES.md (2026-05-30 CI/rustfmt finding).
1122
# -----------------------------------
1223

13-
imports_granularity = "Module"
14-
#blank_lines_lower_bound = 1
15-
group_imports = "StdExternalCrate"
16-
#indent_style = "Block"
17-
#match_arm_blocks = true
18-
#reorder_impl_items = true
19-
wrap_comments = true
20-
21-
comment_width = 100
24+
# imports_granularity = "Module"
25+
# group_imports = "StdExternalCrate"
26+
# wrap_comments = true
27+
# comment_width = 100

0 commit comments

Comments
 (0)