Add Firebase Analytics session ID binding#118
Merged
Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+sessionIDWithCompletion:fromFIRAnalytics.h.analytics-sessionidwithcompletion, that calls the new managed API and verifies the call reaches native without binding-layer exceptions.Validation
dotnet pack source/Firebase/Analytics/Analytics.csproj --configuration Release --output outputzsh -n tools/e2e/run-firebase-foundation.shpython3 -m json.tool tests/E2E/Firebase.Foundation/runtime-drift-cases.json >/dev/nulltools/e2e/run-firebase-foundation.sh --package-dir output --configuration Debug --runtime-drift-case analytics-sessionidwithcompletionThe targeted E2E case passed. The native callback returned
NSError: Analytics uninitialized, which is acceptable here because the binding crossed into Firebase correctly withoutObjCRuntime.ObjCException, selector failure, or marshaling failure.