Passwords should not be set

[frafra]

Passwords should not be set for LDAP users. GitLab API shows that password is an optional field: https://docs.gitlab.com/ce/api/users.html#user-creation

[Adambean]

Hi Fran,

I agree, though I had to have a password set for new users or the Gitlab API would reject the creation.

From 818c52c

generateRandomPassword(): New helper function to generate fairly random passwords for new users, as a user for some reason can't be created without a password. (They'll never need it though!) -- See https://gitlab.com/gitlab-org/gitlab-ce/issues/55426

[frafra]

Ok, thanks for reporting it.

[Adambean]

https://docs.gitlab.com/api/users/#create-a-user

The password for the user. Required if force_random_password or reset_password are not defined. If either force_random_password or reset_password are defined, those settings take priority.

Looks like the most ideal approach to this would be to pass force_random_password, and allow GitLab to generate a static password for the user according to its secure process.

Edit: Looks like my upstream issue was moved to https://gitlab.com/gitlab-org/gitlab/-/work_items/25802 and agrees with this approach.

[Adambean]

A fix for this has been committed in 500aad6, branch issue/9-password-should-not-be-set