Added token for multiline line height in type ramp#273
Merged
Conversation
bheston
requested review from
KingOfTac,
awentzel and
nicholasrice
as code owners
November 14, 2025 22:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Updated the type ramp to support differentiation between single line and multiline usage, where multiline typically needs a larger line height for readability.
Test Plan
Tested in Adaptive UI Explorer
Checklist
General
⏭ Next Steps
Update the Type Scale generator to allow for an easing function for line heights. It's common that smaller font sizes need more line height but larger sizes like for headings do not.