Skip to content

Remove pkg resources#272

Merged
MMathisLab merged 2 commits into
AdaptiveMotorControlLab:mainfrom
vovw:remove-pkg-resources
Sep 24, 2025
Merged

Remove pkg resources#272
MMathisLab merged 2 commits into
AdaptiveMotorControlLab:mainfrom
vovw:remove-pkg-resources

Conversation

@vovw

@vovw vovw commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

resolves #271

@cla-bot cla-bot Bot added the CLA signed label Sep 15, 2025
@stes

stes commented Sep 15, 2025

Copy link
Copy Markdown
Member

Hi @vovw , thanks! Could you select only this commit

image

on this PR?

- Replace pkg_resources.parse_version() with packaging.version.parse()
- Replace pkg_resources.get_distribution() with importlib.metadata.distribution()
- Update imports in cebra/integrations/sklearn/cebra.py, cebra/helper.py, tests/test_sklearn.py, tests/test_plot.py
- Fixes deprecation warning: pkg_resources is deprecated as an API and slated for removal as early as 2025-11-30

Resolves AdaptiveMotorControlLab#271
@vovw vovw force-pushed the remove-pkg-resources branch from 849f1a8 to ce9d817 Compare September 15, 2025 21:22
@vovw

vovw commented Sep 15, 2025

Copy link
Copy Markdown
Contributor Author

should be fixed

@stes stes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i would propose to ignore the windows test

@MMathisLab MMathisLab merged commit 6e0e2f4 into AdaptiveMotorControlLab:main Sep 24, 2025
10 of 11 checks passed
@vovw vovw deleted the remove-pkg-resources branch September 24, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove pkg_resources from codebase

3 participants