feat(filtering): add time-windowed filtering support to custom filtering rules#8380
Open
hossihub wants to merge 1 commit into
Open
feat(filtering): add time-windowed filtering support to custom filtering rules#8380hossihub wants to merge 1 commit into
hossihub wants to merge 1 commit into
Conversation
This change enables users to apply time-based constraints to custom
filtering rules via new syntax modifiers: $start, $end, and $tz.
- Added support for `$start='HH:mm'` and `$end='HH:mm'` in rule
strings.
- Implemented logic to handle standard windows and cross-midnight
intervals.
- Integrated time-check into the DNS filtering pipeline (matchHost).
- Leverages the existing global timezone settings for consistency.
- Added a 'now' function hook in DNSFilter for deterministic unit
testing.
Syntax
- ||example.com^$start='09:00'$end='18:00' (Active during work hours)
- @@||example.com^$start='22:00'$end='04:00' (Active during night
hours)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables users to apply time-based constraints to custom
filtering rules via new syntax modifiers: $start, $end
Added support for
$start='HH:mm'and$end='HH:mm'in rule strings.Implemented logic to handle standard windows and cross-midnight intervals.
Integrated time-check into the DNS filtering pipeline (matchHost).
Leverages the existing global timezone settings for consistency.
Added a 'now' function hook in DNSFilter for deterministic unit testing. Syntax
||example.com^$start='09:00'$end='18:00' (Active during work hours)
@@||example.com^$start='22:00'$end='04:00' (Active during night hours)