client: fix misleading "until tomorrow" label to "for 24 hours"#8381
Open
Gilmoursa wants to merge 1 commit into
Open
client: fix misleading "until tomorrow" label to "for 24 hours"#8381Gilmoursa wants to merge 1 commit into
Gilmoursa wants to merge 1 commit into
Conversation
The disable-protection timing labelled "Until tomorrow" actually disables for exactly 24 hours (TOMORROW = 24 * 60 * 60 * 1000 ms), not until midnight the next day. Update the English source strings to match the actual behaviour, consistent with the "for N minutes/seconds" pattern used by the other disable-timing labels. Closes AdguardTeam#6944
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disable-protection option labelled "Until tomorrow" actually disables for exactly 24 hours (
TOMORROW = 24 * 60 * 60 * 1000 ms), not until midnight the next day. This makes the label actively misleading — a user who clicks it at 11pm would expect 1 hour of downtime but gets 24.This changes the two English source strings to match the actual behaviour, and is consistent with the "for N minutes/seconds" pattern already used by the other disable-timing labels.
Other locales are intentionally left unchanged — they should be updated through CrowdIn once the source strings are accepted.
Closes #6944