Fix DNS rewrite CNAMEs for DHCP hostnames#8413
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8068.
This updates the unresolved DHCP-host path to re-check the current request name after filtering rewrites a local-domain query to a CNAME target. When the rewritten name is a known DHCP hostname, the server now returns the local DHCP answer and lets post-filtering restore the original question and prepend the CNAME.
Tests:
go test ./internal/dnsforward -run TestServer_ProcessDHCPHosts_rewrittenCNAME -count=1go test ./internal/dnsforward ./internal/filtering -count=1go test -race ./internal/dnsforward -run 'TestServer_ProcessDHCPHosts|TestServer_ProcessUpstream' -count=1\n-make go-lint\n-git diff --check\n\nNotes:\n-make go-lintprints existing Go 1.26.3 standard-librarygovulncheckfindings (GO-2026-5039,GO-2026-5037), and the target still passes with its configured non-reproducible vulnerability-scan ignore.\n-make go-testreached the touchedinternal/dnsforwardpackage successfully, then failed later ininternal/homebecauseTestWeb_HandleGetProfile/add_usertimed out after 1m30s while running bcrypt under the race detector. The isolated retrygo test -race ./internal/home -run TestWeb_HandleGetProfile -count=1 -timeout 5mpassed.