Skip to content

Fix #231462 arktimes.com#231489

Open
mu-hun wants to merge 17 commits into
masterfrom
Fix-#231462-arktimes.com
Open

Fix #231462 arktimes.com#231489
mu-hun wants to merge 17 commits into
masterfrom
Fix-#231462-arktimes.com

Conversation

@mu-hun
Copy link
Copy Markdown
Member

@mu-hun mu-hun commented May 18, 2026

Prerequisites

To avoid invalid pull requests, please check and confirm following terms

  • This is not an ad/bug report;
  • My code follows the guidelines and syntax of this project;
  • I have performed a self-review of my own changes;
  • My changes do not break web sites, apps and files structure.

What problem does the pull request fix?

If the problem does not fall under any category that is listed here, please write a comment below in corresponding section

  • Missed ads or ad leftovers;
  • Website or app doesn't work properly;
  • AdGuard gets detected on a website;
  • Missed analytics or tracker;
  • Social media buttons — share, like, tweet, etc;
  • Annoyances — pop-ups, cookie warnings, etc;
  • Filters maintenance.

What issue is being fixed?

Enter the issue address

Fix #231462

Add your comment and screenshots

Hides the broken popup containers from wordpress newspack plugin

Please see #231462 (comment)

Terms

  • By submitting this issue, I agree that pull request does not contain private info and all conditions are met

@mu-hun mu-hun requested a review from a team May 18, 2026 05:45
@mu-hun mu-hun self-assigned this May 18, 2026
Copy link
Copy Markdown
Member Author

@mu-hun mu-hun May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Screenshot) musically.com has the same breakage Screenshot 2026-05-18 at 2 18 00 PM

Copy link
Copy Markdown
Member

@Alex-302 Alex-302 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

montanafreepress.org has different elements with .newspack-popup-container. One - subscription, and one - donation. Please check carefully. It is important here, because these categories are in different filters.

Comment thread AnnoyancesFilter/Popups/sections/subscriptions_specific.txt
@mu-hun
Copy link
Copy Markdown
Member Author

mu-hun commented May 19, 2026

Okay, I will recheck carefully for these changes 👀

@mu-hun mu-hun mentioned this pull request May 19, 2026
@mu-hun mu-hun requested a review from Alex-302 May 19, 2026 10:41
Comment thread BaseFilter/sections/specific.txt Outdated
Comment on lines +960 to +963
hongkongfp.com##block-123
hongkongfp.com##block-122
hongkongfp.com##block-121
hongkongfp.com##block-120
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Screenshot) ads with referrer code Image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you did not test the rules, and added them intuitively - they are invalid. That's not a good option. Also keep in mind that CSS rules, even simple ones, may not work with programs under certain conditions.

This selector matches ad images

.widget-area > section.widget:has(> div.wp-block-columns img[src*="referral"])

For text block

hongkongfp.com###block-121

or better universal (it seems not dangerous without :contains() - small fonts frequently used for ad labels)

hongkongfp.com##.widget-area > section.widget:has(> p.has-small-font-size)

Copy link
Copy Markdown
Member Author

@mu-hun mu-hun May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you did not test the rules, and added them intuitively - they are invalid.

It just my mistake about missing the sharp symbol 😰 Also, If I can find specific hints like src or href in child elements, I’ll take those when designing the rule.

There are many rules that use the #block-\d format. (search query: repo:AdguardTeam/AdguardFilters /#block-\d/) I think it’s fine to keep using this kind of rule format in the meantime.

Comment thread BaseFilter/sections/specific.txt Outdated
Comment on lines +960 to +963
hongkongfp.com##block-123
hongkongfp.com##block-122
hongkongfp.com##block-121
hongkongfp.com##block-120
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you did not test the rules, and added them intuitively - they are invalid. That's not a good option. Also keep in mind that CSS rules, even simple ones, may not work with programs under certain conditions.

This selector matches ad images

.widget-area > section.widget:has(> div.wp-block-columns img[src*="referral"])

For text block

hongkongfp.com###block-121

or better universal (it seems not dangerous without :contains() - small fonts frequently used for ad labels)

hongkongfp.com##.widget-area > section.widget:has(> p.has-small-font-size)

Comment thread AnnoyancesFilter/Popups/sections/subscriptions_specific.txt Outdated
Comment thread AnnoyancesFilter/Popups/sections/subscriptions_specific.txt Outdated
Comment thread AnnoyancesFilter/Popups/sections/subscriptions_specific.txt Outdated
Comment thread AnnoyancesFilter/Popups/sections/subscriptions_specific.txt Outdated
!
! SECTION: Subscriptions - Regular rules
!
hongkongfp.com###block-60
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use :has() with .newspack-newsletters-subscribe. More obvious selector.
Or at least check in web archive if that ID is constant for content.

Comment thread AnnoyancesFilter/Other/sections/self-promo.txt Outdated
@mu-hun mu-hun requested a review from Alex-302 May 21, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

arktimes.com

2 participants