Fix #231462 arktimes.com#231489
Conversation
Hides the broken popup containers from wordpress newspack plugin
was reported from #200211 The same rule no longer applies to the NOT_OPTIMIZED comment.
Alex-302
left a comment
There was a problem hiding this comment.
montanafreepress.org has different elements with .newspack-popup-container. One - subscription, and one - donation. Please check carefully. It is important here, because these categories are in different filters.
|
Okay, I will recheck carefully for these changes 👀 |
| hongkongfp.com##block-123 | ||
| hongkongfp.com##block-122 | ||
| hongkongfp.com##block-121 | ||
| hongkongfp.com##block-120 |
There was a problem hiding this comment.
It seems you did not test the rules, and added them intuitively - they are invalid. That's not a good option. Also keep in mind that CSS rules, even simple ones, may not work with programs under certain conditions.
This selector matches ad images
.widget-area > section.widget:has(> div.wp-block-columns img[src*="referral"])
For text block
hongkongfp.com###block-121
or better universal (it seems not dangerous without :contains() - small fonts frequently used for ad labels)
hongkongfp.com##.widget-area > section.widget:has(> p.has-small-font-size)
There was a problem hiding this comment.
It seems you did not test the rules, and added them intuitively - they are invalid.
It just my mistake about missing the sharp symbol 😰 Also, If I can find specific hints like src or href in child elements, I’ll take those when designing the rule.
There are many rules that use the #block-\d format. (search query: repo:AdguardTeam/AdguardFilters /#block-\d/) I think it’s fine to keep using this kind of rule format in the meantime.
| hongkongfp.com##block-123 | ||
| hongkongfp.com##block-122 | ||
| hongkongfp.com##block-121 | ||
| hongkongfp.com##block-120 |
There was a problem hiding this comment.
It seems you did not test the rules, and added them intuitively - they are invalid. That's not a good option. Also keep in mind that CSS rules, even simple ones, may not work with programs under certain conditions.
This selector matches ad images
.widget-area > section.widget:has(> div.wp-block-columns img[src*="referral"])
For text block
hongkongfp.com###block-121
or better universal (it seems not dangerous without :contains() - small fonts frequently used for ad labels)
hongkongfp.com##.widget-area > section.widget:has(> p.has-small-font-size)
| ! | ||
| ! SECTION: Subscriptions - Regular rules | ||
| ! | ||
| hongkongfp.com###block-60 |
There was a problem hiding this comment.
Better use :has() with .newspack-newsletters-subscribe. More obvious selector.
Or at least check in web archive if that ID is constant for content.
These are donation elements: #231489 (comment)


Prerequisites
To avoid invalid pull requests, please check and confirm following terms
What problem does the pull request fix?
If the problem does not fall under any category that is listed here, please write a comment below in corresponding section
What issue is being fixed?
Enter the issue address
Fix #231462
Add your comment and screenshots
Hides the broken popup containers from wordpress newspack plugin
Please see #231462 (comment)
Terms