Skip to content

Commit 8ed50d8

Browse files
committed
revert *2 for all Uij - somehow wrong
1 parent 16569c5 commit 8ed50d8

1 file changed

Lines changed: 16 additions & 16 deletions

File tree

GSASII/GSASIIstrMath.py

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1225,7 +1225,7 @@ def StructureFactor2(refDict,G,hfx,pfx,SGData,calcControls,parmDict):
12251225
Tindx = np.array([refDict['FF']['El'].index(El) for El in Tdata])
12261226
FFR = np.repeat(refDict['FF']['FF'][iBeg:iFin].T[Tindx].T,nOps*len(TwinLaw),axis=0)
12271227
FFI = np.zeros_like(FFR)
1228-
#FFR,FFI have to have the Slater*Sph.Har.*atm form factor for each refletion in Uniq for Q atoms; otherwise just normal FF
1228+
#FFR,FFI have to have the Slater*Sph.Har.*atm form factor for each reflection in Uniq for Q atoms; otherwise just normal FF
12291229
#this must be done here. NB: same place for non-spherical atoms; same math except no Bessel part.
12301230
if pfx in SHCdict:
12311231
FFR,FFI = MakeSpHarmFF(Uniq,Amat,Bmat,SHCdict[pfx],Tdata,hType,FFtables,ORBtables,BLtables,FFR,SQ)
@@ -1422,9 +1422,9 @@ def StructureFactorDerv2(refDict,G,hfx,pfx,SGData,calcControls,parmDict):
14221422
dFdvDict[pfx+'AU11:'+str(i)] = dFdua.T[0][i]
14231423
dFdvDict[pfx+'AU22:'+str(i)] = dFdua.T[1][i]
14241424
dFdvDict[pfx+'AU33:'+str(i)] = dFdua.T[2][i]
1425-
dFdvDict[pfx+'AU12:'+str(i)] = 2.*dFdua.T[3][i]
1426-
dFdvDict[pfx+'AU13:'+str(i)] = 2.*dFdua.T[4][i]
1427-
dFdvDict[pfx+'AU23:'+str(i)] = 2.*dFdua.T[5][i]
1425+
dFdvDict[pfx+'AU12:'+str(i)] = dFdua.T[3][i] #"should" be *2.0 but not true
1426+
dFdvDict[pfx+'AU13:'+str(i)] = dFdua.T[4][i]
1427+
dFdvDict[pfx+'AU23:'+str(i)] = dFdua.T[5][i]
14281428
for item in dffdSHR:
14291429
if 'Sh' in item or 'O' in item:
14301430
if i == int(item.split(':')[1]):
@@ -1736,9 +1736,9 @@ def MagStructureFactorDerv(refDict,G,hfx,pfx,SGData,calcControls,parmDict):
17361736
dFdvDict[pfx+'AU11:'+str(i)] = dFdua.T[0][i]
17371737
dFdvDict[pfx+'AU22:'+str(i)] = dFdua.T[1][i]
17381738
dFdvDict[pfx+'AU33:'+str(i)] = dFdua.T[2][i]
1739-
dFdvDict[pfx+'AU12:'+str(i)] = 2.*dFdua.T[3][i]
1740-
dFdvDict[pfx+'AU13:'+str(i)] = 2.*dFdua.T[4][i]
1741-
dFdvDict[pfx+'AU23:'+str(i)] = 2.*dFdua.T[5][i]
1739+
dFdvDict[pfx+'AU12:'+str(i)] = dFdua.T[3][i]
1740+
dFdvDict[pfx+'AU13:'+str(i)] = dFdua.T[4][i]
1741+
dFdvDict[pfx+'AU23:'+str(i)] = dFdua.T[5][i]
17421742
return dFdvDict
17431743

17441744
def StructureFactorDervTw2(refDict,G,hfx,pfx,SGData,calcControls,parmDict):
@@ -1898,9 +1898,9 @@ def StructureFactorDervTw2(refDict,G,hfx,pfx,SGData,calcControls,parmDict):
18981898
dFdvDict[pfx+'AU11:'+str(i)] = np.sum(dFdua.T[0][i]*TwinFr[:,nxs],axis=0)
18991899
dFdvDict[pfx+'AU22:'+str(i)] = np.sum(dFdua.T[1][i]*TwinFr[:,nxs],axis=0)
19001900
dFdvDict[pfx+'AU33:'+str(i)] = np.sum(dFdua.T[2][i]*TwinFr[:,nxs],axis=0)
1901-
dFdvDict[pfx+'AU12:'+str(i)] = 2.*np.sum(dFdua.T[3][i]*TwinFr[:,nxs],axis=0)
1902-
dFdvDict[pfx+'AU13:'+str(i)] = 2.*np.sum(dFdua.T[4][i]*TwinFr[:,nxs],axis=0)
1903-
dFdvDict[pfx+'AU23:'+str(i)] = 2.*np.sum(dFdua.T[5][i]*TwinFr[:,nxs],axis=0)
1901+
dFdvDict[pfx+'AU12:'+str(i)] = np.sum(dFdua.T[3][i]*TwinFr[:,nxs],axis=0)
1902+
dFdvDict[pfx+'AU13:'+str(i)] = np.sum(dFdua.T[4][i]*TwinFr[:,nxs],axis=0)
1903+
dFdvDict[pfx+'AU23:'+str(i)] = np.sum(dFdua.T[5][i]*TwinFr[:,nxs],axis=0)
19041904
dFdvDict[phfx+'BabA'] = dFdbab.T[0]
19051905
dFdvDict[phfx+'BabU'] = dFdbab.T[1]
19061906
for i in range(nTwin):
@@ -2452,9 +2452,9 @@ def SStructureFactorDerv(refDict,im,G,hfx,pfx,SGData,SSGData,calcControls,parmDi
24522452
dFdvDict[pfx+'AU11:'+str(i)] = dFdua.T[0][i]
24532453
dFdvDict[pfx+'AU22:'+str(i)] = dFdua.T[1][i]
24542454
dFdvDict[pfx+'AU33:'+str(i)] = dFdua.T[2][i]
2455-
dFdvDict[pfx+'AU12:'+str(i)] = 2.*dFdua.T[3][i]
2456-
dFdvDict[pfx+'AU13:'+str(i)] = 2.*dFdua.T[4][i]
2457-
dFdvDict[pfx+'AU23:'+str(i)] = 2.*dFdua.T[5][i]
2455+
dFdvDict[pfx+'AU12:'+str(i)] = dFdua.T[3][i]
2456+
dFdvDict[pfx+'AU13:'+str(i)] = dFdua.T[4][i]
2457+
dFdvDict[pfx+'AU23:'+str(i)] = dFdua.T[5][i]
24582458
for j in range(FSSdata.shape[1]): #loop over waves Fzero & Fwid?
24592459
dFdvDict[pfx+'Fsin:'+str(i)+':'+str(j)] = dFdGf.T[0][j][i]
24602460
dFdvDict[pfx+'Fcos:'+str(i)+':'+str(j)] = dFdGf.T[1][j][i]
@@ -2692,9 +2692,9 @@ def SStructureFactorDervTw(refDict,im,G,hfx,pfx,SGData,SSGData,calcControls,parm
26922692
dFdvDict[pfx+'AU11:'+str(i)] = dFdua.T[0][i]
26932693
dFdvDict[pfx+'AU22:'+str(i)] = dFdua.T[1][i]
26942694
dFdvDict[pfx+'AU33:'+str(i)] = dFdua.T[2][i]
2695-
dFdvDict[pfx+'AU12:'+str(i)] = 2.*dFdua.T[3][i]
2696-
dFdvDict[pfx+'AU13:'+str(i)] = 2.*dFdua.T[4][i]
2697-
dFdvDict[pfx+'AU23:'+str(i)] = 2.*dFdua.T[5][i]
2695+
dFdvDict[pfx+'AU12:'+str(i)] = dFdua.T[3][i]
2696+
dFdvDict[pfx+'AU13:'+str(i)] = dFdua.T[4][i]
2697+
dFdvDict[pfx+'AU23:'+str(i)] = dFdua.T[5][i]
26982698
for j in range(FSSdata.shape[1]): #loop over waves Fzero & Fwid?
26992699
dFdvDict[pfx+'Fsin:'+str(i)+':'+str(j)] = dFdGf.T[0][j][i]
27002700
dFdvDict[pfx+'Fcos:'+str(i)+':'+str(j)] = dFdGf.T[1][j][i]

0 commit comments

Comments
 (0)