Fix shopperIP#1306
Open
MarioNaise wants to merge 2 commits into
Open
Conversation
|
Hi @merijndebeer-adyen , A colleague has provided a fix for the issue described above. This is an important issue for us because it prevents the correct IP address from being sent to Adyen. As a result, the 3D Secure popup is shown to customers more frequently than necessary, which could negatively impact our conversion rate. It would be great if you could review the PR when you have a moment. If you have any questions, please feel free to contact me or @MarioNaise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
shopperIPfield inmakePaymentRequestandcreateSessionRequestobjects:Currently,
payment.controller.jsunconditionally sets theshopperIPfield onpaymentObjectto the value from the requestsx-forwarded-forheader and then applies it to the initial request object later on.This means that any
shopperIPprovided by the initial request gets lost.Additionally, the
x-forwarded-forheader contains a wrong value (most likely the Commercetools server IP), so it should not be used as a fallback at all.Instead, if
shopperIPis missing in the clients request, it should just stayundefined.Tested scenarios
makePaymentRequestcontainsshopperIP->shopperIPwill be forwarded to AdyenmakePaymentRequestdoesn't containshopperIP->shopperIPstaysundefinedcreateSessionRequestcontainsshopperIP->shopperIPwill be forwarded to AdyencreateSessionRequestdoesn't containshopperIP->shopperIPstaysundefinedFixed issue: