Release v35.0.0#1483
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increments the library version from 34.0.3 to 34.0.4 across the solution, including project files, source code constants, and the version file. Feedback was provided to streamline the Adyen.csproj file by removing redundant version properties that are automatically handled by the .NET SDK and to replace the version-based package tags with descriptive keywords for better NuGet discoverability.
| <Version>34.0.4</Version> | ||
| <AssemblyVersion>34.0.4</AssemblyVersion> | ||
| <FileVersion>34.0.4</FileVersion> |
There was a problem hiding this comment.
In .NET SDK-style projects, the <Version> property automatically sets the default for <AssemblyVersion> and <FileVersion>. Since these values are identical, you can remove the redundant tags to simplify the project file.
<Version>34.0.4</Version>
| <RepositoryUrl>https://github.com/Adyen/adyen-dotnet-api-library</RepositoryUrl> | ||
| <RepositoryType>git</RepositoryType> | ||
| <PackageTags>34.0.3</PackageTags> | ||
| <PackageTags>34.0.4</PackageTags> |
There was a problem hiding this comment.
The <PackageTags> property should contain descriptive keywords for NuGet search (e.g., adyen;payments;api). Using the version number as the only tag is not recommended. Consider adding descriptive tags.
<PackageTags>adyen;payments;api;sdk</PackageTags>
AdyenAutomationBot
force-pushed
the
promote/main
branch
5 times, most recently
from
b66c6d4 to
6a75de8
Compare
AdyenAutomationBot
force-pushed
the
promote/main
branch
21 times, most recently
from
95ff6bd to
b30b9d4
Compare
AdyenAutomationBot
force-pushed
the
promote/main
branch
4 times, most recently
from
09b2a3d to
ed3abf0
Compare
AdyenAutomationBot
force-pushed
the
promote/main
branch
24 times, most recently
from
2978a56 to
a8076b5
Compare
2 participants
Merged pull requests to be released:
Full Changelog: v34.0.3...main