[dataprotection] Code generation: update services and models#1700
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the SubjectErasureResponse model to improve enum value handling and updates the SDK generation metadata. Feedback suggests adding a null check for the raw result value during JSON deserialization to avoid nullability warnings and maintain consistency with other conversion methods.
| case "result": | ||
| string? resultRawValue = utf8JsonReader.GetString(); | ||
| result = new Option<SubjectErasureResponse.ResultEnum?>(SubjectErasureResponse.ResultEnum.FromStringOrDefault(resultRawValue)); | ||
| result = new Option<SubjectErasureResponse.ResultEnum?>(SubjectErasureResponse.ResultEnum.FromStringOrDefault(resultRawValue) ?? (SubjectErasureResponse.ResultEnum)resultRawValue); |
Contributor
There was a problem hiding this comment.
The resultRawValue variable is of type string?, but FromStringOrDefault expects a non-nullable string. Passing a null value here will trigger a nullability warning. Additionally, for consistency with the implementation in ResultEnumJsonConverter.Read (line 175), it's better to check for null before calling the conversion methods.
result = new Option<SubjectErasureResponse.ResultEnum?>(resultRawValue == null ? null : SubjectErasureResponse.ResultEnum.FromStringOrDefault(resultRawValue) ?? (SubjectErasureResponse.ResultEnum)resultRawValue);
gcatanese
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the automated changes for the
dataprotectionservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.